| Message ID | 20220830192212.28570-9-farbere@amazon.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Variety of fixes and new features for mr75203 driver | expand |
On Tue, 30 Aug 2022 19:22:01 +0000, Eliav Farber wrote: > Add optional "moortec,vm-active-channels" property to define the number > of active channels per VM. > > This shall be useful to avoid exposing sysfs for reading inputs that are > not connected to any voltage source. > > Signed-off-by: Eliav Farber <farbere@amazon.com> > --- > V3 -> V2: > - Add "moortec" prefix to property name. > - Add explanation why this change is needed. > > .../devicetree/bindings/hwmon/moortec,mr75203.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml: error checking schema file /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml: ignoring, error in schema: properties: moortec,vm-active-channels /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/moortec,mr75203.example.dtb: pvt@e0680000: 'moortec,vm-active-channels' does not match any of the regexes: '^#.*', '^(at25|bm|devbus|dmacap|dsa|exynos|fsi[ab]|gpio-fan|gpio-key|gpio|gpmc|hdmi|i2c-gpio),.*', '^(keypad|m25p|max8952|max8997|max8998|mpmc),.*', '^(pinctrl-single|#pinctrl-single|PowerPC),.*', '^(pl022|pxa-mmc|rcar_sound|rotary-encoder|s5m8767|sdhci),.*', '^(simple-audio-card|st-plgpio|st-spics|ts),.*', '^100ask,.*', '^70mai,.*', '^8dev,.*', '^GEFanuc,.*', '^ORCL,.*', '^SUNW,.*', '^[a-zA-Z0-9#_][a-zA-Z0-9+\\-._@]{0,63}$', '^[a-zA-Z0-9+\\-._]*@[0-9a-zA-Z,]*$', '^abb,.*', '^abilis,.*', '^abracon,.*', '^abt,.*', '^acer,.*', '^acme,.*', '^actions,.*', '^active-semi,.*', '^ad,.*', '^adafruit,.*', '^adapteva,.*', '^adaptrum,.*', '^adh,.*', '^adi,.*', '^advantech,.*', '^aeroflexgaisler,.*', '^aesop,.*', '^airoha,.*', '^al,.*', '^alcatel,.*', '^allegro,.*', '^allo,.*', '^allwinner,.*', '^alphascale,.*', '^al ps,.*', '^alt,.*', '^altr,.*', '^amarula,.*', '^amazon,.*', '^amcc,.*', '^amd,.*', '^amediatech,.*', '^amlogic,.*', '^ampere,.*', '^ampire,.*', '^ams,.*', '^amstaos,.*', '^analogix,.*', '^andestech,.*', '^anvo,.*', '^apm,.*', '^apple,.*', '^aptina,.*', '^arasan,.*', '^archermind,.*', '^arctic,.*', '^arcx,.*', '^aries,.*', '^arm,.*', '^armadeus,.*', '^arrow,.*', '^artesyn,.*', '^asahi-kasei,.*', '^asc,.*', '^asix,.*', '^aspeed,.*', '^asrock,.*', '^asus,.*', '^atheros,.*', '^atlas,.*', '^atmel,.*', '^auo,.*', '^auvidea,.*', '^avago,.*', '^avia,.*', '^avic,.*', '^avnet,.*', '^awinic,.*', '^axentia,.*', '^axis,.*', '^azoteq,.*', '^azw,.*', '^baikal,.*', '^bananapi,.*', '^beacon,.*', '^beagle,.*', '^bhf,.*', '^bitmain,.*', '^blutek,.*', '^boe,.*', '^bosch,.*', '^boundary,.*', '^brcm,.*', '^broadmobi,.*', '^bsh,.*', '^bticino,.*', '^buffalo,.*', '^bur,.*', '^bytedance,.*', '^calamp,.*', '^calaosystems,.*', '^calxeda,.*', '^canaan,.*', '^caninos,.*', '^capella,.*', '^cascoda,.*', '^catalys t,.*', '^cavium,.*', '^cdns,.*', '^cdtech,.*', '^cellwise,.*', '^ceva,.*', '^checkpoint,.*', '^chefree,.*', '^chipidea,.*', '^chipone,.*', '^chipspark,.*', '^chrontel,.*', '^chrp,.*', '^chunghwa,.*', '^chuwi,.*', '^ciaa,.*', '^cirrus,.*', '^cisco,.*', '^cloudengines,.*', '^cnm,.*', '^cnxt,.*', '^colorfly,.*', '^compulab,.*', '^congatec,.*', '^coreriver,.*', '^corpro,.*', '^cortina,.*', '^cosmic,.*', '^crane,.*', '^creative,.*', '^crystalfontz,.*', '^csky,.*', '^csq,.*', '^ctera,.*', '^ctu,.*', '^cubietech,.*', '^cui,.*', '^cypress,.*', '^cyx,.*', '^cznic,.*', '^dallas,.*', '^dataimage,.*', '^davicom,.*', '^dell,.*', '^delta,.*', '^densitron,.*', '^denx,.*', '^devantech,.*', '^dfi,.*', '^dh,.*', '^difrnce,.*', '^digi,.*', '^digilent,.*', '^dioo,.*', '^dlc,.*', '^dlg,.*', '^dlink,.*', '^dmo,.*', '^domintech,.*', '^dongwoon,.*', '^dptechnics,.*', '^dragino,.*', '^ds,.*', '^dserve,.*', '^dynaimage,.*', '^ea,.*', '^ebang,.*', '^ebbg,.*', '^ebs-systart,.*', '^ebv,.*', '^eckelmann,.*', '^e dimax,.*', '^edt,.*', '^eeti,.*', '^einfochips,.*', '^eink,.*', '^elan,.*', '^element14,.*', '^elgin,.*', '^elida,.*', '^elimo,.*', '^elpida,.*', '^embest,.*', '^emlid,.*', '^emmicro,.*', '^empire-electronix,.*', '^emtrion,.*', '^enclustra,.*', '^endless,.*', '^ene,.*', '^energymicro,.*', '^engicam,.*', '^engleder,.*', '^epcos,.*', '^epfl,.*', '^epson,.*', '^esp,.*', '^est,.*', '^ettus,.*', '^eukrea,.*', '^everest,.*', '^everspin,.*', '^evervision,.*', '^exar,.*', '^excito,.*', '^exegin,.*', '^ezchip,.*', '^facebook,.*', '^fairphone,.*', '^faraday,.*', '^fastrax,.*', '^fcs,.*', '^feixin,.*', '^feiyang,.*', '^fii,.*', '^firefly,.*', '^focaltech,.*', '^forlinx,.*', '^frida,.*', '^friendlyarm,.*', '^fsl,.*', '^fujitsu,.*', '^fxtec,.*', '^gardena,.*', '^gateworks,.*', '^gcw,.*', '^ge,.*', '^geekbuying,.*', '^gef,.*', '^gemei,.*', '^geniatech,.*', '^giantec,.*', '^giantplus,.*', '^globalscale,.*', '^globaltop,.*', '^gmt,.*', '^goodix,.*', '^google,.*', '^grinn,.*', '^grmn,.*', '^gumstix, .*', '^gw,.*', '^hannstar,.*', '^haochuangyi,.*', '^haoyu,.*', '^hardkernel,.*', '^hechuang,.*', '^hideep,.*', '^himax,.*', '^hirschmann,.*', '^hisi,.*', '^hisilicon,.*', '^hit,.*', '^hitex,.*', '^holt,.*', '^holtek,.*', '^honestar,.*', '^honeywell,.*', '^hoperun,.*', '^hp,.*', '^hpe,.*', '^hsg,.*', '^huawei,.*', '^hugsun,.*', '^hwacom,.*', '^hxt,.*', '^hycon,.*', '^hydis,.*', '^hynix,.*', '^hyundai,.*', '^i2se,.*', '^ibm,.*', '^icplus,.*', '^idt,.*', '^ifi,.*', '^ilitek,.*', '^imagis,.*', '^img,.*', '^imi,.*', '^incircuit,.*', '^inet-tek,.*', '^infineon,.*', '^inforce,.*', '^ingenic,.*', '^ingrasys,.*', '^injoinic,.*', '^innolux,.*', '^inside-secure,.*', '^insignal,.*', '^inspur,.*', '^intel,.*', '^intercontrol,.*', '^invensense,.*', '^inventec,.*', '^inversepath,.*', '^iom,.*', '^isee,.*', '^isil,.*', '^issi,.*', '^ite,.*', '^itead,.*', '^itian,.*', '^ivo,.*', '^iwave,.*', '^jdi,.*', '^jedec,.*', '^jesurun,.*', '^jethome,.*', '^jianda,.*', '^joz,.*', '^kam,.*', '^karo,.*', '^keith koep,.*', '^keymile,.*', '^khadas,.*', '^kiebackpeter,.*', '^kinetic,.*', '^kingdisplay,.*', '^kingnovel,.*', '^kionix,.*', '^kobo,.*', '^kobol,.*', '^koe,.*', '^kontron,.*', '^kosagi,.*', '^kvg,.*', '^kyo,.*', '^lacie,.*', '^laird,.*', '^lamobo,.*', '^lantiq,.*', '^lattice,.*', '^leadtek,.*', '^leez,.*', '^lego,.*', '^lemaker,.*', '^lenovo,.*', '^lg,.*', '^lgphilips,.*', '^libretech,.*', '^licheepi,.*', '^linaro,.*', '^linksprite,.*', '^linksys,.*', '^linutronix,.*', '^linux,.*', '^linx,.*', '^liteon,.*', '^litex,.*', '^lltc,.*', '^logicpd,.*', '^logictechno,.*', '^longcheer,.*', '^lontium,.*', '^loongson,.*', '^lsi,.*', '^lwn,.*', '^lxa,.*', '^m5stack,.*', '^macnica,.*', '^mantix,.*', '^mapleboard,.*', '^marvell,.*', '^maxbotix,.*', '^maxim,.*', '^mbvl,.*', '^mcube,.*', '^meas,.*', '^mecer,.*', '^mediatek,.*', '^megachips,.*', '^mele,.*', '^melexis,.*', '^melfas,.*', '^mellanox,.*', '^memsic,.*', '^menlo,.*', '^mentor,.*', '^meraki,.*', '^merrii,.*', '^micrel,.*', '^microchip,.*', '^microcrystal,.*', '^micron,.*', '^microsoft,.*', '^microsys,.*', '^mikroe,.*', '^mikrotik,.*', '^miniand,.*', '^minix,.*', '^miramems,.*', '^mitsubishi,.*', '^mixel,.*', '^miyoo,.*', '^mntre,.*', '^modtronix,.*', '^mosaixtech,.*', '^motorola,.*', '^moxa,.*', '^mpl,.*', '^mps,.*', '^mqmaker,.*', '^mrvl,.*', '^mscc,.*', '^msi,.*', '^mstar,.*', '^mti,.*', '^multi-inno,.*', '^mundoreader,.*', '^murata,.*', '^mxic,.*', '^mxicy,.*', '^myir,.*', '^national,.*', '^nec,.*', '^neonode,.*', '^netgear,.*', '^netlogic,.*', '^netron-dy,.*', '^netronix,.*', '^netxeon,.*', '^neweast,.*', '^newhaven,.*', '^nexbox,.*', '^nextthing,.*', '^ni,.*', '^nintendo,.*', '^nlt,.*', '^nokia,.*', '^nordic,.*', '^novtech,.*', '^nutsboard,.*', '^nuvoton,.*', '^nvd,.*', '^nvidia,.*', '^nxp,.*', '^oceanic,.*', '^ocs,.*', '^oct,.*', '^okaya,.*', '^oki,.*', '^olimex,.*', '^olpc,.*', '^oneplus,.*', '^onion,.*', '^onnn,.*', '^ontat,.*', '^opalkelly,.*', '^opencores,.*', '^openembed,.*', '^openrisc,.*', '^option,.*', '^oranth,.*', '^orisetech,.*', '^ortustech,.*', '^osddisplays,.*', '^osmc,.*', '^ouya,.*', '^overkiz,.*', '^ovti,.*', '^oxsemi,.*', '^ozzmaker,.*', '^panasonic,.*', '^parade,.*', '^parallax,.*', '^pda,.*', '^pericom,.*', '^pervasive,.*', '^phicomm,.*', '^phytec,.*', '^picochip,.*', '^pine64,.*', '^pineriver,.*', '^pixcir,.*', '^plantower,.*', '^plathome,.*', '^plda,.*', '^plx,.*', '^ply,.*', '^pni,.*', '^pocketbook,.*', '^polaroid,.*', '^portwell,.*', '^poslab,.*', '^pov,.*', '^powertip,.*', '^powervr,.*', '^primux,.*', '^probox2,.*', '^prt,.*', '^pulsedlight,.*', '^purism,.*', '^qca,.*', '^qcom,.*', '^qemu,.*', '^qi,.*', '^qiaodian,.*', '^qihua,.*', '^qishenglong,.*', '^qnap,.*', '^quanta,.*', '^radxa,.*', '^raidsonic,.*', '^ralink,.*', '^ramtron,.*', '^raspberrypi,.*', '^raydium,.*', '^rda,.*', '^realtek,.*', '^remarkable,.*', '^renesas,.*', '^rervision,.*', '^revotics,.*', '^rex,.*', '^richtek,.*', '^ricoh,.*', '^rikomagic,.*', '^riot,.*', '^riscv,.*', '^rockchip,.*', '^rocktech, .*', '^rohm,.*', '^ronbo,.*', '^roofull,.*', '^roseapplepi,.*', '^samsung,.*', '^samtec,.*', '^sancloud,.*', '^sandisk,.*', '^satoz,.*', '^sbs,.*', '^schindler,.*', '^seagate,.*', '^seeed,.*', '^seirobotics,.*', '^semtech,.*', '^senseair,.*', '^sensirion,.*', '^sensortek,.*', '^sercomm,.*', '^sff,.*', '^sgd,.*', '^sgmicro,.*', '^sgx,.*', '^sharp,.*', '^shift,.*', '^shimafuji,.*', '^shiratech,.*', '^si-en,.*', '^si-linux,.*', '^siemens,.*', '^sifive,.*', '^sigma,.*', '^sii,.*', '^sil,.*', '^silabs,.*', '^silan,.*', '^silead,.*', '^silergy,.*', '^silex-insight,.*', '^siliconfile,.*', '^siliconmitus,.*', '^silvaco,.*', '^simtek,.*', '^sinlinx,.*', '^sinovoip,.*', '^sinowealth,.*', '^sipeed,.*', '^sirf,.*', '^sis,.*', '^sitronix,.*', '^skov,.*', '^skyworks,.*', '^smartlabs,.*', '^smsc,.*', '^snps,.*', '^sochip,.*', '^socionext,.*', '^solidrun,.*', '^solomon,.*', '^sony,.*', '^spansion,.*', '^sparkfun,.*', '^spinalhdl,.*', '^sprd,.*', '^ssi,.*', '^sst,.*', '^sstar,.*', '^st,.*', '^st-eri csson,.*', '^starfive,.*', '^starry,.*', '^startek,.*', '^ste,.*', '^stericsson,.*', '^storlink,.*', '^storm,.*', '^storopack,.*', '^summit,.*', '^sunchip,.*', '^sundance,.*', '^sunplus,.*', '^supermicro,.*', '^swir,.*', '^syna,.*', '^synology,.*', '^synopsys,.*', '^tbs,.*', '^tbs-biometrics,.*', '^tcg,.*', '^tcl,.*', '^tcs,.*', '^tdo,.*', '^team-source-display,.*', '^technexion,.*', '^technologic,.*', '^techstar,.*', '^teltonika,.*', '^tempo,.*', '^terasic,.*', '^tesla,.*', '^tfc,.*', '^thead,.*', '^thine,.*', '^thingyjp,.*', '^thundercomm,.*', '^ti,.*', '^tianma,.*', '^tlm,.*', '^tmt,.*', '^topeet,.*', '^topic,.*', '^toppoly,.*', '^topwise,.*', '^toradex,.*', '^toshiba,.*', '^toumaz,.*', '^tpk,.*', '^tplink,.*', '^tpo,.*', '^tq,.*', '^traverse,.*', '^tronfy,.*', '^tronsmart,.*', '^truly,.*', '^tsd,.*', '^tyan,.*', '^u-blox,.*', '^u-boot,.*', '^ubnt,.*', '^ucrobotics,.*', '^udoo,.*', '^ugoos,.*', '^uniwest,.*', '^upisemi,.*', '^urt,.*', '^usi,.*', '^utoo,.*', '^v3,.*', '^vaisala,.* ', '^vamrs,.*', '^variscite,.*', '^vdl,.*', '^vertexcom,.*', '^via,.*', '^vicor,.*', '^videostrong,.*', '^virtio,.*', '^virtual,.*', '^vishay,.*', '^visionox,.*', '^vitesse,.*', '^vivante,.*', '^vivax,.*', '^vocore,.*', '^voipac,.*', '^vot,.*', '^vxt,.*', '^wanchanglong,.*', '^wand,.*', '^waveshare,.*', '^wd,.*', '^we,.*', '^welltech,.*', '^wetek,.*', '^wexler,.*', '^whwave,.*', '^wi2wi,.*', '^wiligear,.*', '^willsemi,.*', '^winbond,.*', '^wingtech,.*', '^winlink,.*', '^winstar,.*', '^wirelesstag,.*', '^wits,.*', '^wlf,.*', '^wm,.*', '^wobo,.*', '^x-powers,.*', '^xen,.*', '^xes,.*', '^xiaomi,.*', '^xillybus,.*', '^xingbangda,.*', '^xinpeng,.*', '^xiphera,.*', '^xlnx,.*', '^xnano,.*', '^xunlong,.*', '^xylon,.*', '^yadro,.*', '^yamaha,.*', '^yes-optoelectronics,.*', '^yic,.*', '^ylm,.*', '^yna,.*', '^yones-toptech,.*', '^ys,.*', '^ysoft,.*', '^zarlink,.*', '^zealz,.*', '^zeitec,.*', '^zidoo,.*', '^zii,.*', '^zinitix,.*', '^zkmagic,.*', '^zte,.*', '^zyxel,.*', 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/vendor-prefixes.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/moortec,mr75203.example.dtb: pvt@e0680000: intel,vm-map: b'\x03\x01\x04\xff\xff' is not of type 'object', 'array', 'boolean', 'null' From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/dt-core.yaml Documentation/devicetree/bindings/hwmon/moortec,mr75203.example.dtb:0:0: /example-0/pvt@e0680000: failed to match any schema with compatible: ['moortec,mr75203'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Wed, Aug 31, 2022 at 6:53 AM Farber, Eliav <farbere@amazon.com> wrote: > > On 8/31/2022 2:39 PM, Rob Herring wrote: > > On Tue, 30 Aug 2022 19:22:01 +0000, Eliav Farber wrote: > > Add optional "moortec,vm-active-channels" property to define the number > of active channels per VM. > > This shall be useful to avoid exposing sysfs for reading inputs that are > not connected to any voltage source. > > Signed-off-by: Eliav Farber <farbere@amazon.com> > --- > V3 -> V2: > - Add "moortec" prefix to property name. > - Add explanation why this change is needed. > > .../devicetree/bindings/hwmon/moortec,mr75203.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > I used dt_binding_check on my changes (I ported it to my kernel). > The error is related to "intel-vm-map" which I did not add. The error is the vendor prefix is not defined in vendor-prefixes.yaml. > I don't mind fixing it if you wish. > It requires changing: > intel,vm-map = [03 01 04 ff ff]; > to: > intel,vm-map = /bits/8 <0x03 0x01 0x04 0xff 0xff>; That is not the issue. The issue is the type is unknown because your schema fails and we can't get the type from it. Once your schema passes, this should go away. Rob
On 8/31/2022 3:17 PM, Rob Herring wrote: > On Wed, Aug 31, 2022 at 6:53 AM Farber, Eliav <farbere@amazon.com> wrote: >> >> On 8/31/2022 2:39 PM, Rob Herring wrote: >> >> On Tue, 30 Aug 2022 19:22:01 +0000, Eliav Farber wrote: >> >> Add optional "moortec,vm-active-channels" property to define the number >> of active channels per VM. >> >> This shall be useful to avoid exposing sysfs for reading inputs that are >> not connected to any voltage source. >> >> Signed-off-by: Eliav Farber <farbere@amazon.com> >> --- >> V3 -> V2: >> - Add "moortec" prefix to property name. >> - Add explanation why this change is needed. >> >> .../devicetree/bindings/hwmon/moortec,mr75203.yaml | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> I used dt_binding_check on my changes (I ported it to my kernel). >> The error is related to "intel-vm-map" which I did not add. > > The error is the vendor prefix is not defined in vendor-prefixes.yaml. I fixed the vendor prefix error (will be part of v4). >> I don't mind fixing it if you wish. >> It requires changing: >> intel,vm-map = [03 01 04 ff ff]; >> to: >> intel,vm-map = /bits/8 <0x03 0x01 0x04 0xff 0xff>; > > That is not the issue. The issue is the type is unknown because your > schema fails and we can't get the type from it. Once your schema > passes, this should go away. Even after fixing the vendor prefix error I still see this: moortec,mr75203.yaml: ignoring, error in schema: properties: intel,vm-map moortec,mr75203.example.dtb: pvt@e0680000: intel,vm-map: b'\x03\x01\x04\xff\xff' is not of type 'object', 'array', 'boolean', 'null' -- Regards, Eliav
On Wed, Aug 31, 2022 at 12:48 PM Farber, Eliav <farbere@amazon.com> wrote: > > On 8/31/2022 3:17 PM, Rob Herring wrote: > > On Wed, Aug 31, 2022 at 6:53 AM Farber, Eliav <farbere@amazon.com> wrote: > >> > >> On 8/31/2022 2:39 PM, Rob Herring wrote: > >> > >> On Tue, 30 Aug 2022 19:22:01 +0000, Eliav Farber wrote: > >> > >> Add optional "moortec,vm-active-channels" property to define the number > >> of active channels per VM. > >> > >> This shall be useful to avoid exposing sysfs for reading inputs that are > >> not connected to any voltage source. > >> > >> Signed-off-by: Eliav Farber <farbere@amazon.com> > >> --- > >> V3 -> V2: > >> - Add "moortec" prefix to property name. > >> - Add explanation why this change is needed. > >> > >> .../devicetree/bindings/hwmon/moortec,mr75203.yaml | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > >> > >> I used dt_binding_check on my changes (I ported it to my kernel). > >> The error is related to "intel-vm-map" which I did not add. > > > > The error is the vendor prefix is not defined in vendor-prefixes.yaml. > > I fixed the vendor prefix error (will be part of v4). > > >> I don't mind fixing it if you wish. > >> It requires changing: > >> intel,vm-map = [03 01 04 ff ff]; > >> to: > >> intel,vm-map = /bits/8 <0x03 0x01 0x04 0xff 0xff>; > > > > That is not the issue. The issue is the type is unknown because your > > schema fails and we can't get the type from it. Once your schema > > passes, this should go away. > Even after fixing the vendor prefix error I still see this: > moortec,mr75203.yaml: ignoring, error in schema: properties: intel,vm-map You still have an error in the schema. You should see a more specific reason before this message. > moortec,mr75203.example.dtb: pvt@e0680000: intel,vm-map: > b'\x03\x01\x04\xff\xff' is not of type 'object', 'array', 'boolean', 'null' > > -- > Regards, Eliav
On 8/31/2022 10:19 PM, Rob Herring wrote: > On Wed, Aug 31, 2022 at 12:48 PM Farber, Eliav <farbere@amazon.com> > wrote: >> >> On 8/31/2022 3:17 PM, Rob Herring wrote: >> > On Wed, Aug 31, 2022 at 6:53 AM Farber, Eliav <farbere@amazon.com> >> wrote: >> >> >> >> On 8/31/2022 2:39 PM, Rob Herring wrote: >> >> >> >> On Tue, 30 Aug 2022 19:22:01 +0000, Eliav Farber wrote: >> >> >> >> Add optional "moortec,vm-active-channels" property to define the >> number >> >> of active channels per VM. >> >> >> >> This shall be useful to avoid exposing sysfs for reading inputs >> that are >> >> not connected to any voltage source. >> >> >> >> Signed-off-by: Eliav Farber <farbere@amazon.com> >> >> --- >> >> V3 -> V2: >> >> - Add "moortec" prefix to property name. >> >> - Add explanation why this change is needed. >> >> >> >> .../devicetree/bindings/hwmon/moortec,mr75203.yaml | 11 +++++++++++ >> >> 1 file changed, 11 insertions(+) >> >> >> >> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m >> dt_binding_check' >> >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> >> >> I used dt_binding_check on my changes (I ported it to my kernel). >> >> The error is related to "intel-vm-map" which I did not add. >> > >> > The error is the vendor prefix is not defined in vendor-prefixes.yaml. >> >> I fixed the vendor prefix error (will be part of v4). >> >> >> I don't mind fixing it if you wish. >> >> It requires changing: >> >> intel,vm-map = [03 01 04 ff ff]; >> >> to: >> >> intel,vm-map = /bits/8 <0x03 0x01 0x04 0xff 0xff>; >> > >> > That is not the issue. The issue is the type is unknown because your >> > schema fails and we can't get the type from it. Once your schema >> > passes, this should go away. >> Even after fixing the vendor prefix error I still see this: >> moortec,mr75203.yaml: ignoring, error in schema: properties: >> intel,vm-map > > You still have an error in the schema. You should see a more specific > reason before this message. Thanks, I found the problem. I'm using an old version, and I'm missing this commit you did: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml?h=v6.0-rc3&id=d69c6ddd019f31081cc0232fa8ad8ea1cabdf22c
diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml index 2ec4b9da4b92..69cc6caceb2c 100644 --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml @@ -44,6 +44,16 @@ properties: "#thermal-sensor-cells": const: 1 + moortec,vm-active-channels: + description: + moortec,vm-active-channels defines the number of channels per VM that are + actually used and are connected to some source. + Number of values in the array should be the number of VMs. + A value of 0 means that the entire VM sensor is nou used. + maximum: 16 + default: 16 + $ref: /schemas/types.yaml#definitions/uint8-array + required: - compatible - reg @@ -65,5 +75,6 @@ examples: intel,vm-map = [03 01 04 ff ff]; clocks = <&osc0>; resets = <&rcu0 0x40 7>; + moortec,vm-active-channels = <0x10 0x05>; #thermal-sensor-cells = <1>; };
Add optional "moortec,vm-active-channels" property to define the number of active channels per VM. This shall be useful to avoid exposing sysfs for reading inputs that are not connected to any voltage source. Signed-off-by: Eliav Farber <farbere@amazon.com> --- V3 -> V2: - Add "moortec" prefix to property name. - Add explanation why this change is needed. .../devicetree/bindings/hwmon/moortec,mr75203.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)