[v2,00/10] qapi examples fixes, simplified version

Message

Victor Toso Sept. 1, 2022, 8:58 a.m. UTC

Hi,

This is the follow up from v1. I've dropped a few patches that need
further discussion. I plan to revisit those when submiting the generator
again at a later time.

v1: https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg04525.html

Changes in v2:
 * Dropped "qapi: fix example of blockdev-add command". It was wrong.
 * Dropped patches with too long examples as we might want to cut them
   short. I've also dropped the patches that fixes examples with
   comments on them as we might want to have a way to do that.
 * Fixed style in:
  - qapi: fix example of NIC_RX_FILTER_CHANGED event
  - qapi: fix example of query-dump-guest-memory-capability command
 * Dropped the generator (rfc) as I'll submit it again later, improved.

Cheers,
Victor

Victor Toso (10):
  qapi: fix example of query-ballon command
  qapi: fix example of query-vnc command
  qapi: fix example of query-dump-guest-memory-capability command
  qapi: fix example of BLOCK_JOB_READY event
  qapi: fix example of NIC_RX_FILTER_CHANGED event
  qapi: fix example of DEVICE_UNPLUG_GUEST_ERROR event
  qapi: fix example of MEM_UNPLUG_ERROR event
  qapi: fix examples of blockdev-add with qcow2
  qapi: fix example of query-hotpluggable-cpus command
  qapi: fix examples of events missing timestamp

 qapi/block-core.json | 12 ++++++------
 qapi/dump.json       |  2 +-
 qapi/machine.json    |  8 ++++----
 qapi/migration.json  | 27 +++++++++++++++++++++++----
 qapi/net.json        |  1 -
 qapi/qdev.json       |  3 +--
 qapi/ui.json         |  4 ++--
 7 files changed, 37 insertions(+), 20 deletions(-)

Comments

Markus Armbruster Sept. 1, 2022, 12:20 p.m. UTC | #1

Victor Toso <[e-mail]> writes:

> Hi,
>
> This is the follow up from v1. I've dropped a few patches that need
> further discussion. I plan to revisit those when submiting the generator
> again at a later time.

Reviewed-by: Markus Armbruster <[e-mail]>

and queued.  Thanks!

[...]