| Message ID | 20220901141511.50523-1-hamza.mahfooz@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/amd/display: fix indentation in commit_planes_for_stream() | expand |
[Public]
Acked-by: Alex Deucher <alexander.deucher@amd.com>
On 2022-09-01 10:15, Hamza Mahfooz wrote: > Address the following warning: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] > 3508 | if (update_type != UPDATE_TYPE_FAST) > | ^~ > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ > 3510 | if (update_type != UPDATE_TYPE_FAST) > | ^~ > > Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com> > --- > v2: implement feedback from Alvin > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c > index b49237390cce..9860bf38c547 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c > @@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc, > > if (update_type != UPDATE_TYPE_FAST) > dc->hwss.post_unlock_program_front_end(dc, context); > - if (update_type != UPDATE_TYPE_FAST) > - if (dc->hwss.commit_subvp_config) > - dc->hwss.commit_subvp_config(dc, context); > + > + if (update_type != UPDATE_TYPE_FAST) > + if (dc->hwss.commit_subvp_config) > + dc->hwss.commit_subvp_config(dc, context); > > /* Since phantom pipe programming is moved to post_unlock_program_front_end, > * move the SubVP lock to after the phantom pipes have been setup Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> and applied to amd-staging-drm-next. Thanks Siqueira
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index b49237390cce..9860bf38c547 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc, if (update_type != UPDATE_TYPE_FAST) dc->hwss.post_unlock_program_front_end(dc, context); - if (update_type != UPDATE_TYPE_FAST) - if (dc->hwss.commit_subvp_config) - dc->hwss.commit_subvp_config(dc, context); + + if (update_type != UPDATE_TYPE_FAST) + if (dc->hwss.commit_subvp_config) + dc->hwss.commit_subvp_config(dc, context); /* Since phantom pipe programming is moved to post_unlock_program_front_end, * move the SubVP lock to after the phantom pipes have been setup
Address the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 3508 | if (update_type != UPDATE_TYPE_FAST) | ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 3510 | if (update_type != UPDATE_TYPE_FAST) | ^~ Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com> --- v2: implement feedback from Alvin --- drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)