[net-next,0/6] net: ipa: use IDs to track transaction state

Message

Alex Elder Aug. 31, 2022, 10:40 p.m. UTC

This series is the first of three groups of changes that simplify
the way the IPA driver tracks the state of its transactions.

Each GSI channel has a fixed number of transactions allocated at
initialization time.  The number allocated matches the number of
TREs in the transfer ring associated with the channel.  This is
because the transfer ring limits the number of transfers that can
ever be underway, and in the worst case, each transaction represents
a single TRE.

Transactions go through various states during their lifetime.
Currently a set of lists keeps track of which transactions are in
each state.  Initially, all transactions are free.  An allocated
transaction is placed on the allocated list.  Once an allocated
transaction is committed, it is moved from the allocated to the
committed list.  When a committed transaction is sent to hardware
(via a doorbell) it is moved to the pending list.  When hardware
signals that some work has completed, transactions are moved to the
completed list.  Finally, when a completed transaction is polled
it's moved to the polled list before being removed when it becomes
free.

Changing a transaction's state thus normally involves manipulating
two lists, and to prevent corruption a spinlock is held while the
lists are updated.

Transactions move through their states in a well-defined sequence
though, and they do so strictly in order.  So transaction 0 is
always allocated before transaction 1; transaction 0 is always
committed before transaction 1; and so on, through completion,
polling, and becoming free.  Because of this, it's sufficient to
just keep track of which transaction is the first in each state.
The rest of the transactions in a given state can be derived from
the first transaction in an "adjacent" state.  As a result, we can
track the state of all transactions with a set of indexes, and can
update these without the need for a spinlock.

This first group of patches just defines the set of indexes that
will be used for this new way of tracking transaction state.  Two
more groups of patches will follow.  I've broken the 17 patches into
these three groups to facilitate review.

					-Alex

Alex Elder (6):
  net: ipa: use an array for transactions
  net: ipa: track allocated transactions with an ID
  net: ipa: track committed transactions with an ID
  net: ipa: track pending transactions with an ID
  net: ipa: track completed transactions with an ID
  net: ipa: track polled transactions with an ID

 drivers/net/ipa/gsi.h       |  9 +++-
 drivers/net/ipa/gsi_trans.c | 99 ++++++++++++++++++++++++++++++-------
 2 files changed, 89 insertions(+), 19 deletions(-)

Comments

[e-mail] Sept. 2, 2022, 11:30 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Wed, 31 Aug 2022 17:40:11 -0500 you wrote:
> This series is the first of three groups of changes that simplify
> the way the IPA driver tracks the state of its transactions.
> 
> Each GSI channel has a fixed number of transactions allocated at
> initialization time.  The number allocated matches the number of
> TREs in the transfer ring associated with the channel.  This is
> because the transfer ring limits the number of transfers that can
> ever be underway, and in the worst case, each transaction represents
> a single TRE.
> 
> [...]

Here is the summary with links:
  - [net-next,1/6] net: ipa: use an array for transactions
    (no matching commit)
  - [net-next,2/6] net: ipa: track allocated transactions with an ID
    https://git.kernel.org/netdev/net-next/c/41e2a2c054b8
  - [net-next,3/6] net: ipa: track committed transactions with an ID
    https://git.kernel.org/netdev/net-next/c/fc95d958e27d
  - [net-next,4/6] net: ipa: track pending transactions with an ID
    https://git.kernel.org/netdev/net-next/c/eeff7c14e08c
  - [net-next,5/6] net: ipa: track completed transactions with an ID
    https://git.kernel.org/netdev/net-next/c/949cd0b5c296
  - [net-next,6/6] net: ipa: track polled transactions with an ID
    https://git.kernel.org/netdev/net-next/c/fd3bd0398a0d

You are awesome, thank you!