| Message ID | 20220902101610.109646-2-romain.naour@smile.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 13767525929db1693b24555c07878d8cb3a274be |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v3:,net-next,1/4] net: dsa: microchip: add KSZ9896 switch support | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | warning | Series does not have a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 11 of 11 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Fri, 2022-09-02 at 12:16 +0200, Romain Naour wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > From: Romain Naour <romain.naour@skf.com> > > Add support for the KSZ9896 6-port Gigabit Ethernet Switch to the > ksz9477 driver. The KSZ9896 supports both SPI (already in) and I2C. > > Signed-off-by: Romain Naour <romain.naour@skf.com> > --- > The KSZ9896 support i2c interface, it seems safe to enable as is but > runtime testing is really needed (my KSZ9896 is wired with spi). > > v2: remove duplicated SoB line > --- > drivers/net/dsa/microchip/ksz9477_i2c.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/dsa/microchip/ksz9477_i2c.c > b/drivers/net/dsa/microchip/ksz9477_i2c.c > index 99966514d444..8fbc122e3384 100644 > --- a/drivers/net/dsa/microchip/ksz9477_i2c.c > +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c > @@ -91,6 +91,10 @@ static const struct of_device_id ksz9477_dt_ids[] > = { > .compatible = "microchip,ksz9477", > .data = &ksz_switch_chips[KSZ9477] > }, > + { > + .compatible = "microchip,ksz9896", > + .data = &ksz_switch_chips[KSZ9896] > + }, Do we need to add the compatible in ksz_spi interface as well, since ksz9896 supports both i2c and spi interface. > { > .compatible = "microchip,ksz9897", > .data = &ksz_switch_chips[KSZ9897] > -- > 2.34.3 >
Hi Arun, Le 02/09/2022 à 15:39, Arun.Ramadoss@microchip.com a écrit : > On Fri, 2022-09-02 at 12:16 +0200, Romain Naour wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you >> know the content is safe >> >> From: Romain Naour <romain.naour@skf.com> >> >> Add support for the KSZ9896 6-port Gigabit Ethernet Switch to the >> ksz9477 driver. The KSZ9896 supports both SPI (already in) and I2C. >> >> Signed-off-by: Romain Naour <romain.naour@skf.com> >> --- >> The KSZ9896 support i2c interface, it seems safe to enable as is but >> runtime testing is really needed (my KSZ9896 is wired with spi). >> >> v2: remove duplicated SoB line >> --- >> drivers/net/dsa/microchip/ksz9477_i2c.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/dsa/microchip/ksz9477_i2c.c >> b/drivers/net/dsa/microchip/ksz9477_i2c.c >> index 99966514d444..8fbc122e3384 100644 >> --- a/drivers/net/dsa/microchip/ksz9477_i2c.c >> +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c >> @@ -91,6 +91,10 @@ static const struct of_device_id ksz9477_dt_ids[] >> = { >> .compatible = "microchip,ksz9477", >> .data = &ksz_switch_chips[KSZ9477] >> }, >> + { >> + .compatible = "microchip,ksz9896", >> + .data = &ksz_switch_chips[KSZ9896] >> + }, > > Do we need to add the compatible in ksz_spi interface as well, since > ksz9896 supports both i2c and spi interface. That's what the first patch does. Thanks for your review. Best regards, Romain > >> { >> .compatible = "microchip,ksz9897", >> .data = &ksz_switch_chips[KSZ9897] >> -- >> 2.34.3 >>
diff --git a/drivers/net/dsa/microchip/ksz9477_i2c.c b/drivers/net/dsa/microchip/ksz9477_i2c.c index 99966514d444..8fbc122e3384 100644 --- a/drivers/net/dsa/microchip/ksz9477_i2c.c +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c @@ -91,6 +91,10 @@ static const struct of_device_id ksz9477_dt_ids[] = { .compatible = "microchip,ksz9477", .data = &ksz_switch_chips[KSZ9477] }, + { + .compatible = "microchip,ksz9896", + .data = &ksz_switch_chips[KSZ9896] + }, { .compatible = "microchip,ksz9897", .data = &ksz_switch_chips[KSZ9897]