| Message ID | 20220905070240.1634997-1-bhupesh.sharma@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7dac7991408f77b0b33ee5e6b729baa683889277 |
| Headers | show |
| Series | [v2] arm64: dts: qcom: sc8280xp-pmics: Remove reg entry & use correct node name for pmc8280c_lpg node | expand |
On 05/09/2022 09:02, Bhupesh Sharma wrote: > Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") > dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover > 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same. > > While at it, also remove the unused unit address in the node > label. > > Also, since dt-bindings expect LPG/PWM node name to be "pwm", > use correct node name as well, to fix the following > error reported by 'make dtbs_check': > > 'lpg' does not match any of the regexes > > Fixes: eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Cc: Bjorn Andersson <andersson@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20220903084440.1509562-1-bhupesh.sharma@linaro.org/ > - Fixed the review comments shared by Krzysztof. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 05/09/2022 08:02, Bhupesh Sharma wrote: > Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") > dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover > 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same. > > While at it, also remove the unused unit address in the node > label. > > Also, since dt-bindings expect LPG/PWM node name to be "pwm", > use correct node name as well, to fix the following > error reported by 'make dtbs_check': > > 'lpg' does not match any of the regexes > > Fixes: eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Cc: Bjorn Andersson <andersson@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20220903084440.1509562-1-bhupesh.sharma@linaro.org/ > - Fixed the review comments shared by Krzysztof. > > > arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > index ae90b97aecb8..24836b6b9bbc 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > @@ -60,9 +60,8 @@ pmc8280c_gpios: gpio@8800 { > #interrupt-cells = <2>; > }; > > - pmc8280c_lpg: lpg@e800 { > + pmc8280c_lpg: pwm { > compatible = "qcom,pm8350c-pwm"; > - reg = <0xe800>; > > #address-cells = <1>; > #size-cells = <0>; Eh well I didn't drop the reg from this node because it was named lpg not pwm ;) Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On Mon, 5 Sep 2022 12:32:40 +0530, Bhupesh Sharma wrote: > Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") > dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover > 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same. > > While at it, also remove the unused unit address in the node > label. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sc8280xp-pmics: Remove reg entry & use correct node name for pmc8280c_lpg node commit: 7dac7991408f77b0b33ee5e6b729baa683889277 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi index ae90b97aecb8..24836b6b9bbc 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi @@ -60,9 +60,8 @@ pmc8280c_gpios: gpio@8800 { #interrupt-cells = <2>; }; - pmc8280c_lpg: lpg@e800 { + pmc8280c_lpg: pwm { compatible = "qcom,pm8350c-pwm"; - reg = <0xe800>; #address-cells = <1>; #size-cells = <0>;
Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same. While at it, also remove the unused unit address in the node label. Also, since dt-bindings expect LPG/PWM node name to be "pwm", use correct node name as well, to fix the following error reported by 'make dtbs_check': 'lpg' does not match any of the regexes Fixes: eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Cc: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20220903084440.1509562-1-bhupesh.sharma@linaro.org/ - Fixed the review comments shared by Krzysztof. arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)