diff mbox series

[v4,12/21] dt-bindings: hwmon: (mr75203) add "moortec,vm-active-channels" property

Message ID 20220906083356.21067-13-farbere@amazon.com (mailing list archive)
State Superseded
Headers show
Series Variety of fixes and new features for mr75203 driver | expand

Commit Message

Eliav Farber Sept. 6, 2022, 8:33 a.m. UTC
Add optional "moortec,vm-active-channels" property to define the number
of active channels per VM.

This shall be useful to avoid exposing sysfs for reading inputs that are
not connected to any voltage source.

Signed-off-by: Eliav Farber <farbere@amazon.com>
---
V4 -> V3:
- Fix DT checker errors.

V3 -> V2:
- Add "moortec" prefix to property name.
- Add explanation why this change is needed.

 .../devicetree/bindings/hwmon/moortec,mr75203.yaml     | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Guenter Roeck Sept. 6, 2022, 5:08 p.m. UTC | #1
On Tue, Sep 06, 2022 at 08:33:47AM +0000, Eliav Farber wrote:
> Add optional "moortec,vm-active-channels" property to define the number
> of active channels per VM.
> 
> This shall be useful to avoid exposing sysfs for reading inputs that are
> not connected to any voltage source.
> 
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> V4 -> V3:
> - Fix DT checker errors.
> 
> V3 -> V2:
> - Add "moortec" prefix to property name.
> - Add explanation why this change is needed.
> 
>  .../devicetree/bindings/hwmon/moortec,mr75203.yaml     | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index 9454576ebb73..2aa4c3618596 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -70,6 +70,15 @@ properties:
>    "#thermal-sensor-cells":
>      const: 1
>  
> +  moortec,vm-active-channels:
> +    description:
> +      Defines the number of channels per VM that are actually used and are
> +      connected to some input source.
> +      Maximum number of items - number of VMs.
> +      Maximum value of each item - number of channels.
> +      Minimum value of each item - 0 (which means entire VM sensor is nou used).

s/nou/not/

> +    $ref: /schemas/types.yaml#/definitions/uint8-array
> +
>  required:
>    - compatible
>    - reg
> @@ -91,5 +100,6 @@ examples:
>          intel,vm-map = [03 01 04 ff ff];
>          clocks = <&osc0>;
>          resets = <&rcu0 0x40 7>;
> +        moortec,vm-active-channels = /bits/ 8 <0x10 0x05>;
>          #thermal-sensor-cells = <1>;
>      };
Eliav Farber Sept. 7, 2022, 5:21 a.m. UTC | #2
On 9/6/2022 8:08 PM, Guenter Roeck wrote:
> On Tue, Sep 06, 2022 at 08:33:47AM +0000, Eliav Farber wrote:
>> Add optional "moortec,vm-active-channels" property to define the number
>> of active channels per VM.
>>
>> This shall be useful to avoid exposing sysfs for reading inputs that are
>> not connected to any voltage source.
>>
>> Signed-off-by: Eliav Farber <farbere@amazon.com>
>> ---
>> V4 -> V3:
>> - Fix DT checker errors.
>>
>> V3 -> V2:
>> - Add "moortec" prefix to property name.
>> - Add explanation why this change is needed.
>>
>>  .../devicetree/bindings/hwmon/moortec,mr75203.yaml     | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml 
>> b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>> index 9454576ebb73..2aa4c3618596 100644
>> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>> @@ -70,6 +70,15 @@ properties:
>>    "#thermal-sensor-cells":
>>      const: 1
>>
>> +  moortec,vm-active-channels:
>> +    description:
>> +      Defines the number of channels per VM that are actually used 
>> and are
>> +      connected to some input source.
>> +      Maximum number of items - number of VMs.
>> +      Maximum value of each item - number of channels.
>> +      Minimum value of each item - 0 (which means entire VM sensor 
>> is nou used).
>
> s/nou/not/


Typo fixed in v5.

--
Thanks, Eliav
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
index 9454576ebb73..2aa4c3618596 100644
--- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
+++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
@@ -70,6 +70,15 @@  properties:
   "#thermal-sensor-cells":
     const: 1
 
+  moortec,vm-active-channels:
+    description:
+      Defines the number of channels per VM that are actually used and are
+      connected to some input source.
+      Maximum number of items - number of VMs.
+      Maximum value of each item - number of channels.
+      Minimum value of each item - 0 (which means entire VM sensor is nou used).
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+
 required:
   - compatible
   - reg
@@ -91,5 +100,6 @@  examples:
         intel,vm-map = [03 01 04 ff ff];
         clocks = <&osc0>;
         resets = <&rcu0 0x40 7>;
+        moortec,vm-active-channels = /bits/ 8 <0x10 0x05>;
         #thermal-sensor-cells = <1>;
     };