| Message ID | 20220823150643.427737-1-akrowiak@linux.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | s390/vfio-ap: fix two problems discovered in the vfio_ap driver | expand |
These two patches fix a couple of bugs in the vfio_ap driver code, it would be nice to get some r-b action so we can merge these fixes ASAP. Thanks. On 8/23/22 11:06 AM, Tony Krowiak wrote: > Two problems have been discovered with the vfio_ap device driver since the > hot plug support was recently introduced: > > 1. Attempting to remove a matrix mdev after assigning a duplicate adapter > or duplicate domain results in a hang. > > 2. The queues associated with an adapter or domain being unassigned from > the matrix mdev do not get unlinked from it. > > Two patches are provided to resolve these problems. > > Change log v2 => v3: > -------------------- > * Replaced the wrong commit IDs in the 'Fixes' tags in both patches. > (Halil and Alexander) > > * Changed the subject line and description of patch 01/02 to better reflect the > code changes in the patch. (Halil) > > Tony Krowiak (2): > s390/vfio-ap: bypass unnecessary processing of AP resources > s390/vfio-ap: fix unlinking of queues from the mdev > > drivers/s390/crypto/vfio_ap_ops.c | 36 +++++++++++++++++++++++++++---- > 1 file changed, 32 insertions(+), 4 deletions(-) >
PING! On 8/23/22 11:06 AM, Tony Krowiak wrote: > Two problems have been discovered with the vfio_ap device driver since the > hot plug support was recently introduced: > > 1. Attempting to remove a matrix mdev after assigning a duplicate adapter > or duplicate domain results in a hang. > > 2. The queues associated with an adapter or domain being unassigned from > the matrix mdev do not get unlinked from it. > > Two patches are provided to resolve these problems. > > Change log v2 => v3: > -------------------- > * Replaced the wrong commit IDs in the 'Fixes' tags in both patches. > (Halil and Alexander) > > * Changed the subject line and description of patch 01/02 to better reflect the > code changes in the patch. (Halil) > > Tony Krowiak (2): > s390/vfio-ap: bypass unnecessary processing of AP resources > s390/vfio-ap: fix unlinking of queues from the mdev > > drivers/s390/crypto/vfio_ap_ops.c | 36 +++++++++++++++++++++++++++---- > 1 file changed, 32 insertions(+), 4 deletions(-) >
PING? On 8/23/22 11:06 AM, Tony Krowiak wrote: > Two problems have been discovered with the vfio_ap device driver since the > hot plug support was recently introduced: > > 1. Attempting to remove a matrix mdev after assigning a duplicate adapter > or duplicate domain results in a hang. > > 2. The queues associated with an adapter or domain being unassigned from > the matrix mdev do not get unlinked from it. > > Two patches are provided to resolve these problems. > > Change log v2 => v3: > -------------------- > * Replaced the wrong commit IDs in the 'Fixes' tags in both patches. > (Halil and Alexander) > > * Changed the subject line and description of patch 01/02 to better reflect the > code changes in the patch. (Halil) > > Tony Krowiak (2): > s390/vfio-ap: bypass unnecessary processing of AP resources > s390/vfio-ap: fix unlinking of queues from the mdev > > drivers/s390/crypto/vfio_ap_ops.c | 36 +++++++++++++++++++++++++++---- > 1 file changed, 32 insertions(+), 4 deletions(-) >
On Tue, 6 Sep 2022 19:17:50 -0400
Anthony Krowiak <akrowiak@linux.ibm.com> wrote:
> PING?
I'm looking at the series. Expect results soon :D
These are pretty simple, straight forward patches that fix a couple of issues recently introduced in the vfio_ap device driver. I would greatly appreciate it if someone could review these so we can get the fixes into the kernel. Thank you in advance for your attention to this. On 8/23/22 11:06 AM, Tony Krowiak wrote: > Two problems have been discovered with the vfio_ap device driver since the > hot plug support was recently introduced: > > 1. Attempting to remove a matrix mdev after assigning a duplicate adapter > or duplicate domain results in a hang. > > 2. The queues associated with an adapter or domain being unassigned from > the matrix mdev do not get unlinked from it. > > Two patches are provided to resolve these problems. > > Change log v2 => v3: > -------------------- > * Replaced the wrong commit IDs in the 'Fixes' tags in both patches. > (Halil and Alexander) > > * Changed the subject line and description of patch 01/02 to better reflect the > code changes in the patch. (Halil) > > Tony Krowiak (2): > s390/vfio-ap: bypass unnecessary processing of AP resources > s390/vfio-ap: fix unlinking of queues from the mdev > > drivers/s390/crypto/vfio_ap_ops.c | 36 +++++++++++++++++++++++++++---- > 1 file changed, 32 insertions(+), 4 deletions(-) >