| Message ID | 20220902060426.2980951-2-jay.xu@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | gpio clock-names | expand |
On Fri, Sep 2, 2022 at 1:04 AM Jianqun Xu <jay.xu@rock-chips.com> wrote: > > Add 'clock-names' to the gpio dt node. so the driver could get clocks by > a const char id, this patch names the clock-names as > - 'bus': the apb clock for cpu to access the gpio controller > - 'db': the debounce clock for cpu to set debounce clock rate > > Since the old dt nodes may have no clock-names, this patch not make them > as part of 'required properties'. > > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> > --- > .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) Can Rockchip please address DT binding header licensing: https://lore.kernel.org/all/20220630220409.GA3396626-robh@kernel.org/ https://lore.kernel.org/all/20220902210141.GA403234-robh@kernel.org/
On 02/09/2022 08:04, Jianqun Xu wrote: > Add 'clock-names' to the gpio dt node. so the driver could get clocks by > a const char id, this patch names the clock-names as > - 'bus': the apb clock for cpu to access the gpio controller > - 'db': the debounce clock for cpu to set debounce clock rate > > Since the old dt nodes may have no clock-names, this patch not make them > as part of 'required properties'. > > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Am Freitag, 2. September 2022, 08:04:25 CEST schrieb Jianqun Xu: > Add 'clock-names' to the gpio dt node. so the driver could get clocks by > a const char id, this patch names the clock-names as > - 'bus': the apb clock for cpu to access the gpio controller > - 'db': the debounce clock for cpu to set debounce clock rate > > Since the old dt nodes may have no clock-names, this patch not make them > as part of 'required properties'. > > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> Acked-by: Heiko Stuebner <heiko@sntech.de> > --- > .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > index affd823c881d..d43d4c71bebf 100644 > --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > @@ -27,6 +27,12 @@ properties: > - description: APB interface clock source > - description: GPIO debounce reference clock source > > + clock-names: > + minItems: 1 > + items: > + - const: bus > + - const: db > + > gpio-ranges: true > > gpio-controller: true >
diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml index affd823c881d..d43d4c71bebf 100644 --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml @@ -27,6 +27,12 @@ properties: - description: APB interface clock source - description: GPIO debounce reference clock source + clock-names: + minItems: 1 + items: + - const: bus + - const: db + gpio-ranges: true gpio-controller: true
Add 'clock-names' to the gpio dt node. so the driver could get clocks by a const char id, this patch names the clock-names as - 'bus': the apb clock for cpu to access the gpio controller - 'db': the debounce clock for cpu to set debounce clock rate Since the old dt nodes may have no clock-names, this patch not make them as part of 'required properties'. Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 6 ++++++ 1 file changed, 6 insertions(+)