diff mbox series

[v2] mm/page_owner.c: remove redudant drain_all_pages

Message ID 1662633204-10044-1-git-send-email-quic_zhenhuah@quicinc.com (mailing list archive)
State New
Headers show
Series [v2] mm/page_owner.c: remove redudant drain_all_pages | expand

Commit Message

Zhenhua Huang Sept. 8, 2022, 10:33 a.m. UTC 
Remove an expensive and unnecessary operation as PCP pages are safely
skipped when reading page owner. PCP pages can be skipped because
PAGE_EXT_OWNER_ALLOCATED is cleared.

With draining PCP pages, these pages are moved to buddy list so they
can be identified as buddy pages and skipped quickly. Although it improved
efficiency of PFN walker, the drain is guaranteed expensive that is
unlikely to be offset by a slight increase in efficiency when skipping
free pages.

PAGE_EXT_OWNER_ALLOCATED is cleared in the page owner reset path below:
	free_unref_page
		-> free_unref_page_prepare
			-> free_pcp_prepare
				-> free_pages_prepare which do page owner
				reset
		-> free_unref_page_commit which add pages into pcp list

Acked-by: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
---
 mm/page_owner.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Mel Gorman Sept. 8, 2022, 2:55 p.m. UTC | #1 
On Thu, Sep 08, 2022 at 06:33:24PM +0800, Zhenhua Huang wrote:
> Remove an expensive and unnecessary operation as PCP pages are safely
> skipped when reading page owner. PCP pages can be skipped because
> PAGE_EXT_OWNER_ALLOCATED is cleared.
> 
> With draining PCP pages, these pages are moved to buddy list so they
> can be identified as buddy pages and skipped quickly. Although it improved
> efficiency of PFN walker, the drain is guaranteed expensive that is
> unlikely to be offset by a slight increase in efficiency when skipping
> free pages.
> 
> PAGE_EXT_OWNER_ALLOCATED is cleared in the page owner reset path below:
> 	free_unref_page
> 		-> free_unref_page_prepare
> 			-> free_pcp_prepare
> 				-> free_pages_prepare which do page owner
> 				reset
> 		-> free_unref_page_commit which add pages into pcp list
> 
> Acked-by: Mel Gorman <mgorman@techsingularity.net>
> Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>

Should be;

Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>

Otherwise looks good!
Zhenhua Huang Sept. 9, 2022, 6:18 a.m. UTC | #2 
On 2022/9/8 22:55, Mel Gorman wrote:
> On Thu, Sep 08, 2022 at 06:33:24PM +0800, Zhenhua Huang wrote:
>> Remove an expensive and unnecessary operation as PCP pages are safely
>> skipped when reading page owner. PCP pages can be skipped because
>> PAGE_EXT_OWNER_ALLOCATED is cleared.
>>
>> With draining PCP pages, these pages are moved to buddy list so they
>> can be identified as buddy pages and skipped quickly. Although it improved
>> efficiency of PFN walker, the drain is guaranteed expensive that is
>> unlikely to be offset by a slight increase in efficiency when skipping
>> free pages.
>>
>> PAGE_EXT_OWNER_ALLOCATED is cleared in the page owner reset path below:
>> 	free_unref_page
>> 		-> free_unref_page_prepare
>> 			-> free_pcp_prepare
>> 				-> free_pages_prepare which do page owner
>> 				reset
>> 		-> free_unref_page_commit which add pages into pcp list
>>
>> Acked-by: Mel Gorman <mgorman@techsingularity.net>
>> Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
> 
> Should be;
> 
> Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
> Acked-by: Mel Gorman <mgorman@techsingularity.net>
> 
> Otherwise looks good!

Thanks Mel for your guide.
Will update.

>
diff mbox series

Patch

diff --git a/mm/page_owner.c b/mm/page_owner.c
index 90023f9..54f3e03 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -524,8 +524,6 @@  read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos)
 	while (!pfn_valid(pfn) && (pfn & (MAX_ORDER_NR_PAGES - 1)) != 0)
 		pfn++;
 
-	drain_all_pages(NULL);
-
 	/* Find an allocated page */
 	for (; pfn < max_pfn; pfn++) {
 		/*