| Message ID | 5355709e0744680d792d1e57e43441cb0b7b7611.1662714607.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1bd81d785dfc6b8d2e4911acc527c181a88a51d0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: net: renesas,etheravb: R-Car Gen4 updates | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 09/09/2022 11:13, Geert Uytterhoeven wrote: > Despite the name, R-Car V3U is the first member of the R-Car Gen4 > family. Hence move its compatible value to the R-Car Gen4 section. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml > index acf347f3cdbe2284..cd5998e08e2195be 100644 > --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml > +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml > @@ -40,9 +40,13 @@ properties: > - renesas,etheravb-r8a77980 # R-Car V3H > - renesas,etheravb-r8a77990 # R-Car E3 > - renesas,etheravb-r8a77995 # R-Car D3 > - - renesas,etheravb-r8a779a0 # R-Car V3U > - const: renesas,etheravb-rcar-gen3 # R-Car Gen3 and RZ/G2 > > + - items: > + - enum: > + - renesas,etheravb-r8a779a0 # R-Car V3U > + - const: renesas,etheravb-rcar-gen4 # R-Car Gen4 > + Don't you need changes in allOf:if:then section? Best regards, Krzysztof
Hi Krzysztof, On Fri, Sep 9, 2022 at 11:24 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 09/09/2022 11:13, Geert Uytterhoeven wrote: > > Despite the name, R-Car V3U is the first member of the R-Car Gen4 > > family. Hence move its compatible value to the R-Car Gen4 section. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml > > +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml > > @@ -40,9 +40,13 @@ properties: > > - renesas,etheravb-r8a77980 # R-Car V3H > > - renesas,etheravb-r8a77990 # R-Car E3 > > - renesas,etheravb-r8a77995 # R-Car D3 > > - - renesas,etheravb-r8a779a0 # R-Car V3U > > - const: renesas,etheravb-rcar-gen3 # R-Car Gen3 and RZ/G2 > > > > + - items: > > + - enum: > > + - renesas,etheravb-r8a779a0 # R-Car V3U > > + - const: renesas,etheravb-rcar-gen4 # R-Car Gen4 > > + > > Don't you need changes in allOf:if:then section? No, as there is no logic involving renesas,etheravb-rcar-gen3. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 09/09/2022 11:13, Geert Uytterhoeven wrote: > Despite the name, R-Car V3U is the first member of the R-Car Gen4 > family. Hence move its compatible value to the R-Car Gen4 section. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 6 +++++- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Sep 09, 2022 at 11:13:22AM +0200, Geert Uytterhoeven wrote: > Despite the name, R-Car V3U is the first member of the R-Car Gen4 > family. Hence move its compatible value to the R-Car Gen4 section. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Hello! On 9/9/22 12:13 PM, Geert Uytterhoeven wrote: > Despite the name, R-Car V3U is the first member of the R-Car Gen4 > family. Hence move its compatible value to the R-Car Gen4 section. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml index acf347f3cdbe2284..cd5998e08e2195be 100644 --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml @@ -40,9 +40,13 @@ properties: - renesas,etheravb-r8a77980 # R-Car V3H - renesas,etheravb-r8a77990 # R-Car E3 - renesas,etheravb-r8a77995 # R-Car D3 - - renesas,etheravb-r8a779a0 # R-Car V3U - const: renesas,etheravb-rcar-gen3 # R-Car Gen3 and RZ/G2 + - items: + - enum: + - renesas,etheravb-r8a779a0 # R-Car V3U + - const: renesas,etheravb-rcar-gen4 # R-Car Gen4 + - items: - enum: - renesas,etheravb-r9a09g011 # RZ/V2M
Despite the name, R-Car V3U is the first member of the R-Car Gen4 family. Hence move its compatible value to the R-Car Gen4 section. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)