| Message ID | 20220909092451.24883-17-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | A few cleanup patches for mm | expand |
On 09.09.22 11:24, Miaohe Lin wrote: > There are no architectures that can have holes in the memory map within > a pageblock since commit 859a85ddf90e ("mm: remove pfn_valid_within() > and CONFIG_HOLES_IN_ZONE"). Update the corresponding comment. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > --- > mm/page_alloc.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 262e8972e019..4cc0232020d2 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1929,11 +1929,7 @@ static inline void __init pgdat_init_report_one_done(void) > /* > * Returns true if page needs to be initialized or freed to buddy allocator. > * > - * First we check if pfn is valid on architectures where it is possible to have > - * holes within pageblock_nr_pages. On systems where it is not possible, this > - * function is optimized out. > - * > - * Then, we check if a current large page is valid by only checking the validity > + * We check if a current large page is valid by only checking the validity > * of the head pfn. > */ > static inline bool __init deferred_pfn_valid(unsigned long pfn) Reviewed-by: David Hildenbrand <david@redhat.com>
On 9/9/22 14:54, Miaohe Lin wrote: > There are no architectures that can have holes in the memory map within > a pageblock since commit 859a85ddf90e ("mm: remove pfn_valid_within() > and CONFIG_HOLES_IN_ZONE"). Update the corresponding comment. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> > --- > mm/page_alloc.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 262e8972e019..4cc0232020d2 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1929,11 +1929,7 @@ static inline void __init pgdat_init_report_one_done(void) > /* > * Returns true if page needs to be initialized or freed to buddy allocator. > * > - * First we check if pfn is valid on architectures where it is possible to have > - * holes within pageblock_nr_pages. On systems where it is not possible, this > - * function is optimized out. > - * > - * Then, we check if a current large page is valid by only checking the validity > + * We check if a current large page is valid by only checking the validity > * of the head pfn. > */ > static inline bool __init deferred_pfn_valid(unsigned long pfn)
On Fri, Sep 09, 2022 at 05:24:51PM +0800, Miaohe Lin wrote: > There are no architectures that can have holes in the memory map within > a pageblock since commit 859a85ddf90e ("mm: remove pfn_valid_within() > and CONFIG_HOLES_IN_ZONE"). Update the corresponding comment. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Oscar Salvador <osalvador@suse.de> > --- > mm/page_alloc.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 262e8972e019..4cc0232020d2 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1929,11 +1929,7 @@ static inline void __init pgdat_init_report_one_done(void) > /* > * Returns true if page needs to be initialized or freed to buddy allocator. > * > - * First we check if pfn is valid on architectures where it is possible to have > - * holes within pageblock_nr_pages. On systems where it is not possible, this > - * function is optimized out. > - * > - * Then, we check if a current large page is valid by only checking the validity > + * We check if a current large page is valid by only checking the validity > * of the head pfn. > */ > static inline bool __init deferred_pfn_valid(unsigned long pfn) > -- > 2.23.0 >
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 262e8972e019..4cc0232020d2 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1929,11 +1929,7 @@ static inline void __init pgdat_init_report_one_done(void) /* * Returns true if page needs to be initialized or freed to buddy allocator. * - * First we check if pfn is valid on architectures where it is possible to have - * holes within pageblock_nr_pages. On systems where it is not possible, this - * function is optimized out. - * - * Then, we check if a current large page is valid by only checking the validity + * We check if a current large page is valid by only checking the validity * of the head pfn. */ static inline bool __init deferred_pfn_valid(unsigned long pfn)
There are no architectures that can have holes in the memory map within a pageblock since commit 859a85ddf90e ("mm: remove pfn_valid_within() and CONFIG_HOLES_IN_ZONE"). Update the corresponding comment. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/page_alloc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)