| Message ID | 20220827021623.23829-1-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | power: supply: Add Support for RK817 Charger | expand |
On Fri, 26 Aug 2022 21:16:19 -0500, Chris Morgan wrote: > This series is to add support for the Rockchip rk817 battery charger > which is present in all Rockchip RK817 PMICs. The driver was written > as a joint effort by Maya Matuszczyk <maccraft123mc@gmail.com> and > myself Chris Morgan <macromorgan@hotmail.com>. > > The driver requires some basic parameters be described about the > battery in the devicetree such as the maximum capacity, the minimum > and maximum voltage for the battery, the maximum charge current, the > maximum charge voltage, and the value of sample resistors and sleep > currents. > > [...] Applied, thanks! [4/4] arm64: dts: rockchip: add rk817 chg to Odroid Go Advance commit: a5d5e515ed89709de8ad2537cd9d611b95e1928b With the binding having gotten applied, this could go in. It just leaves the charger-driver to be handled. Best regards,
On 09/09/2022 19:33, Heiko Stuebner wrote: > On Fri, 26 Aug 2022 21:16:19 -0500, Chris Morgan wrote: >> This series is to add support for the Rockchip rk817 battery charger >> which is present in all Rockchip RK817 PMICs. The driver was written >> as a joint effort by Maya Matuszczyk <maccraft123mc@gmail.com> and >> myself Chris Morgan <macromorgan@hotmail.com>. >> >> The driver requires some basic parameters be described about the >> battery in the devicetree such as the maximum capacity, the minimum >> and maximum voltage for the battery, the maximum charge current, the >> maximum charge voltage, and the value of sample resistors and sleep >> currents. >> >> [...] > > Applied, thanks! > > [4/4] arm64: dts: rockchip: add rk817 chg to Odroid Go Advance > commit: a5d5e515ed89709de8ad2537cd9d611b95e1928b > > With the binding having gotten applied, this could go in. > It just leaves the charger-driver to be handled. > > > Best regards, I tried this on my Quartz64-a. Once I added information about the battery into the dts file it seemed to work very well. I'm not sure about informing all of those other email addresses as I'm not familiar with the processes going on here. regards, Philip
From: Chris Morgan <macromorgan@hotmail.com> This series is to add support for the Rockchip rk817 battery charger which is present in all Rockchip RK817 PMICs. The driver was written as a joint effort by Maya Matuszczyk <maccraft123mc@gmail.com> and myself Chris Morgan <macromorgan@hotmail.com>. The driver requires some basic parameters be described about the battery in the devicetree such as the maximum capacity, the minimum and maximum voltage for the battery, the maximum charge current, the maximum charge voltage, and the value of sample resistors and sleep currents. The hardware itself contains an ADC capable of measuring the voltage, current, and temperature of the battery (though my implementation of an Odroid Go Advance lacks a thermistor for temperature). It also contains a columb counter, registers for tracking the measured voltage and current at boot, and a few bytes of nvram for storing data. Changes from V9: - Corrected devicetree documentation to note that there are no additional properties for the charger than what is listed. - Fixed error handling on invalid parameters from the monitored battery node. Previously was checking for non zero values which could miss some error conditions. Now check for values equal to or less than zero. - After investigating an issue first identified by Philip Christian <philip@pscan.uk> I changed the behavior for storing the rsoc value to nvram. It actually looks like the BSP kernel and U-Boot stores the remaining charge in mAh, not remaining capacity. I also added additional sanity checking on reading nvram values before they are used to prevent further issues. Changes from V8: - Updated copyright notice. - Replaced linux/of_gpio.h header with of.h. - Changed to use devm_delayed_work_autocancel to manage work queue. Changes from V7: - Fix error reported by kernel test robot <lkp@intel.com> in patch v7. Problem appeared to be related to incomplete removal of fields I used previously in debugging. Changes from V6: - Updated devicetree binding patch to reference the required prerequisite patch in the correct manner (relocated it below the --- and pointed it to lore.kernel.org). Changes from V5: - Renamed mfd-cell from "battery" to "charger". - Added note for devicetree binding documentation that it requires application of an additional pending patch (to convert documentation to yaml). Changes from V4: - Massively redesigned the battery driver to improve measurement accuracy and reliability. Driver now checks values every 8 seconds (mimicking BSP driver behavior), or whenever a plug event is detected. - Removed OCV, boot voltage, and boot current as values were found to be unreliable. - Updated first-boot behavior to perform a "best guess" at capacity. - Added ability to calibrate columb counter to full state of charge when charger reports full, and added ability calibrate full charge capacity when battery discharges from full charge to minimum voltage. - Expose state of charge as capacity (in percents). - Updated storing of values to nvram to preserve compatibility with BSP kernel. Changes from V3: - Corrected issues in device tree documentation. - Added additional logic to battery to correct for columb counter drift when the device stays plugged in at a full charge state. Changes from V2: - Updated devicetree bindings to use common property units. - Removed unneeded includes. - Updated rk817_chg_cur_to_reg to make more legible. - Simplified formula for displaying calibrated voltage. - Updated power supply type to POWER_SUPPLY_TYPE_USB. - Implemented get/put_unaligned macros for bulk reads and writes. - Changed numerous dev_err() to dev_err_probe(). - Call power_supply_put_battery_info() at end of probe function. - Removed unneeded whitespace. Changes from V1: - Fixed a CLANG warning regarding an uninitalized variable. - Fixed a CLANG warning regarding a pointer as a bool value always returning as true. - Added Maya Matuszczyk to the Signed-off-by. Chris Morgan (4): dt-bindings: Add Rockchip rk817 battery charger support mfd: Add Rockchip rk817 battery charger support power: supply: Add charger driver for Rockchip RK817 arm64: dts: rockchip: add rk817 chg to Odroid Go Advance .../bindings/mfd/rockchip,rk817.yaml | 50 + .../boot/dts/rockchip/rk3326-odroid-go2.dts | 26 + drivers/mfd/rk808.c | 16 +- drivers/power/supply/Kconfig | 6 + drivers/power/supply/Makefile | 1 + drivers/power/supply/rk817_charger.c | 1211 +++++++++++++++++ include/linux/mfd/rk808.h | 91 ++ 7 files changed, 1400 insertions(+), 1 deletion(-) create mode 100644 drivers/power/supply/rk817_charger.c