| Message ID | 20220719022743.305189-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | power: supply: ab8500: remove unused static local variable | expand |
On Tue, Jul 19, 2022 at 4:27 AM Tom Rix <trix@redhat.com> wrote: > cpp_check reports > [drivers/power/supply/ab8500_chargalg.c:493]: (style) Variable 'ab8500_chargalg_ex_ac_enable_toggle' is assigned a value that is never used. > > From inspection, this variable is never used. So remove it. > > Fixes: 6c50a08d9dd3 ("power: supply: ab8500: Drop external charger leftovers") > Signed-off-by: Tom Rix <trix@redhat.com> Thanks Tom! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
>> cpp_check reports >> [drivers/power/supply/ab8500_chargalg.c:493]: (style) Variable 'ab8500_chargalg_ex_ac_enable_toggle' is assigned a value that is never used. >> >> From inspection, this variable is never used. So remove it. >> >> Fixes: 6c50a08d9dd3 ("power: supply: ab8500: Drop external charger leftovers") >> Signed-off-by: Tom Rix <trix@redhat.com> > >Thanks Tom! >Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > >Yours, >Linus Walleij Hi Sebastian, It looks like that this patch is not in linux-next 20220812 and I can still observe this build error with ARCH=arm, defconfig=allyesconfig. Would you pick up this fix, please? Thanks, Miles
在 2022/7/19 10:27, Tom Rix 写道: > cpp_check reports > [drivers/power/supply/ab8500_chargalg.c:493]: (style) Variable 'ab8500_chargalg_ex_ac_enable_toggle' is assigned a value that is never used. > >>From inspection, this variable is never used. So remove it. > > Fixes: 6c50a08d9dd3 ("power: supply: ab8500: Drop external charger leftovers") > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/power/supply/ab8500_chargalg.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/power/supply/ab8500_chargalg.c b/drivers/power/supply/ab8500_chargalg.c > index ae4be553f424..05146d436a6a 100644 > --- a/drivers/power/supply/ab8500_chargalg.c > +++ b/drivers/power/supply/ab8500_chargalg.c > @@ -490,8 +490,6 @@ static int ab8500_chargalg_kick_watchdog(struct ab8500_chargalg *di) > static int ab8500_chargalg_ac_en(struct ab8500_chargalg *di, int enable, > int vset_uv, int iset_ua) > { > - static int ab8500_chargalg_ex_ac_enable_toggle; > - > if (!di->ac_chg || !di->ac_chg->ops.enable) > return -ENXIO; > > Reviewed-by: Chen Lifu <chenlifu@huawei.com> I can still observe this build error with ARCH=arm, defconfig=allyesconfig in linux-next next-200816: drivers/power/supply/ab8500_chargalg.c: In function ‘ab8500_chargalg_ac_en’: drivers/power/supply/ab8500_chargalg.c:493:13: error: unused variable ‘ab8500_chargalg_ex_ac_enable_toggle’ [-Werror=unused-variable] static int ab8500_chargalg_ex_ac_enable_toggle; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
在 2022/8/17 9:57, chenlifu 写道: > 在 2022/7/19 10:27, Tom Rix 写道: >> cpp_check reports >> [drivers/power/supply/ab8500_chargalg.c:493]: (style) Variable >> 'ab8500_chargalg_ex_ac_enable_toggle' is assigned a value that is >> never used. >> >>> From inspection, this variable is never used. So remove it. >> >> Fixes: 6c50a08d9dd3 ("power: supply: ab8500: Drop external charger >> leftovers") >> Signed-off-by: Tom Rix <trix@redhat.com> >> --- >> drivers/power/supply/ab8500_chargalg.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/power/supply/ab8500_chargalg.c >> b/drivers/power/supply/ab8500_chargalg.c >> index ae4be553f424..05146d436a6a 100644 >> --- a/drivers/power/supply/ab8500_chargalg.c >> +++ b/drivers/power/supply/ab8500_chargalg.c >> @@ -490,8 +490,6 @@ static int ab8500_chargalg_kick_watchdog(struct >> ab8500_chargalg *di) >> static int ab8500_chargalg_ac_en(struct ab8500_chargalg *di, int >> enable, >> int vset_uv, int iset_ua) >> { >> - static int ab8500_chargalg_ex_ac_enable_toggle; >> - >> if (!di->ac_chg || !di->ac_chg->ops.enable) >> return -ENXIO; >> > > Reviewed-by: Chen Lifu <chenlifu@huawei.com> > > > I can still observe this build error with ARCH=arm, > defconfig=allyesconfig in linux-next next-200816: > > drivers/power/supply/ab8500_chargalg.c: In function > ‘ab8500_chargalg_ac_en’: > drivers/power/supply/ab8500_chargalg.c:493:13: error: unused variable > ‘ab8500_chargalg_ex_ac_enable_toggle’ [-Werror=unused-variable] > static int ab8500_chargalg_ex_ac_enable_toggle; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > . Reviewed-by: Chen Lifu <chenlifu@huawei.com> fixed the tag: next-200816 --> next-20220816 I can still observe this build error with ARCH=arm, defconfig=allyesconfig in linux-next next-20220816: drivers/power/supply/ab8500_chargalg.c: In function ‘ab8500_chargalg_ac_en’: drivers/power/supply/ab8500_chargalg.c:493:13: error: unused variable ‘ab8500_chargalg_ex_ac_enable_toggle’ [-Werror=unused-variable] static int ab8500_chargalg_ex_ac_enable_toggle; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Hi, On Mon, Jul 18, 2022 at 10:27:43PM -0400, Tom Rix wrote: > cpp_check reports > [drivers/power/supply/ab8500_chargalg.c:493]: (style) Variable 'ab8500_chargalg_ex_ac_enable_toggle' is assigned a value that is never used. > > From inspection, this variable is never used. So remove it. > > Fixes: 6c50a08d9dd3 ("power: supply: ab8500: Drop external charger leftovers") > Signed-off-by: Tom Rix <trix@redhat.com> > --- Thanks, queued into power-supply's fixes branch. Sorry for the delay. -- Sebastian > drivers/power/supply/ab8500_chargalg.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/power/supply/ab8500_chargalg.c b/drivers/power/supply/ab8500_chargalg.c > index ae4be553f424..05146d436a6a 100644 > --- a/drivers/power/supply/ab8500_chargalg.c > +++ b/drivers/power/supply/ab8500_chargalg.c > @@ -490,8 +490,6 @@ static int ab8500_chargalg_kick_watchdog(struct ab8500_chargalg *di) > static int ab8500_chargalg_ac_en(struct ab8500_chargalg *di, int enable, > int vset_uv, int iset_ua) > { > - static int ab8500_chargalg_ex_ac_enable_toggle; > - > if (!di->ac_chg || !di->ac_chg->ops.enable) > return -ENXIO; > > -- > 2.27.0 >
diff --git a/drivers/power/supply/ab8500_chargalg.c b/drivers/power/supply/ab8500_chargalg.c index ae4be553f424..05146d436a6a 100644 --- a/drivers/power/supply/ab8500_chargalg.c +++ b/drivers/power/supply/ab8500_chargalg.c @@ -490,8 +490,6 @@ static int ab8500_chargalg_kick_watchdog(struct ab8500_chargalg *di) static int ab8500_chargalg_ac_en(struct ab8500_chargalg *di, int enable, int vset_uv, int iset_ua) { - static int ab8500_chargalg_ex_ac_enable_toggle; - if (!di->ac_chg || !di->ac_chg->ops.enable) return -ENXIO;
cpp_check reports [drivers/power/supply/ab8500_chargalg.c:493]: (style) Variable 'ab8500_chargalg_ex_ac_enable_toggle' is assigned a value that is never used. From inspection, this variable is never used. So remove it. Fixes: 6c50a08d9dd3 ("power: supply: ab8500: Drop external charger leftovers") Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/power/supply/ab8500_chargalg.c | 2 -- 1 file changed, 2 deletions(-)