| Message ID | 20220909092451.24883-5-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | A few cleanup patches for mm | expand |
On 09.09.22 11:24, Miaohe Lin wrote: > Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs > are disabled for VM counters"), zone_statistics() is not called with > interrupts disabled. Update the corresponding comment. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > --- > mm/page_alloc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2deac2fe3372..c81f06d8a4f5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt) > > /* > * Update NUMA hit/miss statistics > - * > - * Must be called with interrupts disabled. > */ > static inline void zone_statistics(struct zone *preferred_zone, struct zone *z, > long nr_account) Acked-by: David Hildenbrand <david@redhat.com>
On 9/9/22 14:54, Miaohe Lin wrote: > Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs > are disabled for VM counters"), zone_statistics() is not called with > interrupts disabled. Update the corresponding comment. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> > --- > mm/page_alloc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2deac2fe3372..c81f06d8a4f5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt) > > /* > * Update NUMA hit/miss statistics > - * > - * Must be called with interrupts disabled. > */ > static inline void zone_statistics(struct zone *preferred_zone, struct zone *z, > long nr_account)
On Fri, Sep 09, 2022 at 05:24:39PM +0800, Miaohe Lin wrote: > Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs > are disabled for VM counters"), zone_statistics() is not called with > interrupts disabled. Update the corresponding comment. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Oscar Salvador <osalvador@suse.de> > --- > mm/page_alloc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2deac2fe3372..c81f06d8a4f5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt) > > /* > * Update NUMA hit/miss statistics > - * > - * Must be called with interrupts disabled. > */ > static inline void zone_statistics(struct zone *preferred_zone, struct zone *z, > long nr_account) > -- > 2.23.0 >
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 2deac2fe3372..c81f06d8a4f5 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt) /* * Update NUMA hit/miss statistics - * - * Must be called with interrupts disabled. */ static inline void zone_statistics(struct zone *preferred_zone, struct zone *z, long nr_account)
Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs are disabled for VM counters"), zone_statistics() is not called with interrupts disabled. Update the corresponding comment. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/page_alloc.c | 2 -- 1 file changed, 2 deletions(-)