| Message ID | 1663057594-29141-1-git-send-email-shengjiu.wang@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | da995e22fa7193b067f2545e63d726ffe36ba174 |
| Headers | show |
| Series | ASoC: ak4458: Add ak4458_reset in device probe and remove | expand |
On Tue, 13 Sep 2022 16:26:34 +0800, Shengjiu Wang wrote: > This patch fixup this warning when CONFIG_PM not defined > > linux/sound/soc/codecs/ak4458.c:631:13: error: 'ak4458_reset' defined but\ > not used [-Werror=unused-function] > 631 | static void ak4458_reset(struct ak4458_priv *ak4458, bool active) > | ^~~~~~~~~~~~ > cc1: all warnings being treated as errors > > [...] Applied to broonie/sound.git for-next Thanks! [1/1] ASoC: ak4458: Add ak4458_reset in device probe and remove commit: da995e22fa7193b067f2545e63d726ffe36ba174 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index b534212096ee..626310859814 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -781,12 +781,16 @@ static int ak4458_i2c_probe(struct i2c_client *i2c) pm_runtime_enable(&i2c->dev); regcache_cache_only(ak4458->regmap, true); + ak4458_reset(ak4458, false); return 0; } static int ak4458_i2c_remove(struct i2c_client *i2c) { + struct ak4458_priv *ak4458 = i2c_get_clientdata(i2c); + + ak4458_reset(ak4458, true); pm_runtime_disable(&i2c->dev); return 0;
This patch fixup this warning when CONFIG_PM not defined linux/sound/soc/codecs/ak4458.c:631:13: error: 'ak4458_reset' defined but\ not used [-Werror=unused-function] 631 | static void ak4458_reset(struct ak4458_priv *ak4458, bool active) | ^~~~~~~~~~~~ cc1: all warnings being treated as errors Fixes: e9e7df88996d64 ("ASoC: ak4458: Remove component probe() and remove()") Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> --- sound/soc/codecs/ak4458.c | 4 ++++ 1 file changed, 4 insertions(+)