| Message ID | 1663559238-22918-1-git-send-email-zhaoyang.huang@unisoc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: check high-order page when free it to pcp | expand |
current free_pcp_prepare logic should be inherited from the code before 44042b4498, where high order pages only reside in the global list and will be checked during free and alloc. On Mon, Sep 19, 2022 at 11:47 AM zhaoyang.huang <zhaoyang.huang@unisoc.com> wrote: > > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com> > > High-order pcp page escaped from checking when both of DEBUG_VM and debug_pagealloc > are all disabled if it allocated again from pcp_list without going to global > free list, which should be introduced by 44042b4498. > > fix:44042b4498 > > Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com> > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e008a3d..e77f3a7 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1437,7 +1437,7 @@ static bool bulkfree_pcp_prepare(struct page *page) > */ > static bool free_pcp_prepare(struct page *page, unsigned int order) > { > - if (debug_pagealloc_enabled_static()) > + if (debug_pagealloc_enabled_static() || order) > return free_pages_prepare(page, order, true, FPI_NONE); > else > return free_pages_prepare(page, order, false, FPI_NONE); > -- > 1.9.1 >
On Mon, Sep 19, 2022 at 11:47:18AM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com> > > High-order pcp page escaped from checking when both of DEBUG_VM and debug_pagealloc > are all disabled if it allocated again from pcp_list without going to global > free list, which should be introduced by 44042b4498. > > fix:44042b4498 > > Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com> Is this based on the comment mentioning order-0 pages above free_pcp_prepare()? I ask because the comment is wrong and in both instances should have s/order-0//
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e008a3d..e77f3a7 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1437,7 +1437,7 @@ static bool bulkfree_pcp_prepare(struct page *page) */ static bool free_pcp_prepare(struct page *page, unsigned int order) { - if (debug_pagealloc_enabled_static()) + if (debug_pagealloc_enabled_static() || order) return free_pages_prepare(page, order, true, FPI_NONE); else return free_pages_prepare(page, order, false, FPI_NONE);