| Message ID | 20220919022921.946344-4-dmitry.fomichev@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | virtio-blk: support zoned block devices | expand |
Hi Dmitry, On Sun, Sep 18, 2022 at 10:29:21PM -0400, Dmitry Fomichev wrote: > The zone-specific code in the patch is heavily influenced by NVMe ZNS > code in drivers/nvme/host/zns.c, but it is simpler because the proposed > virtio ZBD draft only covers the zoned device features that are > relevant to the zoned functionality provided by Linux block layer. > There is a parallel work going on to support non-po2 zone sizes in Linux block layer and drivers[1]. I don't see any reason why we shouldn't make the calculations generic here instead of putting the constraint on zone sectors to be po2 as the virtio spec also supports it. I took a quick look, and changing the calculations from po2 specific to generic will not be in the hot path and can be trivially changed. I have suggested the changes inline to make the virtio blk driver zone size agnostic. I haven't tested the changes but it is very similar to the changes I did in the drivers/nvme/host/zns.c in my patch series[2]. [1] https://lore.kernel.org/linux-block/20220912082204.51189-1-p.raghav@samsung.com/ [2] https://lore.kernel.org/linux-block/20220912082204.51189-6-p.raghav@samsung.com/ > Co-developed-by: Stefan Hajnoczi <stefanha@gmail.com> > Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com> > Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com> > --- > drivers/block/virtio_blk.c | 381 ++++++++++++++++++++++++++++++-- > include/uapi/linux/virtio_blk.h | 106 +++++++++ > 2 files changed, 469 insertions(+), 18 deletions(-) > <snip> > +#ifdef CONFIG_BLK_DEV_ZONED > +static void *virtblk_alloc_report_buffer(struct virtio_blk *vblk, > + unsigned int nr_zones, > + unsigned int zone_sectors, > + size_t *buflen) > +{ > + struct request_queue *q = vblk->disk->queue; > + size_t bufsize; > + void *buf; > + - nr_zones = min_t(unsigned int, nr_zones, - get_capacity(vblk->disk) >> ilog2(zone_sectors)); + nr_zones = min_t(unsigned int, nr_zones, + div64_u64(get_capacity(vblk->disk), zone_sectors)); > + > + bufsize = sizeof(struct virtio_blk_zone_report) + > + nr_zones * sizeof(struct virtio_blk_zone_descriptor); > + bufsize = min_t(size_t, bufsize, > + queue_max_hw_sectors(q) << SECTOR_SHIFT); > + bufsize = min_t(size_t, bufsize, queue_max_segments(q) << PAGE_SHIFT); > + > + while (bufsize >= sizeof(struct virtio_blk_zone_report)) { > + buf = __vmalloc(bufsize, GFP_KERNEL | __GFP_NORETRY); > + if (buf) { > + *buflen = bufsize; > + return buf; > + } > + bufsize >>= 1; > + } > + > + return NULL; > +} > + > +static int virtblk_submit_zone_report(struct virtio_blk *vblk, > + char *report_buf, size_t report_len, > + sector_t sector) > +{ > + struct request_queue *q = vblk->disk->queue; > + struct request *req; > + struct virtblk_req *vbr; > + int err; > + > + req = blk_mq_alloc_request(q, REQ_OP_DRV_IN, 0); > + if (IS_ERR(req)) > + return PTR_ERR(req); > + > + vbr = blk_mq_rq_to_pdu(req); > + vbr->in_hdr_len = sizeof(vbr->status); > + vbr->out_hdr.type = cpu_to_virtio32(vblk->vdev, VIRTIO_BLK_T_ZONE_REPORT); > + vbr->out_hdr.sector = cpu_to_virtio64(vblk->vdev, sector); > + > + err = blk_rq_map_kern(q, req, report_buf, report_len, GFP_KERNEL); > + if (err) > + goto out; > + > + blk_execute_rq(req, false); > + err = blk_status_to_errno(virtblk_result(vbr->status)); > +out: > + blk_mq_free_request(req); > + return err; > +} > + > +static int virtblk_parse_zone(struct virtio_blk *vblk, > + struct virtio_blk_zone_descriptor *entry, > + unsigned int idx, unsigned int zone_sectors, > + report_zones_cb cb, void *data) > +{ > + struct blk_zone zone = { }; > + > + if (entry->z_type != VIRTIO_BLK_ZT_SWR && > + entry->z_type != VIRTIO_BLK_ZT_SWP && > + entry->z_type != VIRTIO_BLK_ZT_CONV) { > + dev_err(&vblk->vdev->dev, "invalid zone type %#x\n", > + entry->z_type); > + return -EINVAL; > + } > + > + zone.type = entry->z_type; > + zone.cond = entry->z_state; > + zone.len = zone_sectors; > + zone.capacity = le64_to_cpu(entry->z_cap); > + zone.start = le64_to_cpu(entry->z_start); > + if (zone.cond == BLK_ZONE_COND_FULL) > + zone.wp = zone.start + zone.len; > + else > + zone.wp = le64_to_cpu(entry->z_wp); > + > + return cb(&zone, idx, data); > +} > + > +static int virtblk_report_zones(struct gendisk *disk, sector_t sector, > + unsigned int nr_zones, report_zones_cb cb, > + void *data) > +{ > + struct virtio_blk *vblk = disk->private_data; > + struct virtio_blk_zone_report *report; > + unsigned int zone_sectors = vblk->zone_sectors; > + unsigned int nz, i; > + int ret, zone_idx = 0; > + size_t buflen; + u64 remainder; > + > + if (WARN_ON_ONCE(!vblk->zone_sectors)) > + return -EOPNOTSUPP; > + > + report = virtblk_alloc_report_buffer(vblk, nr_zones, > + zone_sectors, &buflen); > + if (!report) > + return -ENOMEM; > + - sector &= ~(zone_sectors - 1); + div64_u64_rem(sector, zone_sectors, &remainder); + sector -= remainder; > + while (zone_idx < nr_zones && sector < get_capacity(vblk->disk)) { > + memset(report, 0, buflen); > + > + ret = virtblk_submit_zone_report(vblk, (char *)report, > + buflen, sector); > + if (ret) { > + if (ret > 0) > + ret = -EIO; > + goto out_free; > + } > + > + nz = min((unsigned int)le64_to_cpu(report->nr_zones), nr_zones); > + if (!nz) > + break; > + > + for (i = 0; i < nz && zone_idx < nr_zones; i++) { > + ret = virtblk_parse_zone(vblk, &report->zones[i], > + zone_idx, zone_sectors, cb, data); > + if (ret) > + goto out_free; > + zone_idx++; > + } > + > + sector += zone_sectors * nz; > + } > + > + if (zone_idx > 0) > + ret = zone_idx; > + else > + ret = -EINVAL; > +out_free: > + kvfree(report); > + return ret; > +} > + <snip> > +static int virtblk_probe_zoned_device(struct virtio_device *vdev, > + struct virtio_blk *vblk, > + struct request_queue *q) > +{ <snip> > + blk_queue_physical_block_size(q, le32_to_cpu(v)); > + blk_queue_io_min(q, le32_to_cpu(v)); > + > + dev_dbg(&vdev->dev, "write granularity = %u\n", le32_to_cpu(v)); > + - /* - * virtio ZBD specification doesn't require zones to be a power of - * two sectors in size, but the code in this driver expects that. - */ - virtio_cread(vdev, struct virtio_blk_config, zoned.zone_sectors, &v); - if (v == 0 || !is_power_of_2(v)) { - dev_err(&vdev->dev, - "zoned device with non power of two zone size %u\n", v); - return -ENODEV; - } > + > + dev_dbg(&vdev->dev, "zone sectors = %u\n", le32_to_cpu(v)); > + vblk->zone_sectors = le32_to_cpu(v); > + > + if (virtio_has_feature(vdev, VIRTIO_BLK_F_DISCARD)) { > + dev_warn(&vblk->vdev->dev, > + "ignoring negotiated F_DISCARD for zoned device\n"); > + blk_queue_max_discard_sectors(q, 0); > + } > + > + ret = blk_revalidate_disk_zones(vblk->disk, NULL); > + if (!ret) { > + virtio_cread(vdev, struct virtio_blk_config, > + zoned.max_append_sectors, &v); > + if (!v) { > + dev_warn(&vdev->dev, "zero max_append_sectors reported\n"); > + return -ENODEV; > + } > + blk_queue_max_zone_append_sectors(q, le32_to_cpu(v)); > + dev_dbg(&vdev->dev, "max append sectors = %u\n", le32_to_cpu(v)); > + > + } > + > + return ret; > +} > +
On 9/19/22 22:41, Pankaj Raghav wrote: > Hi Dmitry, > > On Sun, Sep 18, 2022 at 10:29:21PM -0400, Dmitry Fomichev wrote: >> The zone-specific code in the patch is heavily influenced by NVMe ZNS >> code in drivers/nvme/host/zns.c, but it is simpler because the proposed >> virtio ZBD draft only covers the zoned device features that are >> relevant to the zoned functionality provided by Linux block layer. >> > There is a parallel work going on to support non-po2 zone sizes in Linux > block layer and drivers[1]. I don't see any reason why we shouldn't make > the calculations generic here instead of putting the constraint on zone > sectors to be po2 as the virtio spec also supports it. That series is not upstream, so implementing against would not be the correct approach, especially given that this would also impact qemu code. > > I took a quick look, and changing the calculations from po2 specific to > generic will not be in the hot path and can be trivially changed. I have > suggested the changes inline to make the virtio blk driver zone size > agnostic. I haven't tested the changes but it is very > similar to the changes I did in the drivers/nvme/host/zns.c in my patch > series[2]. > > [1] https://lore.kernel.org/linux-block/20220912082204.51189-1-p.raghav@samsung.com/ > [2] https://lore.kernel.org/linux-block/20220912082204.51189-6-p.raghav@samsung.com/ > >> Co-developed-by: Stefan Hajnoczi <stefanha@gmail.com> >> Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com> >> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com> >> --- >> drivers/block/virtio_blk.c | 381 ++++++++++++++++++++++++++++++-- >> include/uapi/linux/virtio_blk.h | 106 +++++++++ >> 2 files changed, 469 insertions(+), 18 deletions(-) >> > <snip> >> +#ifdef CONFIG_BLK_DEV_ZONED >> +static void *virtblk_alloc_report_buffer(struct virtio_blk *vblk, >> + unsigned int nr_zones, >> + unsigned int zone_sectors, >> + size_t *buflen) >> +{ >> + struct request_queue *q = vblk->disk->queue; >> + size_t bufsize; >> + void *buf; >> + > - nr_zones = min_t(unsigned int, nr_zones, > - get_capacity(vblk->disk) >> ilog2(zone_sectors)); > > + nr_zones = min_t(unsigned int, nr_zones, > + div64_u64(get_capacity(vblk->disk), zone_sectors)); > >> + >> + bufsize = sizeof(struct virtio_blk_zone_report) + >> + nr_zones * sizeof(struct virtio_blk_zone_descriptor); >> + bufsize = min_t(size_t, bufsize, >> + queue_max_hw_sectors(q) << SECTOR_SHIFT); >> + bufsize = min_t(size_t, bufsize, queue_max_segments(q) << PAGE_SHIFT); >> + >> + while (bufsize >= sizeof(struct virtio_blk_zone_report)) { >> + buf = __vmalloc(bufsize, GFP_KERNEL | __GFP_NORETRY); >> + if (buf) { >> + *buflen = bufsize; >> + return buf; >> + } >> + bufsize >>= 1; >> + } >> + >> + return NULL; >> +} >> + >> +static int virtblk_submit_zone_report(struct virtio_blk *vblk, >> + char *report_buf, size_t report_len, >> + sector_t sector) >> +{ >> + struct request_queue *q = vblk->disk->queue; >> + struct request *req; >> + struct virtblk_req *vbr; >> + int err; >> + >> + req = blk_mq_alloc_request(q, REQ_OP_DRV_IN, 0); >> + if (IS_ERR(req)) >> + return PTR_ERR(req); >> + >> + vbr = blk_mq_rq_to_pdu(req); >> + vbr->in_hdr_len = sizeof(vbr->status); >> + vbr->out_hdr.type = cpu_to_virtio32(vblk->vdev, VIRTIO_BLK_T_ZONE_REPORT); >> + vbr->out_hdr.sector = cpu_to_virtio64(vblk->vdev, sector); >> + >> + err = blk_rq_map_kern(q, req, report_buf, report_len, GFP_KERNEL); >> + if (err) >> + goto out; >> + >> + blk_execute_rq(req, false); >> + err = blk_status_to_errno(virtblk_result(vbr->status)); >> +out: >> + blk_mq_free_request(req); >> + return err; >> +} >> + >> +static int virtblk_parse_zone(struct virtio_blk *vblk, >> + struct virtio_blk_zone_descriptor *entry, >> + unsigned int idx, unsigned int zone_sectors, >> + report_zones_cb cb, void *data) >> +{ >> + struct blk_zone zone = { }; >> + >> + if (entry->z_type != VIRTIO_BLK_ZT_SWR && >> + entry->z_type != VIRTIO_BLK_ZT_SWP && >> + entry->z_type != VIRTIO_BLK_ZT_CONV) { >> + dev_err(&vblk->vdev->dev, "invalid zone type %#x\n", >> + entry->z_type); >> + return -EINVAL; >> + } >> + >> + zone.type = entry->z_type; >> + zone.cond = entry->z_state; >> + zone.len = zone_sectors; >> + zone.capacity = le64_to_cpu(entry->z_cap); >> + zone.start = le64_to_cpu(entry->z_start); >> + if (zone.cond == BLK_ZONE_COND_FULL) >> + zone.wp = zone.start + zone.len; >> + else >> + zone.wp = le64_to_cpu(entry->z_wp); >> + >> + return cb(&zone, idx, data); >> +} >> + >> +static int virtblk_report_zones(struct gendisk *disk, sector_t sector, >> + unsigned int nr_zones, report_zones_cb cb, >> + void *data) >> +{ >> + struct virtio_blk *vblk = disk->private_data; >> + struct virtio_blk_zone_report *report; >> + unsigned int zone_sectors = vblk->zone_sectors; >> + unsigned int nz, i; >> + int ret, zone_idx = 0; >> + size_t buflen; > + u64 remainder; >> + >> + if (WARN_ON_ONCE(!vblk->zone_sectors)) >> + return -EOPNOTSUPP; >> + >> + report = virtblk_alloc_report_buffer(vblk, nr_zones, >> + zone_sectors, &buflen); >> + if (!report) >> + return -ENOMEM; >> + > - sector &= ~(zone_sectors - 1); > > + div64_u64_rem(sector, zone_sectors, &remainder); > + sector -= remainder; >> + while (zone_idx < nr_zones && sector < get_capacity(vblk->disk)) { >> + memset(report, 0, buflen); >> + >> + ret = virtblk_submit_zone_report(vblk, (char *)report, >> + buflen, sector); >> + if (ret) { >> + if (ret > 0) >> + ret = -EIO; >> + goto out_free; >> + } >> + >> + nz = min((unsigned int)le64_to_cpu(report->nr_zones), nr_zones); >> + if (!nz) >> + break; >> + >> + for (i = 0; i < nz && zone_idx < nr_zones; i++) { >> + ret = virtblk_parse_zone(vblk, &report->zones[i], >> + zone_idx, zone_sectors, cb, data); >> + if (ret) >> + goto out_free; >> + zone_idx++; >> + } >> + >> + sector += zone_sectors * nz; >> + } >> + >> + if (zone_idx > 0) >> + ret = zone_idx; >> + else >> + ret = -EINVAL; >> +out_free: >> + kvfree(report); >> + return ret; >> +} >> + > <snip> >> +static int virtblk_probe_zoned_device(struct virtio_device *vdev, >> + struct virtio_blk *vblk, >> + struct request_queue *q) >> +{ > <snip> >> + blk_queue_physical_block_size(q, le32_to_cpu(v)); >> + blk_queue_io_min(q, le32_to_cpu(v)); >> + >> + dev_dbg(&vdev->dev, "write granularity = %u\n", le32_to_cpu(v)); >> + > - /* > - * virtio ZBD specification doesn't require zones to be a power of > - * two sectors in size, but the code in this driver expects that. > - */ > - virtio_cread(vdev, struct virtio_blk_config, zoned.zone_sectors, &v); > - if (v == 0 || !is_power_of_2(v)) { > - dev_err(&vdev->dev, > - "zoned device with non power of two zone size %u\n", v); > - return -ENODEV; > - } >> + >> + dev_dbg(&vdev->dev, "zone sectors = %u\n", le32_to_cpu(v)); >> + vblk->zone_sectors = le32_to_cpu(v); >> + >> + if (virtio_has_feature(vdev, VIRTIO_BLK_F_DISCARD)) { >> + dev_warn(&vblk->vdev->dev, >> + "ignoring negotiated F_DISCARD for zoned device\n"); >> + blk_queue_max_discard_sectors(q, 0); >> + } >> + >> + ret = blk_revalidate_disk_zones(vblk->disk, NULL); >> + if (!ret) { >> + virtio_cread(vdev, struct virtio_blk_config, >> + zoned.max_append_sectors, &v); >> + if (!v) { >> + dev_warn(&vdev->dev, "zero max_append_sectors reported\n"); >> + return -ENODEV; >> + } >> + blk_queue_max_zone_append_sectors(q, le32_to_cpu(v)); >> + dev_dbg(&vdev->dev, "max append sectors = %u\n", le32_to_cpu(v)); >> + >> + } >> + >> + return ret; >> +} >> + >
Hi Pankaj, Damien, On Tue, 2022-09-20 at 08:59 +0900, Damien Le Moal wrote: > On 9/19/22 22:41, Pankaj Raghav wrote: > > Hi Dmitry, > > > > On Sun, Sep 18, 2022 at 10:29:21PM -0400, Dmitry Fomichev wrote: > > > The zone-specific code in the patch is heavily influenced by NVMe ZNS > > > code in drivers/nvme/host/zns.c, but it is simpler because the proposed > > > virtio ZBD draft only covers the zoned device features that are > > > relevant to the zoned functionality provided by Linux block layer. > > > > > There is a parallel work going on to support non-po2 zone sizes in Linux > > block layer and drivers[1]. I don't see any reason why we shouldn't make > > the calculations generic here instead of putting the constraint on zone > > sectors to be po2 as the virtio spec also supports it. > > That series is not upstream, so implementing against would not be the > correct approach, especially given that this would also impact qemu code. > I am aware about the effort to support non-^2 zone sizes in the kernel and this activity actually made me drop the ^2 zone size requirement from the virtio-zbd specification. I think that the best way to add non-^2 zone size support to this driver could be a follow up patch to this series. This way, we won't rely on the code that is not yet merged upstream. <there is one more comment about your proposed changes below> > > > > I took a quick look, and changing the calculations from po2 specific to > > generic will not be in the hot path and can be trivially changed. I have > > suggested the changes inline to make the virtio blk driver zone size > > agnostic. I haven't tested the changes but it is very > > similar to the changes I did in the drivers/nvme/host/zns.c in my patch > > series[2]. > > > > [1] > > https://lore.kernel.org/linux-block/20220912082204.51189-1-p.raghav@samsung.com/ > > [2] > > https://lore.kernel.org/linux-block/20220912082204.51189-6-p.raghav@samsung.com/ > > > > > Co-developed-by: Stefan Hajnoczi <stefanha@gmail.com> > > > Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com> > > > Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com> > > > --- > > > drivers/block/virtio_blk.c | 381 ++++++++++++++++++++++++++++++-- > > > include/uapi/linux/virtio_blk.h | 106 +++++++++ > > > 2 files changed, 469 insertions(+), 18 deletions(-) > > > > > <snip> > > > +#ifdef CONFIG_BLK_DEV_ZONED > > > +static void *virtblk_alloc_report_buffer(struct virtio_blk *vblk, > > > + unsigned int nr_zones, > > > + unsigned int zone_sectors, > > > + size_t *buflen) > > > +{ > > > + struct request_queue *q = vblk->disk->queue; > > > + size_t bufsize; > > > + void *buf; > > > + > > - nr_zones = min_t(unsigned int, nr_zones, > > - get_capacity(vblk->disk) >> ilog2(zone_sectors)); > > > > + nr_zones = min_t(unsigned int, nr_zones, > > + div64_u64(get_capacity(vblk->disk), zone_sectors)); > > > > > + > > > + bufsize = sizeof(struct virtio_blk_zone_report) + > > > + nr_zones * sizeof(struct virtio_blk_zone_descriptor); > > > + bufsize = min_t(size_t, bufsize, > > > + queue_max_hw_sectors(q) << SECTOR_SHIFT); > > > + bufsize = min_t(size_t, bufsize, queue_max_segments(q) << > > > PAGE_SHIFT); > > > + > > > + while (bufsize >= sizeof(struct virtio_blk_zone_report)) { > > > + buf = __vmalloc(bufsize, GFP_KERNEL | __GFP_NORETRY); > > > + if (buf) { > > > + *buflen = bufsize; > > > + return buf; > > > + } > > > + bufsize >>= 1; > > > + } > > > + > > > + return NULL; > > > +} > > > + > > > +static int virtblk_submit_zone_report(struct virtio_blk *vblk, > > > + char *report_buf, size_t report_len, > > > + sector_t sector) > > > +{ > > > + struct request_queue *q = vblk->disk->queue; > > > + struct request *req; > > > + struct virtblk_req *vbr; > > > + int err; > > > + > > > + req = blk_mq_alloc_request(q, REQ_OP_DRV_IN, 0); > > > + if (IS_ERR(req)) > > > + return PTR_ERR(req); > > > + > > > + vbr = blk_mq_rq_to_pdu(req); > > > + vbr->in_hdr_len = sizeof(vbr->status); > > > + vbr->out_hdr.type = cpu_to_virtio32(vblk->vdev, > > > VIRTIO_BLK_T_ZONE_REPORT); > > > + vbr->out_hdr.sector = cpu_to_virtio64(vblk->vdev, sector); > > > + > > > + err = blk_rq_map_kern(q, req, report_buf, report_len, GFP_KERNEL); > > > + if (err) > > > + goto out; > > > + > > > + blk_execute_rq(req, false); > > > + err = blk_status_to_errno(virtblk_result(vbr->status)); > > > +out:return -ENODEV; > > > + blk_mq_free_request(req); > > > + return err; > > > +} > > > + > > > +static int virtblk_parse_zone(struct virtio_blk *vblk, > > > + struct virtio_blk_zone_descriptor *entry, > > > + unsigned int idx, unsigned int zone_sectors, > > > + report_zones_cb cb, void *data) > > > +{ > > > + struct blk_zone zone = { }; > > > + > > > + if (entry->z_type != VIRTIO_BLK_ZT_SWR && > > > + entry->z_type != VIRTIO_BLK_ZT_SWP && > > > + entry->z_type != VIRTIO_BLK_ZT_CONV) { > > > + dev_err(&vblk->vdev->dev, "invalid zone type %#x\n", > > > + entry->z_type); > > > + return -EINVAL; > > > + } > > > + > > > + zone.type = entry->z_type; > > > + zone.cond = entry->z_state; > > > + zone.len = zone_sectors; > > > + zone.capacity = le64_to_cpu(entry->z_cap); > > > + zone.start = le64_to_cpu(entry->z_start); > > > + if (zone.cond == BLK_ZONE_COND_FULL) > > > + zone.wp = zone.start + zone.len; > > > + else > > > + zone.wp = le64_to_cpu(entry->z_wp); > > > + > > > + return cb(&zone, idx, data); > > > +} > > > + > > > +static int virtblk_report_zones(struct gendisk *disk, sector_t sector, > > > + unsigned int nr_zones, report_zones_cb cb, > > > + void *data) > > > +{ > > > + struct virtio_blk *vblk = disk->private_data; > > > + struct virtio_blk_zone_report *report; > > > + unsigned int zone_sectors = vblk->zone_sectors; > > > + unsigned int nz, i; > > > + int ret, zone_idx = 0; > > > + size_t buflen; > > + u64 remainder; > > > + > > > + if (WARN_ON_ONCE(!vblk->zone_sectors)) > > > + return -EOPNOTSUPP; > > > + > > > + report = virtblk_alloc_report_buffer(vblk, nr_zones, > > > + zone_sectors, &buflen); > > > + if (!report) > > > + return -ENOMEM; > > > + > > - sector &= ~(zone_sectors - 1); > > > > + div64_u64_rem(sector, zone_sectors, &remainder); > > + sector -= remainder; > > > + while (zone_idx < nr_zones && sector < get_capacity(vblk->disk)) { > > > + memset(report, 0, buflen); > > > + > > > + ret = virtblk_submit_zone_report(vblk, (char *)report, > > > + buflen, sector); > > > + if (ret) { > > > + if (ret > 0) > > > + ret = -EIO; > > > + goto out_free; > > > + } > > > + > > > + nz = min((unsigned int)le64_to_cpu(report->nr_zones), > > > nr_zones); > > > + if (!nz) > > > + break; > > > + > > > + for (i = 0; i < nz && zone_idx < nr_zones; i++) { > > > + ret = virtblk_parse_zone(vblk, &report->zones[i], > > > + zone_idx, zone_sectors, > > > cb, data); > > > + if (ret) > > > + goto out_free; > > > + zone_idx++; > > > + } > > > + > > > + sector += zone_sectors * nz; > > > + } > > > + > > > + if (zone_idx > 0) > > > + ret = zone_idx; > > > + else > > > + ret = -EINVAL; > > > +out_free: > > > + kvfree(report); > > > + return ret; > > > +} > > > + > > <snip> > > > +static int virtblk_probe_zoned_device(struct virtio_device *vdev, > > > + struct virtio_blk *vblk, > > > + struct request_queue *q) > > > +{ > > <snip> > > > + blk_queue_physical_block_size(q, le32_to_cpu(v)); > > > + blk_queue_io_min(q, le32_to_cpu(v)); > > > + > > > + dev_dbg(&vdev->dev, "write granularity = %u\n", le32_to_cpu(v)); > > > + > > - /* > > - * virtio ZBD specification doesn't require zones to be a power of > > - * two sectors in size, but the code in this driver expects that. > > - */ > > - virtio_cread(vdev, struct virtio_blk_config, zoned.zone_sectors, &v); > > - if (v == 0 || !is_power_of_2(v)) { > > - dev_err(&vdev->dev, > > - "zoned device with non power of two zone size %u\n", > > v); > > - return -ENODEV; > > - } This part can't be omitted entirely because it contains the call to read zone_sectors value from virtio-blk configuration space. This code instead could be changed to something like virtio_cread(vdev, struct virtio_blk_config, zoned.zone_sectors, &v); if (v == 0) { dev_err(&vdev->dev, "zoned device with zero zone size %u\n", v); return -ENODEV; } DF > > > + > > > + dev_dbg(&vdev->dev, "zone sectors = %u\n", le32_to_cpu(v)); > > > + vblk->zone_sectors = le32_to_cpu(v); > > > + > > > + if (virtio_has_feature(vdev, VIRTIO_BLK_F_DISCARD)) { > > > + dev_warn(&vblk->vdev->dev, > > > + "ignoring negotiated F_DISCARD for zoned > > > device\n"); > > > + blk_queue_max_discard_sectors(q, 0); > > > + } > > > + > > > + ret = blk_revalidate_disk_zones(vblk->disk, NULL); > > > + if (!ret) { > > > + virtio_cread(vdev, struct virtio_blk_config, > > > + zoned.max_append_sectors, &v); > > > + if (!v) { > > > + dev_warn(&vdev->dev, "zero max_append_sectors > > > reported\n"); > > > + return -ENODEV; > > > + } > > > + blk_queue_max_zone_append_sectors(q, le32_to_cpu(v)); > > > + dev_dbg(&vdev->dev, "max append sectors = %u\n", > > > le32_to_cpu(v)); > > > + > > > + } > > > + > > > + return ret; > > > +} > > > + > > >
>>> There is a parallel work going on to support non-po2 zone sizes in Linux >>> block layer and drivers[1]. I don't see any reason why we shouldn't make >>> the calculations generic here instead of putting the constraint on zone >>> sectors to be po2 as the virtio spec also supports it. >> >> That series is not upstream, so implementing against would not be the >> correct approach, especially given that this would also impact qemu code. >> > > I am aware about the effort to support non-^2 zone sizes in the kernel and this > activity actually made me drop the ^2 zone size requirement from the virtio-zbd > specification. I think that the best way to add non-^2 zone size support to this > driver could be a follow up patch to this series. This way, we won't rely on the > code that is not yet merged upstream. > It is actually not relying on the code that is not merged upstream but rather future proofing the code with generic calculations that will not have any performance impact. But if you don't want to pick up these changes now, I can do it in the future as well as the changes are trivial. -- Pankaj
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 9a6aa94a212c..202f0446d5dc 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -80,22 +80,51 @@ struct virtio_blk { int num_vqs; int io_queues[HCTX_MAX_TYPES]; struct virtio_blk_vq *vqs; + + /* For zoned device */ + unsigned int zone_sectors; }; struct virtblk_req { + /* Out header */ struct virtio_blk_outhdr out_hdr; - u8 status; + + /* In header */ + union { + u8 status; + + /* + * The zone append command has an extended in header. + * The status field in zone_append_in_hdr must have + * the same offset in virtblk_req as the non-zoned + * status field above. + */ + struct { + u8 status; + u8 reserved[7]; + u64 append_sector; + } zone_append_in_hdr; + }; + + size_t in_hdr_len; + struct sg_table sg_table; struct scatterlist sg[]; }; -static inline blk_status_t virtblk_result(struct virtblk_req *vbr) +static inline blk_status_t virtblk_result(u8 status) { - switch (vbr->status) { + switch (status) { case VIRTIO_BLK_S_OK: return BLK_STS_OK; case VIRTIO_BLK_S_UNSUPP: return BLK_STS_NOTSUPP; + case VIRTIO_BLK_S_ZONE_OPEN_RESOURCE: + return BLK_STS_ZONE_OPEN_RESOURCE; + case VIRTIO_BLK_S_ZONE_ACTIVE_RESOURCE: + return BLK_STS_ZONE_ACTIVE_RESOURCE; + case VIRTIO_BLK_S_IOERR: + case VIRTIO_BLK_S_ZONE_UNALIGNED_WP: default: return BLK_STS_IOERR; } @@ -111,11 +140,11 @@ static inline struct virtio_blk_vq *get_virtio_blk_vq(struct blk_mq_hw_ctx *hctx static int virtblk_add_req(struct virtqueue *vq, struct virtblk_req *vbr) { - struct scatterlist hdr, status, *sgs[3]; + struct scatterlist out_hdr, in_hdr, *sgs[3]; unsigned int num_out = 0, num_in = 0; - sg_init_one(&hdr, &vbr->out_hdr, sizeof(vbr->out_hdr)); - sgs[num_out++] = &hdr; + sg_init_one(&out_hdr, &vbr->out_hdr, sizeof(vbr->out_hdr)); + sgs[num_out++] = &out_hdr; if (vbr->sg_table.nents) { if (vbr->out_hdr.type & cpu_to_virtio32(vq->vdev, VIRTIO_BLK_T_OUT)) @@ -124,8 +153,8 @@ static int virtblk_add_req(struct virtqueue *vq, struct virtblk_req *vbr) sgs[num_out + num_in++] = vbr->sg_table.sgl; } - sg_init_one(&status, &vbr->status, sizeof(vbr->status)); - sgs[num_out + num_in++] = &status; + sg_init_one(&in_hdr, &vbr->status, vbr->in_hdr_len); + sgs[num_out + num_in++] = &in_hdr; return virtqueue_add_sgs(vq, sgs, num_out, num_in, vbr, GFP_ATOMIC); } @@ -214,21 +243,22 @@ static blk_status_t virtblk_setup_cmd(struct virtio_device *vdev, struct request *req, struct virtblk_req *vbr) { + size_t in_hdr_len = sizeof(vbr->status); bool unmap = false; u32 type; + u64 sector = 0; - vbr->out_hdr.sector = 0; + /* Set fields for all request types */ + vbr->out_hdr.ioprio = cpu_to_virtio32(vdev, req_get_ioprio(req)); switch (req_op(req)) { case REQ_OP_READ: type = VIRTIO_BLK_T_IN; - vbr->out_hdr.sector = cpu_to_virtio64(vdev, - blk_rq_pos(req)); + sector = blk_rq_pos(req); break; case REQ_OP_WRITE: type = VIRTIO_BLK_T_OUT; - vbr->out_hdr.sector = cpu_to_virtio64(vdev, - blk_rq_pos(req)); + sector = blk_rq_pos(req); break; case REQ_OP_FLUSH: type = VIRTIO_BLK_T_FLUSH; @@ -240,16 +270,42 @@ static blk_status_t virtblk_setup_cmd(struct virtio_device *vdev, type = VIRTIO_BLK_T_WRITE_ZEROES; unmap = !(req->cmd_flags & REQ_NOUNMAP); break; - case REQ_OP_DRV_IN: - type = VIRTIO_BLK_T_GET_ID; + case REQ_OP_ZONE_OPEN: + type = VIRTIO_BLK_T_ZONE_OPEN; + sector = blk_rq_pos(req); break; + case REQ_OP_ZONE_CLOSE: + type = VIRTIO_BLK_T_ZONE_CLOSE; + sector = blk_rq_pos(req); + break; + case REQ_OP_ZONE_FINISH: + type = VIRTIO_BLK_T_ZONE_FINISH; + sector = blk_rq_pos(req); + break; + case REQ_OP_ZONE_APPEND: + type = VIRTIO_BLK_T_ZONE_APPEND; + sector = blk_rq_pos(req); + in_hdr_len = sizeof(vbr->zone_append_in_hdr); + break; + case REQ_OP_ZONE_RESET: + type = VIRTIO_BLK_T_ZONE_RESET; + sector = blk_rq_pos(req); + break; + case REQ_OP_ZONE_RESET_ALL: + type = VIRTIO_BLK_T_ZONE_RESET_ALL; + break; + case REQ_OP_DRV_IN: + /* Out header already filled in, nothing to do */ + return 0; default: WARN_ON_ONCE(1); return BLK_STS_IOERR; } + /* Set fields for non-REQ_OP_DRV_IN request types */ + vbr->in_hdr_len = in_hdr_len; vbr->out_hdr.type = cpu_to_virtio32(vdev, type); - vbr->out_hdr.ioprio = cpu_to_virtio32(vdev, req_get_ioprio(req)); + vbr->out_hdr.sector = cpu_to_virtio64(vdev, sector); if (type == VIRTIO_BLK_T_DISCARD || type == VIRTIO_BLK_T_WRITE_ZEROES) { if (virtblk_setup_discard_write_zeroes(req, unmap)) @@ -262,10 +318,15 @@ static blk_status_t virtblk_setup_cmd(struct virtio_device *vdev, static inline void virtblk_request_done(struct request *req) { struct virtblk_req *vbr = blk_mq_rq_to_pdu(req); + int status = virtblk_result(vbr->status); virtblk_unmap_data(req, vbr); virtblk_cleanup_cmd(req); - blk_mq_end_request(req, virtblk_result(vbr)); + + if (req_op(req) == REQ_OP_ZONE_APPEND) + req->__sector = le64_to_cpu(vbr->zone_append_in_hdr.append_sector); + + blk_mq_end_request(req, status); } static void virtblk_done(struct virtqueue *vq) @@ -452,6 +513,270 @@ static void virtio_queue_rqs(struct request **rqlist) *rqlist = requeue_list; } +#ifdef CONFIG_BLK_DEV_ZONED +static void *virtblk_alloc_report_buffer(struct virtio_blk *vblk, + unsigned int nr_zones, + unsigned int zone_sectors, + size_t *buflen) +{ + struct request_queue *q = vblk->disk->queue; + size_t bufsize; + void *buf; + + nr_zones = min_t(unsigned int, nr_zones, + get_capacity(vblk->disk) >> ilog2(zone_sectors)); + + bufsize = sizeof(struct virtio_blk_zone_report) + + nr_zones * sizeof(struct virtio_blk_zone_descriptor); + bufsize = min_t(size_t, bufsize, + queue_max_hw_sectors(q) << SECTOR_SHIFT); + bufsize = min_t(size_t, bufsize, queue_max_segments(q) << PAGE_SHIFT); + + while (bufsize >= sizeof(struct virtio_blk_zone_report)) { + buf = __vmalloc(bufsize, GFP_KERNEL | __GFP_NORETRY); + if (buf) { + *buflen = bufsize; + return buf; + } + bufsize >>= 1; + } + + return NULL; +} + +static int virtblk_submit_zone_report(struct virtio_blk *vblk, + char *report_buf, size_t report_len, + sector_t sector) +{ + struct request_queue *q = vblk->disk->queue; + struct request *req; + struct virtblk_req *vbr; + int err; + + req = blk_mq_alloc_request(q, REQ_OP_DRV_IN, 0); + if (IS_ERR(req)) + return PTR_ERR(req); + + vbr = blk_mq_rq_to_pdu(req); + vbr->in_hdr_len = sizeof(vbr->status); + vbr->out_hdr.type = cpu_to_virtio32(vblk->vdev, VIRTIO_BLK_T_ZONE_REPORT); + vbr->out_hdr.sector = cpu_to_virtio64(vblk->vdev, sector); + + err = blk_rq_map_kern(q, req, report_buf, report_len, GFP_KERNEL); + if (err) + goto out; + + blk_execute_rq(req, false); + err = blk_status_to_errno(virtblk_result(vbr->status)); +out: + blk_mq_free_request(req); + return err; +} + +static int virtblk_parse_zone(struct virtio_blk *vblk, + struct virtio_blk_zone_descriptor *entry, + unsigned int idx, unsigned int zone_sectors, + report_zones_cb cb, void *data) +{ + struct blk_zone zone = { }; + + if (entry->z_type != VIRTIO_BLK_ZT_SWR && + entry->z_type != VIRTIO_BLK_ZT_SWP && + entry->z_type != VIRTIO_BLK_ZT_CONV) { + dev_err(&vblk->vdev->dev, "invalid zone type %#x\n", + entry->z_type); + return -EINVAL; + } + + zone.type = entry->z_type; + zone.cond = entry->z_state; + zone.len = zone_sectors; + zone.capacity = le64_to_cpu(entry->z_cap); + zone.start = le64_to_cpu(entry->z_start); + if (zone.cond == BLK_ZONE_COND_FULL) + zone.wp = zone.start + zone.len; + else + zone.wp = le64_to_cpu(entry->z_wp); + + return cb(&zone, idx, data); +} + +static int virtblk_report_zones(struct gendisk *disk, sector_t sector, + unsigned int nr_zones, report_zones_cb cb, + void *data) +{ + struct virtio_blk *vblk = disk->private_data; + struct virtio_blk_zone_report *report; + unsigned int zone_sectors = vblk->zone_sectors; + unsigned int nz, i; + int ret, zone_idx = 0; + size_t buflen; + + if (WARN_ON_ONCE(!vblk->zone_sectors)) + return -EOPNOTSUPP; + + report = virtblk_alloc_report_buffer(vblk, nr_zones, + zone_sectors, &buflen); + if (!report) + return -ENOMEM; + + sector &= ~(zone_sectors - 1); + while (zone_idx < nr_zones && sector < get_capacity(vblk->disk)) { + memset(report, 0, buflen); + + ret = virtblk_submit_zone_report(vblk, (char *)report, + buflen, sector); + if (ret) { + if (ret > 0) + ret = -EIO; + goto out_free; + } + + nz = min((unsigned int)le64_to_cpu(report->nr_zones), nr_zones); + if (!nz) + break; + + for (i = 0; i < nz && zone_idx < nr_zones; i++) { + ret = virtblk_parse_zone(vblk, &report->zones[i], + zone_idx, zone_sectors, cb, data); + if (ret) + goto out_free; + zone_idx++; + } + + sector += zone_sectors * nz; + } + + if (zone_idx > 0) + ret = zone_idx; + else + ret = -EINVAL; +out_free: + kvfree(report); + return ret; +} + +static void virtblk_revalidate_zones(struct virtio_blk *vblk) +{ + u8 model; + + if (!vblk->zone_sectors) + return; + + virtio_cread(vblk->vdev, struct virtio_blk_config, + zoned.model, &model); + if (!blk_revalidate_disk_zones(vblk->disk, NULL)) + set_capacity_and_notify(vblk->disk, 0); +} + +static int virtblk_probe_zoned_device(struct virtio_device *vdev, + struct virtio_blk *vblk, + struct request_queue *q) +{ + u32 v; + u8 model; + int ret; + + virtio_cread(vdev, struct virtio_blk_config, + zoned.model, &model); + + switch (model) { + case VIRTIO_BLK_Z_NONE: + return 0; + case VIRTIO_BLK_Z_HM: + break; + case VIRTIO_BLK_Z_HA: + /* + * Present the host-aware device as a regular drive. + * TODO It is possible to add an option to make it appear + * in the system as a zoned drive. + */ + return 0; + default: + dev_err(&vdev->dev, "unsupported zone model %d\n", model); + return -EINVAL; + } + + dev_dbg(&vdev->dev, "probing host-managed zoned device\n"); + + disk_set_zoned(vblk->disk, BLK_ZONED_HM); + blk_queue_flag_set(QUEUE_FLAG_ZONE_RESETALL, q); + + virtio_cread(vdev, struct virtio_blk_config, + zoned.max_open_zones, &v); + disk_set_max_open_zones(vblk->disk, le32_to_cpu(v)); + + dev_dbg(&vdev->dev, "max open zones = %u\n", le32_to_cpu(v)); + + virtio_cread(vdev, struct virtio_blk_config, + zoned.max_active_zones, &v); + disk_set_max_active_zones(vblk->disk, le32_to_cpu(v)); + dev_info(&vdev->dev, "max active zones = %u\n", le32_to_cpu(v)); + + virtio_cread(vdev, struct virtio_blk_config, + zoned.write_granularity, &v); + if (!v) { + dev_warn(&vdev->dev, "zero write granularity reported\n"); + return -ENODEV; + } + blk_queue_physical_block_size(q, le32_to_cpu(v)); + blk_queue_io_min(q, le32_to_cpu(v)); + + dev_dbg(&vdev->dev, "write granularity = %u\n", le32_to_cpu(v)); + + /* + * virtio ZBD specification doesn't require zones to be a power of + * two sectors in size, but the code in this driver expects that. + */ + virtio_cread(vdev, struct virtio_blk_config, zoned.zone_sectors, &v); + if (v == 0 || !is_power_of_2(v)) { + dev_err(&vdev->dev, + "zoned device with non power of two zone size %u\n", v); + return -ENODEV; + } + + dev_dbg(&vdev->dev, "zone sectors = %u\n", le32_to_cpu(v)); + vblk->zone_sectors = le32_to_cpu(v); + + if (virtio_has_feature(vdev, VIRTIO_BLK_F_DISCARD)) { + dev_warn(&vblk->vdev->dev, + "ignoring negotiated F_DISCARD for zoned device\n"); + blk_queue_max_discard_sectors(q, 0); + } + + ret = blk_revalidate_disk_zones(vblk->disk, NULL); + if (!ret) { + virtio_cread(vdev, struct virtio_blk_config, + zoned.max_append_sectors, &v); + if (!v) { + dev_warn(&vdev->dev, "zero max_append_sectors reported\n"); + return -ENODEV; + } + blk_queue_max_zone_append_sectors(q, le32_to_cpu(v)); + dev_dbg(&vdev->dev, "max append sectors = %u\n", le32_to_cpu(v)); + + } + + return ret; +} + +#else + +/* + * Zoned block device support is not configured in this kernel. + * We only need to define a few symbols to avoid compilation errors. + */ +#define virtblk_report_zones NULL +static inline void virtblk_revalidate_zones(struct virtio_blk *vblk) +{ +} +static inline int virtblk_probe_zoned_device(struct virtio_device *vdev, + struct virtio_blk *vblk, struct request_queue *q) +{ + return -EOPNOTSUPP; +} +#endif /* CONFIG_BLK_DEV_ZONED */ + /* return id (s/n) string for *disk to *id_str */ static int virtblk_get_id(struct gendisk *disk, char *id_str) @@ -459,18 +784,24 @@ static int virtblk_get_id(struct gendisk *disk, char *id_str) struct virtio_blk *vblk = disk->private_data; struct request_queue *q = vblk->disk->queue; struct request *req; + struct virtblk_req *vbr; int err; req = blk_mq_alloc_request(q, REQ_OP_DRV_IN, 0); if (IS_ERR(req)) return PTR_ERR(req); + vbr = blk_mq_rq_to_pdu(req); + vbr->in_hdr_len = sizeof(vbr->status); + vbr->out_hdr.type = cpu_to_virtio32(vblk->vdev, VIRTIO_BLK_T_GET_ID); + vbr->out_hdr.sector = 0; + err = blk_rq_map_kern(q, req, id_str, VIRTIO_BLK_ID_BYTES, GFP_KERNEL); if (err) goto out; blk_execute_rq(req, false); - err = blk_status_to_errno(virtblk_result(blk_mq_rq_to_pdu(req))); + err = blk_status_to_errno(virtblk_result(vbr->status)); out: blk_mq_free_request(req); return err; @@ -521,6 +852,7 @@ static const struct block_device_operations virtblk_fops = { .owner = THIS_MODULE, .getgeo = virtblk_getgeo, .free_disk = virtblk_free_disk, + .report_zones = virtblk_report_zones, }; static int index_to_minor(int index) @@ -591,6 +923,7 @@ static void virtblk_config_changed_work(struct work_struct *work) struct virtio_blk *vblk = container_of(work, struct virtio_blk, config_work); + virtblk_revalidate_zones(vblk); virtblk_update_capacity(vblk, true); } @@ -1081,6 +1414,15 @@ static int virtblk_probe(struct virtio_device *vdev) virtblk_update_capacity(vblk, false); virtio_device_ready(vdev); + if (virtio_has_feature(vdev, VIRTIO_BLK_F_ZONED)) { + err = virtblk_probe_zoned_device(vdev, vblk, q); + if (err) + goto out_cleanup_disk; + } + + dev_info(&vdev->dev, "blk config size: %zu\n", + sizeof(struct virtio_blk_config)); + err = device_add_disk(&vdev->dev, vblk->disk, virtblk_attr_groups); if (err) goto out_cleanup_disk; @@ -1180,6 +1522,9 @@ static unsigned int features[] = { VIRTIO_BLK_F_RO, VIRTIO_BLK_F_BLK_SIZE, VIRTIO_BLK_F_FLUSH, VIRTIO_BLK_F_TOPOLOGY, VIRTIO_BLK_F_CONFIG_WCE, VIRTIO_BLK_F_MQ, VIRTIO_BLK_F_DISCARD, VIRTIO_BLK_F_WRITE_ZEROES, +#ifdef CONFIG_BLK_DEV_ZONED + VIRTIO_BLK_F_ZONED, +#endif /* CONFIG_BLK_DEV_ZONED */ }; static struct virtio_driver virtio_blk = { diff --git a/include/uapi/linux/virtio_blk.h b/include/uapi/linux/virtio_blk.h index d9122674a539..cec9abf56b65 100644 --- a/include/uapi/linux/virtio_blk.h +++ b/include/uapi/linux/virtio_blk.h @@ -40,6 +40,7 @@ #define VIRTIO_BLK_F_MQ 12 /* support more than one vq */ #define VIRTIO_BLK_F_DISCARD 13 /* DISCARD is supported */ #define VIRTIO_BLK_F_WRITE_ZEROES 14 /* WRITE ZEROES is supported */ +#define VIRTIO_BLK_F_ZONED 17 /* Zoned block device */ /* Legacy feature bits */ #ifndef VIRTIO_BLK_NO_LEGACY @@ -124,6 +125,17 @@ struct virtio_blk_config { /* Secure erase fields that are defined in the virtio spec */ __u8 sec_erase[12]; + + /* Zoned block device characteristics (if VIRTIO_BLK_F_ZONED) */ + struct virtio_blk_zoned_characteristics { + __virtio32 zone_sectors; + __virtio32 max_open_zones; + __virtio32 max_active_zones; + __virtio32 max_append_sectors; + __virtio32 write_granularity; + __u8 model; + __u8 unused2[3]; + } zoned; } __attribute__((packed)); /* @@ -158,6 +170,27 @@ struct virtio_blk_config { /* Write zeroes command */ #define VIRTIO_BLK_T_WRITE_ZEROES 13 +/* Zone append command */ +#define VIRTIO_BLK_T_ZONE_APPEND 15 + +/* Report zones command */ +#define VIRTIO_BLK_T_ZONE_REPORT 16 + +/* Open zone command */ +#define VIRTIO_BLK_T_ZONE_OPEN 18 + +/* Close zone command */ +#define VIRTIO_BLK_T_ZONE_CLOSE 20 + +/* Finish zone command */ +#define VIRTIO_BLK_T_ZONE_FINISH 22 + +/* Reset zone command */ +#define VIRTIO_BLK_T_ZONE_RESET 24 + +/* Reset All zones command */ +#define VIRTIO_BLK_T_ZONE_RESET_ALL 26 + #ifndef VIRTIO_BLK_NO_LEGACY /* Barrier before this op. */ #define VIRTIO_BLK_T_BARRIER 0x80000000 @@ -177,6 +210,72 @@ struct virtio_blk_outhdr { __virtio64 sector; }; +/* + * Supported zoned device models. + */ + +/* Regular block device */ +#define VIRTIO_BLK_Z_NONE 0 +/* Host-managed zoned device */ +#define VIRTIO_BLK_Z_HM 1 +/* Host-aware zoned device */ +#define VIRTIO_BLK_Z_HA 2 + +/* + * Zone descriptor. A part of VIRTIO_BLK_T_ZONE_REPORT command reply. + */ +struct virtio_blk_zone_descriptor { + /* Zone capacity */ + __virtio64 z_cap; + /* The starting sector of the zone */ + __virtio64 z_start; + /* Zone write pointer position in sectors */ + __virtio64 z_wp; + /* Zone type */ + __u8 z_type; + /* Zone state */ + __u8 z_state; + __u8 reserved[38]; +}; + +struct virtio_blk_zone_report { + __virtio64 nr_zones; + __u8 reserved[56]; + struct virtio_blk_zone_descriptor zones[]; +}; + +/* + * Supported zone types. + */ + +/* Conventional zone */ +#define VIRTIO_BLK_ZT_CONV 1 +/* Sequential Write Required zone */ +#define VIRTIO_BLK_ZT_SWR 2 +/* Sequential Write Preferred zone */ +#define VIRTIO_BLK_ZT_SWP 3 + +/* + * Zone states that are available for zones of all types. + */ + +/* Not a write pointer (conventional zones only) */ +#define VIRTIO_BLK_ZS_NOT_WP 0 +/* Empty */ +#define VIRTIO_BLK_ZS_EMPTY 1 +/* Implicitly Open */ +#define VIRTIO_BLK_ZS_IOPEN 2 +/* Explicitly Open */ +#define VIRTIO_BLK_ZS_EOPEN 3 +/* Closed */ +#define VIRTIO_BLK_ZS_CLOSED 4 +/* Read-Only */ +#define VIRTIO_BLK_ZS_RDONLY 13 +/* Full */ +#define VIRTIO_BLK_ZS_FULL 14 +/* Offline */ +#define VIRTIO_BLK_ZS_OFFLINE 15 + /* Unmap this range (only valid for write zeroes command) */ #define VIRTIO_BLK_WRITE_ZEROES_FLAG_UNMAP 0x00000001 @@ -203,4 +302,11 @@ struct virtio_scsi_inhdr { #define VIRTIO_BLK_S_OK 0 #define VIRTIO_BLK_S_IOERR 1 #define VIRTIO_BLK_S_UNSUPP 2 + +/* Error codes that are specific to zoned block devices */ +#define VIRTIO_BLK_S_ZONE_INVALID_CMD 3 +#define VIRTIO_BLK_S_ZONE_UNALIGNED_WP 4 +#define VIRTIO_BLK_S_ZONE_OPEN_RESOURCE 5 +#define VIRTIO_BLK_S_ZONE_ACTIVE_RESOURCE 6 + #endif /* _LINUX_VIRTIO_BLK_H */