| Message ID | 20220919223915.5146-1-olof@lixom.net (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | serial: sifive: enable clocks for UART when probed | expand |
Hello, On Mon, Sep 19, 2022 at 03:39:15PM -0700, Olof Johansson wrote: > When the PWM driver was changed to disable clocks if no PWMs are enabled, > it ended up also disabling the shared parent with the UART, since the > UART doesn't do any clock enablement on its own. > > To avoid these surprises, add clk_prepare_enable/clk_disable_unprepare > calls. > > Fixes: ace41d7564e655 ("pwm: sifive: Ensure the clk is enabled exactly once per running PWM") > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Cc: Emil Renner Berthing <emil.renner.berthing@canonical.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Signed-off-by: Olof Johansson <olof@lixom.net> > --- > drivers/tty/serial/sifive.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c > index 5c3a07546a58..751f98068806 100644 > --- a/drivers/tty/serial/sifive.c > +++ b/drivers/tty/serial/sifive.c > @@ -950,23 +950,28 @@ static int sifive_serial_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "unable to find controller clock\n"); > return PTR_ERR(clk); > } > + clk_prepare_enable(clk); The return code of clk_prepare_enable() must be checked. Also there is a simpler patch to fix that problem. I didn't test but I expect just doing diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c index 5c3a07546a58..4b1d4fe8458e 100644 --- a/drivers/tty/serial/sifive.c +++ b/drivers/tty/serial/sifive.c @@ -945,7 +945,7 @@ static int sifive_serial_probe(struct platform_device *pdev) return PTR_ERR(base); } - clk = devm_clk_get(&pdev->dev, NULL); + clk = devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(clk)) { dev_err(&pdev->dev, "unable to find controller clock\n"); return PTR_ERR(clk); would be enough and also cares for disabling the clock on remove. Best regards Uwe
On Mon, Sep 19, 2022 at 11:14 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > Hello, > > On Mon, Sep 19, 2022 at 03:39:15PM -0700, Olof Johansson wrote: > > When the PWM driver was changed to disable clocks if no PWMs are enabled, > > it ended up also disabling the shared parent with the UART, since the > > UART doesn't do any clock enablement on its own. > > > > To avoid these surprises, add clk_prepare_enable/clk_disable_unprepare > > calls. > > > > Fixes: ace41d7564e655 ("pwm: sifive: Ensure the clk is enabled exactly once per running PWM") > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Cc: Emil Renner Berthing <emil.renner.berthing@canonical.com> > > Cc: Palmer Dabbelt <palmer@dabbelt.com> > > Cc: Paul Walmsley <paul.walmsley@sifive.com> > > Signed-off-by: Olof Johansson <olof@lixom.net> > > --- > > drivers/tty/serial/sifive.c | 14 ++++++++++---- > > 1 file changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c > > index 5c3a07546a58..751f98068806 100644 > > --- a/drivers/tty/serial/sifive.c > > +++ b/drivers/tty/serial/sifive.c > > @@ -950,23 +950,28 @@ static int sifive_serial_probe(struct platform_device *pdev) > > dev_err(&pdev->dev, "unable to find controller clock\n"); > > return PTR_ERR(clk); > > } > > + clk_prepare_enable(clk); > > The return code of clk_prepare_enable() must be checked. Also there is a > simpler patch to fix that problem. I didn't test but I expect just doing > > diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c > index 5c3a07546a58..4b1d4fe8458e 100644 > --- a/drivers/tty/serial/sifive.c > +++ b/drivers/tty/serial/sifive.c > @@ -945,7 +945,7 @@ static int sifive_serial_probe(struct platform_device *pdev) > return PTR_ERR(base); > } > > - clk = devm_clk_get(&pdev->dev, NULL); > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > if (IS_ERR(clk)) { > dev_err(&pdev->dev, "unable to find controller clock\n"); > return PTR_ERR(clk); > > would be enough and also cares for disabling the clock on remove. Yep, thanks for pointing that out. v2 sent out (after test). -Olof
diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c index 5c3a07546a58..751f98068806 100644 --- a/drivers/tty/serial/sifive.c +++ b/drivers/tty/serial/sifive.c @@ -950,23 +950,28 @@ static int sifive_serial_probe(struct platform_device *pdev) dev_err(&pdev->dev, "unable to find controller clock\n"); return PTR_ERR(clk); } + clk_prepare_enable(clk); id = of_alias_get_id(pdev->dev.of_node, "serial"); if (id < 0) { dev_err(&pdev->dev, "missing aliases entry\n"); - return id; + r = id; + goto probe_out1; } #ifdef CONFIG_SERIAL_SIFIVE_CONSOLE if (id > SIFIVE_SERIAL_MAX_PORTS) { dev_err(&pdev->dev, "too many UARTs (%d)\n", id); - return -EINVAL; + r = -EINVAL; + goto probe_out1; } #endif ssp = devm_kzalloc(&pdev->dev, sizeof(*ssp), GFP_KERNEL); - if (!ssp) - return -ENOMEM; + if (!ssp) { + r = -ENOMEM; + goto probe_out1; + } ssp->port.dev = &pdev->dev; ssp->port.type = PORT_SIFIVE_V0; @@ -1028,6 +1033,7 @@ static int sifive_serial_probe(struct platform_device *pdev) probe_out2: clk_notifier_unregister(ssp->clk, &ssp->clk_notifier); probe_out1: + clk_disable_unprepare(clk); return r; }
When the PWM driver was changed to disable clocks if no PWMs are enabled, it ended up also disabling the shared parent with the UART, since the UART doesn't do any clock enablement on its own. To avoid these surprises, add clk_prepare_enable/clk_disable_unprepare calls. Fixes: ace41d7564e655 ("pwm: sifive: Ensure the clk is enabled exactly once per running PWM") Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Emil Renner Berthing <emil.renner.berthing@canonical.com> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Paul Walmsley <paul.walmsley@sifive.com> Signed-off-by: Olof Johansson <olof@lixom.net> --- drivers/tty/serial/sifive.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)