diff mbox series

[linux-next] ALSA: es18xx: Remove the unneeded result variable

Message ID 20220920064605.215318-1-ye.xingchen@zte.com.cn (mailing list archive)
State Accepted
Commit 96ecdc718649fe01940e7f5dc4fc15dacd18cada
Headers show
Series [linux-next] ALSA: es18xx: Remove the unneeded result variable | expand

Commit Message

CGEL Sept. 20, 2022, 6:46 a.m. UTC 
From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value inb() directly instead of storing it in another redundant
 variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 sound/isa/es18xx.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Takashi Iwai Sept. 20, 2022, 11:34 a.m. UTC | #1 
On Tue, 20 Sep 2022 08:46:05 +0200,
cgel.zte@gmail.com wrote:
> 
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Return the value inb() directly instead of storing it in another redundant
>  variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Thanks, applied.


Takashi
diff mbox series

Patch

diff --git a/sound/isa/es18xx.c b/sound/isa/es18xx.c
index 3fcd168480b6..0a32845b1017 100644
--- a/sound/isa/es18xx.c
+++ b/sound/isa/es18xx.c
@@ -1344,11 +1344,8 @@  ES18XX_SINGLE("GPO1 Switch", 0, ES18XX_PM, 1, 1, ES18XX_FL_PMPORT),
 
 static int snd_es18xx_config_read(struct snd_es18xx *chip, unsigned char reg)
 {
-	int data;
-
 	outb(reg, chip->ctrl_port);
-	data = inb(chip->ctrl_port + 1);
-	return data;
+	return inb(chip->ctrl_port + 1);
 }
 
 static void snd_es18xx_config_write(struct snd_es18xx *chip,