diff mbox series

[1/2] hwmon: pc87360: Introduce a #define for the driver name and use it

Message ID 20220919103155.795151-2-u.kleine-koenig@pengutronix.de (mailing list archive)
State Accepted
Headers show
Series hwmon: pc87360: Some cleanups | expand

Commit Message

Uwe Kleine-König Sept. 19, 2022, 10:31 a.m. UTC 
Make use of the cpp symbol DRIVER_NAME to set the driver's name and also
as name for devm_request_region(). While at it add a module alias using
the new define.

This is a preparation for the next cleanup commit that removes a cyclic
dependency between pc87360_driver (which references pc87360_probe in
.probe) and pc87360_probe() (which used pc87360_driver.driver.name).

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/hwmon/pc87360.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Guenter Roeck Sept. 20, 2022, 2:27 p.m. UTC | #1 
On Mon, Sep 19, 2022 at 12:31:54PM +0200, Uwe Kleine-König wrote:
> Make use of the cpp symbol DRIVER_NAME to set the driver's name and also
> as name for devm_request_region(). While at it add a module alias using
> the new define.
> 
> This is a preparation for the next cleanup commit that removes a cyclic
> dependency between pc87360_driver (which references pc87360_probe in
> .probe) and pc87360_probe() (which used pc87360_driver.driver.name).
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Applied to hwmon-next.

Thanks,
Guenter
diff mbox series

Patch

diff --git a/drivers/hwmon/pc87360.c b/drivers/hwmon/pc87360.c
index 0828436a1f6c..b912926c8b18 100644
--- a/drivers/hwmon/pc87360.c
+++ b/drivers/hwmon/pc87360.c
@@ -35,6 +35,8 @@ 
 #include <linux/acpi.h>
 #include <linux/io.h>
 
+#define DRIVER_NAME "pc87360"
+
 static u8 devid;
 static struct platform_device *pdev;
 static unsigned short extra_isa[3];
@@ -228,10 +230,9 @@  static struct pc87360_data *pc87360_update_device(struct device *dev);
 /*
  * Driver data
  */
-
 static struct platform_driver pc87360_driver = {
 	.driver = {
-		.name	= "pc87360",
+		.name	= DRIVER_NAME,
 	},
 	.probe		= pc87360_probe,
 	.remove		= pc87360_remove,
@@ -1239,7 +1240,7 @@  static int pc87360_probe(struct platform_device *pdev)
 		data->address[i] = extra_isa[i];
 		if (data->address[i]
 		 && !devm_request_region(dev, extra_isa[i], PC87360_EXTENT,
-					 pc87360_driver.driver.name)) {
+					 DRIVER_NAME)) {
 			dev_err(dev,
 				"Region 0x%x-0x%x already in use!\n",
 				extra_isa[i], extra_isa[i]+PC87360_EXTENT-1);
@@ -1781,6 +1782,7 @@  static void __exit pc87360_exit(void)
 MODULE_AUTHOR("Jean Delvare <jdelvare@suse.de>");
 MODULE_DESCRIPTION("PC8736x hardware monitor");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:" DRIVER_NAME);
 
 module_init(pc87360_init);
 module_exit(pc87360_exit);