diff mbox series

ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table

Message ID 20220920171320.7776-1-mario.limonciello@amd.com (mailing list archive)
State Accepted
Commit 2232b2dd8cd4f1e6d554b2c3f6899ce36f791b67
Headers show
Series ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table | expand

Commit Message

Mario Limonciello Sept. 20, 2022, 5:13 p.m. UTC 
Lenovo Yoga Slim 7 Pro X has an ACP DMIC that isn't specified in the
ASL or existing quirk list.  Add it to the quirk table to let DMIC
work on these systems.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216299
Tested-by: Sebastian S <iam@decentr.al>
Reporetd-and-tested-by: Travis Glenn Hansen <travisghansen@yahoo.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
This patch applies on top of the other patch introducing a quirk:
	https://lore.kernel.org/alsa-devel/20220917070847.14346-1-lxy.lixiaoyan@gmail.com/
If either of them need to change, we should roll both into a series.

 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Mark Brown Sept. 20, 2022, 6:08 p.m. UTC | #1 
On Tue, Sep 20, 2022 at 12:13:20PM -0500, Mario Limonciello wrote:
> Lenovo Yoga Slim 7 Pro X has an ACP DMIC that isn't specified in the
> ASL or existing quirk list.  Add it to the quirk table to let DMIC
> work on these systems.

This doesn't apply against current code, please check and resend.
Mario Limonciello Sept. 20, 2022, 6:09 p.m. UTC | #2 
On 9/20/2022 13:08, Mark Brown wrote:
> On Tue, Sep 20, 2022 at 12:13:20PM -0500, Mario Limonciello wrote:
>> Lenovo Yoga Slim 7 Pro X has an ACP DMIC that isn't specified in the
>> ASL or existing quirk list.  Add it to the quirk table to let DMIC
>> work on these systems.
> 
> This doesn't apply against current code, please check and resend.

As I mentioned below the cutline it's on top of the other commit on the 
list touching the same code:

https://lore.kernel.org/alsa-devel/20220917070847.14346-1-lxy.lixiaoyan@gmail.com/
Mark Brown Sept. 20, 2022, 6:50 p.m. UTC | #3 
On Tue, Sep 20, 2022 at 01:09:45PM -0500, Limonciello, Mario wrote:

> As I mentioned below the cutline it's on top of the other commit on the list
> touching the same code:

> https://lore.kernel.org/alsa-devel/20220917070847.14346-1-lxy.lixiaoyan@gmail.com/

That looks like it's some patch which wasn't even sent to me...

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
Mario Limonciello Sept. 20, 2022, 6:56 p.m. UTC | #4 
On 9/20/2022 13:50, Mark Brown wrote:
> On Tue, Sep 20, 2022 at 01:09:45PM -0500, Limonciello, Mario wrote:
> 
>> As I mentioned below the cutline it's on top of the other commit on the list
>> touching the same code:
> 
>> https://lore.kernel.org/alsa-devel/20220917070847.14346-1-lxy.lixiaoyan@gmail.com/
> 
> That looks like it's some patch which wasn't even sent to me...
> 
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.


I guess the author forgot to include you in To or CC.  Would you like me 
to just re-send the combination of both of them as a v2 (including the 
first on on behalf of Xiaoyan Li)?
Mark Brown Sept. 20, 2022, 7:08 p.m. UTC | #5 
On Tue, Sep 20, 2022 at 01:56:34PM -0500, Limonciello, Mario wrote:

> I guess the author forgot to include you in To or CC.  Would you like me to
> just re-send the combination of both of them as a v2 (including the first on
> on behalf of Xiaoyan Li)?

Yes, please.
Mark Brown Sept. 21, 2022, 9:23 a.m. UTC | #6 
On Tue, 20 Sep 2022 12:13:20 -0500, Mario Limonciello wrote:
> Lenovo Yoga Slim 7 Pro X has an ACP DMIC that isn't specified in the
> ASL or existing quirk list.  Add it to the quirk table to let DMIC
> work on these systems.
> 
> 

Applied to

   broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table
      commit: 2232b2dd8cd4f1e6d554b2c3f6899ce36f791b67

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 5eab3baf3573..2cb50d5cf1a9 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -171,6 +171,13 @@  static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21J6"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "82"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {