diff mbox series

checkpatch: ignore target/hexagon/imported/* files

Message ID e3b6a345a88807a1c4daa45f638b2a90af538fd5.1663681339.git.quic_mathbern@quicinc.com (mailing list archive)
State New, archived
Headers show
Series checkpatch: ignore target/hexagon/imported/* files | expand

Commit Message

Matheus Tavares Bernardino Sept. 20, 2022, 1:42 p.m. UTC
These files come from an external project (the hexagon archlib), so they
deliberately do not follow QEMU's coding style. To avoid false positives
from checkpatch.pl, let's disable the checking for those.

Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
---
 scripts/checkpatch.pl | 1 +
 1 file changed, 1 insertion(+)

Comments

Philippe Mathieu-Daudé Sept. 20, 2022, 5:55 p.m. UTC | #1
On 20/9/22 15:42, Matheus Tavares Bernardino wrote:
> These files come from an external project (the hexagon archlib), so they
> deliberately do not follow QEMU's coding style. To avoid false positives
> from checkpatch.pl, let's disable the checking for those.
> 
> Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> ---
>   scripts/checkpatch.pl | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Laurent Vivier Sept. 29, 2022, 7:21 p.m. UTC | #2
Le 20/09/2022 à 15:42, Matheus Tavares Bernardino a écrit :
> These files come from an external project (the hexagon archlib), so they
> deliberately do not follow QEMU's coding style. To avoid false positives
> from checkpatch.pl, let's disable the checking for those.
> 
> Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> ---
>   scripts/checkpatch.pl | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d900d18048..e3e3b43076 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1667,6 +1667,7 @@ sub process {
>   # some scripts we imported from other projects.
>   		next if ($realfile =~ /\.(s|S)$/);
>   		next if ($realfile =~ /(checkpatch|get_maintainer)\.pl$/);
> +		next if ($realfile =~ /^target\/hexagon\/imported\/*/);
>   
>   		if ($rawline =~ /^\+.*\t/) {
>   			my $herevet = "$here\n" . cat_vet($rawline) . "\n";

Applied to my trivial-patches branch.

Thanks,
Laurent
diff mbox series

Patch

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d900d18048..e3e3b43076 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1667,6 +1667,7 @@  sub process {
 # some scripts we imported from other projects.
 		next if ($realfile =~ /\.(s|S)$/);
 		next if ($realfile =~ /(checkpatch|get_maintainer)\.pl$/);
+		next if ($realfile =~ /^target\/hexagon\/imported\/*/);
 
 		if ($rawline =~ /^\+.*\t/) {
 			my $herevet = "$here\n" . cat_vet($rawline) . "\n";