diff mbox series

[v3,2/3] dt-bindings: sound: ti, s3a227e: add control of debounce

Message ID 20220919111258.3774-3-astrid.rost@axis.com (mailing list archive)
State Superseded
Headers show
Series ASoC: ts3a227e control debounce times | expand

Commit Message

Astrid Rost Sept. 19, 2022, 11:12 a.m. UTC
Add devicetree parameters to control the insertion, release and press
debounce times.

Signed-off-by: Astrid Rost <astrid.rost@axis.com>
---
 .../bindings/sound/ti,ts3a227e.yaml           | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)

Comments

Krzysztof Kozlowski Sept. 20, 2022, 3:22 p.m. UTC | #1
On 19/09/2022 13:12, Astrid Rost wrote:
> Add devicetree parameters to control the insertion, release and press
> debounce times.
> 
> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
> ---
>  .../bindings/sound/ti,ts3a227e.yaml           | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> index 327d204cf957..76ce323ce965 100644
> --- a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> @@ -41,6 +41,35 @@ properties:
>        - 7 # 2.8 V
>      default: 1
>  
> +  ti,debounce-release-ms:
> +    description: key release debounce time in ms (datasheet section 9.6.7).
> +    enum:
> +      - 0  #  0 ms
> +      - 20 # 20 ms

I don't see any improvements here.

Best regards,
Krzysztof
Astrid Rost Sept. 21, 2022, 8 a.m. UTC | #2
>> +  ti,debounce-release-ms:
>> +    description: key release debounce time in ms (datasheet section 9.6.7).
>> +    enum:
>> +      - 0  #  0 ms
>> +      - 20 # 20 ms
> 
> I don't see any improvements here.

Sorry, I miss understood. I have now just kept the enum values.

Astrid
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
index 327d204cf957..76ce323ce965 100644
--- a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
+++ b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
@@ -41,6 +41,35 @@  properties:
       - 7 # 2.8 V
     default: 1
 
+  ti,debounce-release-ms:
+    description: key release debounce time in ms (datasheet section 9.6.7).
+    enum:
+      - 0  #  0 ms
+      - 20 # 20 ms
+    default: 20
+
+  ti,debounce-press-ms:
+    description: key press debounce time in ms (datasheet section 9.6.7).
+    enum:
+      - 2   #   2 ms
+      - 40  #  40 ms
+      - 80  #  80 ms
+      - 120 # 120 ms
+    default: 80
+
+  ti,debounce-insertion-ms:
+    description: headset insertion debounce time in ms (datasheet section 9.6.5).
+    enum:
+      - 2    #   2 ms
+      - 30   #  30 ms
+      - 60   #  60 ms
+      - 90   #  90 ms
+      - 120  # 120 ms
+      - 150  # 150 ms
+      - 1000 # 1 s
+      - 2000 # 2 s
+    default: 90
+
 required:
   - compatible
   - reg