| Message ID | 20220919-v1-15-4844816c9808@baylibre.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add MT8195 HDMI support | expand |
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add dt-binding documentation of dpi for MediaTek MT8195 SoC. > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > index 5bb23e97cf33..2c7ecef54986 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -24,6 +24,7 @@ properties: > - mediatek,mt8183-dpi > - mediatek,mt8186-dpi > - mediatek,mt8192-dpi > + - mediatek,mt8195-dpi > - mediatek,mt8195-dp-intf Aren't these the same? Best regards, Krzysztof
On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 19/09/2022 18:56, Guillaume Ranquet wrote: > > Add dt-binding documentation of dpi for MediaTek MT8195 SoC. > > > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > index 5bb23e97cf33..2c7ecef54986 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > @@ -24,6 +24,7 @@ properties: > > - mediatek,mt8183-dpi > > - mediatek,mt8186-dpi > > - mediatek,mt8192-dpi > > + - mediatek,mt8195-dpi > > - mediatek,mt8195-dp-intf > > Aren't these the same? *-dpi are MIPI DPI (as in parallel data with DDR modes) encoders. *-dp-intf are Display Port encoder. Totally distinguishable. :) The hardware blocks seem similar upon cursory comparison of the register tables, with the base layout being the same, and sharing registers for basic settings such as the display timings. The DPI ones have some extra registers, presumably to control the signals or output width. The DP one has some registers of its own that only make sense for Display Port. ChenYu
On 26/09/2022 07:24, Chen-Yu Tsai wrote: > On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>> Add dt-binding documentation of dpi for MediaTek MT8195 SoC. >>> >>> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> >>> >>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> index 5bb23e97cf33..2c7ecef54986 100644 >>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> @@ -24,6 +24,7 @@ properties: >>> - mediatek,mt8183-dpi >>> - mediatek,mt8186-dpi >>> - mediatek,mt8192-dpi >>> + - mediatek,mt8195-dpi >>> - mediatek,mt8195-dp-intf >> >> Aren't these the same? > > *-dpi are MIPI DPI (as in parallel data with DDR modes) encoders. > *-dp-intf are Display Port encoder. > > Totally distinguishable. :) > > The hardware blocks seem similar upon cursory comparison of the register > tables, with the base layout being the same, and sharing registers for > basic settings such as the display timings. > > The DPI ones have some extra registers, presumably to control the signals > or output width. The DP one has some registers of its own that only make > sense for Display Port. OK. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index 5bb23e97cf33..2c7ecef54986 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -24,6 +24,7 @@ properties: - mediatek,mt8183-dpi - mediatek,mt8186-dpi - mediatek,mt8192-dpi + - mediatek,mt8195-dpi - mediatek,mt8195-dp-intf reg:
Add dt-binding documentation of dpi for MediaTek MT8195 SoC. Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>