| Message ID | 20220922135228.2206755-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 759fcaaf600e56ec0a33678e85f317c5347562c7 |
| Headers | show |
| Series | [-next] usb: typec: stusb160x: Switch to use dev_err_probe() helper | expand |
On Thu, Sep 22, 2022 at 09:52:28PM +0800, Yang Yingliang wrote: > In the probe path, dev_err() can be replaced with dev_err_probe() > which will check if error code is -EPROBE_DEFER and prints the > error name. It also sets the defer probe reason which can be > checked later through debugfs. It's more simple in error path. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/stusb160x.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c > index 8638f1d39896..494b371151e0 100644 > --- a/drivers/usb/typec/stusb160x.c > +++ b/drivers/usb/typec/stusb160x.c > @@ -750,11 +750,8 @@ static int stusb160x_probe(struct i2c_client *client) > if (client->irq) { > chip->role_sw = fwnode_usb_role_switch_get(fwnode); > if (IS_ERR(chip->role_sw)) { > - ret = PTR_ERR(chip->role_sw); > - if (ret != -EPROBE_DEFER) > - dev_err(chip->dev, > - "Failed to get usb role switch: %d\n", > - ret); > + ret = dev_err_probe(chip->dev, PTR_ERR(chip->role_sw), > + "Failed to get usb role switch\n"); > goto port_unregister; > } > > -- > 2.25.1
diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c index 8638f1d39896..494b371151e0 100644 --- a/drivers/usb/typec/stusb160x.c +++ b/drivers/usb/typec/stusb160x.c @@ -750,11 +750,8 @@ static int stusb160x_probe(struct i2c_client *client) if (client->irq) { chip->role_sw = fwnode_usb_role_switch_get(fwnode); if (IS_ERR(chip->role_sw)) { - ret = PTR_ERR(chip->role_sw); - if (ret != -EPROBE_DEFER) - dev_err(chip->dev, - "Failed to get usb role switch: %d\n", - ret); + ret = dev_err_probe(chip->dev, PTR_ERR(chip->role_sw), + "Failed to get usb role switch\n"); goto port_unregister; }
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. It's more simple in error path. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/usb/typec/stusb160x.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)