| Message ID | 20220922191038.29921-1-vfedorenko@novek.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8db3d514e96715c897fe793c4d5fc0fd86aca517 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v3] bnxt_en: replace reset with config timestamps | expand |
On Thu, Sep 22, 2022 at 12:11 PM Vadim Fedorenko <vfedorenko@novek.ru> wrote: > > Any change to the hardware timestamps configuration triggers nic restart, > which breaks transmition and reception of network packets for a while. > But there is no need to fully restart the device because while configuring > hardware timestamps. The code for changing configuration runs after all > of the initialisation, when the NIC is actually up and running. This patch > changes the code that ioctl will only update configuration registers and > will not trigger carrier status change, but in case of timestamps for > all rx packetes it fallbacks to close()/open() sequnce because of > synchronization issues in the hardware. Tested on BCM57504. > > Cc: Richard Cochran <richardcochran@gmail.com> > Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru> Thanks. Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 22 Sep 2022 22:10:38 +0300 you wrote: > Any change to the hardware timestamps configuration triggers nic restart, > which breaks transmition and reception of network packets for a while. > But there is no need to fully restart the device because while configuring > hardware timestamps. The code for changing configuration runs after all > of the initialisation, when the NIC is actually up and running. This patch > changes the code that ioctl will only update configuration registers and > will not trigger carrier status change, but in case of timestamps for > all rx packetes it fallbacks to close()/open() sequnce because of > synchronization issues in the hardware. Tested on BCM57504. > > [...] Here is the summary with links: - [net-next,v3] bnxt_en: replace reset with config timestamps https://git.kernel.org/netdev/net-next/c/8db3d514e967 You are awesome, thank you!
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c index 7f3c0875b6f5..bd86919799ad 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c @@ -505,9 +505,13 @@ static int bnxt_hwrm_ptp_cfg(struct bnxt *bp) ptp->tstamp_filters = flags; if (netif_running(bp->dev)) { - rc = bnxt_close_nic(bp, false, false); - if (!rc) - rc = bnxt_open_nic(bp, false, false); + if (ptp->rx_filter == HWTSTAMP_FILTER_ALL) { + rc = bnxt_close_nic(bp, false, false); + if (!rc) + rc = bnxt_open_nic(bp, false, false); + } else { + bnxt_ptp_cfg_tstamp_filters(bp); + } if (!rc && !ptp->tstamp_filters) rc = -EIO; }
Any change to the hardware timestamps configuration triggers nic restart, which breaks transmition and reception of network packets for a while. But there is no need to fully restart the device because while configuring hardware timestamps. The code for changing configuration runs after all of the initialisation, when the NIC is actually up and running. This patch changes the code that ioctl will only update configuration registers and will not trigger carrier status change, but in case of timestamps for all rx packetes it fallbacks to close()/open() sequnce because of synchronization issues in the hardware. Tested on BCM57504. Cc: Richard Cochran <richardcochran@gmail.com> Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)