diff mbox series

[v2,24/39] tests/qtest: virtio-net-failover: Disable migration tests for win32

Message ID 20220920103159.1865256-25-bmeng.cn@gmail.com (mailing list archive)
State New, archived
Headers show
Series tests/qtest: Enable running qtest on Windows | expand

Commit Message

Bin Meng Sept. 20, 2022, 10:31 a.m. UTC
From: Xuzhou Cheng <xuzhou.cheng@windriver.com>

These tests use the exec migration protocol, which is unsupported
on Windows as of today. Disable these tests for now.

Signed-off-by: Xuzhou Cheng <xuzhou.cheng@windriver.com>
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

(no changes since v1)

 tests/qtest/virtio-net-failover.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Marc-André Lureau Sept. 22, 2022, 8:05 p.m. UTC | #1
On Tue, Sep 20, 2022 at 3:28 PM Bin Meng <bmeng.cn@gmail.com> wrote:

> From: Xuzhou Cheng <xuzhou.cheng@windriver.com>
>
> These tests use the exec migration protocol, which is unsupported
> on Windows as of today. Disable these tests for now.
>
> Signed-off-by: Xuzhou Cheng <xuzhou.cheng@windriver.com>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>
> (no changes since v1)
>
>  tests/qtest/virtio-net-failover.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/virtio-net-failover.c
> b/tests/qtest/virtio-net-failover.c
> index 443ee56de9..4a809590bf 100644
> --- a/tests/qtest/virtio-net-failover.c
> +++ b/tests/qtest/virtio-net-failover.c
> @@ -588,6 +588,7 @@ static void test_hotplug_2_reverse(void)
>      machine_stop(qts);
>  }
>
> +#ifndef _WIN32
>  static QDict *migrate_status(QTestState *qts)
>  {
>      QDict *resp, *ret;
> @@ -1827,6 +1828,7 @@ static void test_multi_in(gconstpointer opaque)
>
>      machine_stop(qts);
>  }
> +#endif /* _WIN32 */
>
>  int main(int argc, char **argv)
>  {
> @@ -1857,7 +1859,11 @@ int main(int argc, char **argv)
>      qtest_add_func("failover-virtio-net/hotplug/2_reverse",
>                     test_hotplug_2_reverse);
>
> -    /* migration tests */
> +#ifndef _WIN32
> +    /*
> +     * These migration tests cases use the exec migration protocol,
> +     * which is unsupported on Windows.
> +     */
>      qtest_add_data_func("failover-virtio-net/migrate/on/out", tmpfile,
>                          test_migrate_out);
>      qtest_add_data_func("failover-virtio-net/migrate/on/in", tmpfile,
> @@ -1886,6 +1892,7 @@ int main(int argc, char **argv)
>                          tmpfile, test_multi_out);
>      qtest_add_data_func("failover-virtio-net/migrate/multi/in",
>                     tmpfile, test_multi_in);
> +#endif /* _WIN32 */
>
>      ret = g_test_run();
>
> --
> 2.34.1
>
>
>
diff mbox series

Patch

diff --git a/tests/qtest/virtio-net-failover.c b/tests/qtest/virtio-net-failover.c
index 443ee56de9..4a809590bf 100644
--- a/tests/qtest/virtio-net-failover.c
+++ b/tests/qtest/virtio-net-failover.c
@@ -588,6 +588,7 @@  static void test_hotplug_2_reverse(void)
     machine_stop(qts);
 }
 
+#ifndef _WIN32
 static QDict *migrate_status(QTestState *qts)
 {
     QDict *resp, *ret;
@@ -1827,6 +1828,7 @@  static void test_multi_in(gconstpointer opaque)
 
     machine_stop(qts);
 }
+#endif /* _WIN32 */
 
 int main(int argc, char **argv)
 {
@@ -1857,7 +1859,11 @@  int main(int argc, char **argv)
     qtest_add_func("failover-virtio-net/hotplug/2_reverse",
                    test_hotplug_2_reverse);
 
-    /* migration tests */
+#ifndef _WIN32
+    /*
+     * These migration tests cases use the exec migration protocol,
+     * which is unsupported on Windows.
+     */
     qtest_add_data_func("failover-virtio-net/migrate/on/out", tmpfile,
                         test_migrate_out);
     qtest_add_data_func("failover-virtio-net/migrate/on/in", tmpfile,
@@ -1886,6 +1892,7 @@  int main(int argc, char **argv)
                         tmpfile, test_multi_out);
     qtest_add_data_func("failover-virtio-net/migrate/multi/in",
                    tmpfile, test_multi_in);
+#endif /* _WIN32 */
 
     ret = g_test_run();