| Message ID | 20220811105014.7194-1-vincent.knecht@mailoo.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | thermal: qcom: tsens-v0_1: Fix MSM8939 fourth sensor hw_id | expand |
On Thu, Aug 11, 2022 at 12:50:14PM +0200, Vincent Knecht wrote: > Reading temperature from this sensor fails with 'Invalid argument'. > > Looking at old vendor dts [1], its hw_id should be 3 instead of 4. > Change this hw_id accordingly. > > [1] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/master/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L511 > > Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for MSM8939") > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Regards, Bjorn > --- > Fixes reading GPU temperature on msm8939 idol3 with current WIP dtsi > --- > drivers/thermal/qcom/tsens-v0_1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c > index f136cb350238..327f37202c69 100644 > --- a/drivers/thermal/qcom/tsens-v0_1.c > +++ b/drivers/thermal/qcom/tsens-v0_1.c > @@ -604,7 +604,7 @@ static const struct tsens_ops ops_8939 = { > struct tsens_plat_data data_8939 = { > .num_sensors = 10, > .ops = &ops_8939, > - .hw_ids = (unsigned int []){ 0, 1, 2, 4, 5, 6, 7, 8, 9, 10 }, > + .hw_ids = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, 10 }, > > .feat = &tsens_v0_1_feat, > .fields = tsens_v0_1_regfields, > -- > 2.37.1 > > >
On 11/08/2022 13:50, Vincent Knecht wrote: > Reading temperature from this sensor fails with 'Invalid argument'. > > Looking at old vendor dts [1], its hw_id should be 3 instead of 4. > Change this hw_id accordingly. > > [1] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/master/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L511 > > Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for MSM8939") > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Daniel, gracious ping for getting this patch into 6.1. > --- > Fixes reading GPU temperature on msm8939 idol3 with current WIP dtsi > --- > drivers/thermal/qcom/tsens-v0_1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c > index f136cb350238..327f37202c69 100644 > --- a/drivers/thermal/qcom/tsens-v0_1.c > +++ b/drivers/thermal/qcom/tsens-v0_1.c > @@ -604,7 +604,7 @@ static const struct tsens_ops ops_8939 = { > struct tsens_plat_data data_8939 = { > .num_sensors = 10, > .ops = &ops_8939, > - .hw_ids = (unsigned int []){ 0, 1, 2, 4, 5, 6, 7, 8, 9, 10 }, > + .hw_ids = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, 10 }, > > .feat = &tsens_v0_1_feat, > .fields = tsens_v0_1_regfields,
On 24/09/2022 18:38, Dmitry Baryshkov wrote: > On 11/08/2022 13:50, Vincent Knecht wrote: >> Reading temperature from this sensor fails with 'Invalid argument'. >> >> Looking at old vendor dts [1], its hw_id should be 3 instead of 4. >> Change this hw_id accordingly. >> >> [1] >> https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/master/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L511 >> >> >> Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for >> MSM8939") >> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Daniel, gracious ping for getting this patch into 6.1. Applied for 6.1, thanks
diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c index f136cb350238..327f37202c69 100644 --- a/drivers/thermal/qcom/tsens-v0_1.c +++ b/drivers/thermal/qcom/tsens-v0_1.c @@ -604,7 +604,7 @@ static const struct tsens_ops ops_8939 = { struct tsens_plat_data data_8939 = { .num_sensors = 10, .ops = &ops_8939, - .hw_ids = (unsigned int []){ 0, 1, 2, 4, 5, 6, 7, 8, 9, 10 }, + .hw_ids = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, 10 }, .feat = &tsens_v0_1_feat, .fields = tsens_v0_1_regfields,
Reading temperature from this sensor fails with 'Invalid argument'. Looking at old vendor dts [1], its hw_id should be 3 instead of 4. Change this hw_id accordingly. [1] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/master/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L511 Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for MSM8939") Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> --- Fixes reading GPU temperature on msm8939 idol3 with current WIP dtsi --- drivers/thermal/qcom/tsens-v0_1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)