diff mbox series

video: fbdev: arkfb: Remove the unused function dac_read_reg()

Message ID 20220914102301.87981-3-jiapeng.chong@linux.alibaba.com (mailing list archive)
State Accepted, archived
Headers show
Series video: fbdev: arkfb: Remove the unused function dac_read_reg() | expand

Commit Message

Jiapeng Chong Sept. 14, 2022, 10:23 a.m. UTC
The function dac_read_reg() is defined in the arkfb.c file, but not
called elsewhere, so delete this unused function.

drivers/video/fbdev/arkfb.c:322:18: warning: unused function 'dac_read_reg'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2155
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/video/fbdev/arkfb.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Helge Deller Sept. 25, 2022, 11:09 a.m. UTC | #1
On 9/14/22 12:23, Jiapeng Chong wrote:
> The function dac_read_reg() is defined in the arkfb.c file, but not
> called elsewhere, so delete this unused function.
>
> drivers/video/fbdev/arkfb.c:322:18: warning: unused function 'dac_read_reg'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2155
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

applied.

Thanks,
Helge

> ---
>   drivers/video/fbdev/arkfb.c | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
> index a317d9fe1d67..5f8fec9e5fd4 100644
> --- a/drivers/video/fbdev/arkfb.c
> +++ b/drivers/video/fbdev/arkfb.c
> @@ -318,14 +318,6 @@ struct dac_info
>   	void *data;
>   };
>
> -
> -static inline u8 dac_read_reg(struct dac_info *info, u8 reg)
> -{
> -	u8 code[2] = {reg, 0};
> -	info->dac_read_regs(info->data, code, 1);
> -	return code[1];
> -}
> -
>   static inline void dac_read_regs(struct dac_info *info, u8 *code, int count)
>   {
>   	info->dac_read_regs(info->data, code, count);
diff mbox series

Patch

diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
index a317d9fe1d67..5f8fec9e5fd4 100644
--- a/drivers/video/fbdev/arkfb.c
+++ b/drivers/video/fbdev/arkfb.c
@@ -318,14 +318,6 @@  struct dac_info
 	void *data;
 };
 
-
-static inline u8 dac_read_reg(struct dac_info *info, u8 reg)
-{
-	u8 code[2] = {reg, 0};
-	info->dac_read_regs(info->data, code, 1);
-	return code[1];
-}
-
 static inline void dac_read_regs(struct dac_info *info, u8 *code, int count)
 {
 	info->dac_read_regs(info->data, code, count);