| Message ID | 20220907135056.679617-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | fbdev: remove redundant initialization to variable identical | expand |
On 9/7/22 15:50, Colin Ian King wrote: > The variable identical is being initialized with a value that is never > read. The variable is being re-assigned later on. The initialization is > redundant and can be removed. > > Cleans up clang scan-build warning: > drivers/video/fbdev/udlfb.c:373:6: warning: Value stored to 'identical' > during its initialization is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> applied. Thanks! Helge > --- > drivers/video/fbdev/udlfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c > index c863244ef12c..216d49c9d47e 100644 > --- a/drivers/video/fbdev/udlfb.c > +++ b/drivers/video/fbdev/udlfb.c > @@ -370,7 +370,7 @@ static int dlfb_trim_hline(const u8 *bback, const u8 **bfront, int *width_bytes) > const unsigned long *back = (const unsigned long *) bback; > const unsigned long *front = (const unsigned long *) *bfront; > const int width = *width_bytes / sizeof(unsigned long); > - int identical = width; > + int identical; > int start = width; > int end = width; >
diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c index c863244ef12c..216d49c9d47e 100644 --- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -370,7 +370,7 @@ static int dlfb_trim_hline(const u8 *bback, const u8 **bfront, int *width_bytes) const unsigned long *back = (const unsigned long *) bback; const unsigned long *front = (const unsigned long *) *bfront; const int width = *width_bytes / sizeof(unsigned long); - int identical = width; + int identical; int start = width; int end = width;
The variable identical is being initialized with a value that is never read. The variable is being re-assigned later on. The initialization is redundant and can be removed. Cleans up clang scan-build warning: drivers/video/fbdev/udlfb.c:373:6: warning: Value stored to 'identical' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/video/fbdev/udlfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)