| Message ID | 20220924072216.103876-1-chenzhongjin@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] module: Remove unused macros module_addr_min/max | expand |
Le 24/09/2022 à 09:22, Chen Zhongjin a écrit : > Unused macros reported by [-Wunused-macros]. > > These macros are introduced to record the bound address of modules. > > '80b8bf436990 ("module: Always have struct mod_tree_root")' > This commit has made struct mod_tree_root always exist, which means > we can always referencing mod_tree derectly rather than using this > macro. > > So they are useless, remove them for code cleaning. Yeah, it looks like this removal got lost during a rebase. Should have been part of 55ce556dbf92 ("module: Remove module_addr_min and module_addr_max") Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> > > Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com> > --- > kernel/module/main.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/kernel/module/main.c b/kernel/module/main.c > index a4e4d84b6f4e..96dcc950da60 100644 > --- a/kernel/module/main.c > +++ b/kernel/module/main.c > @@ -84,9 +84,6 @@ struct mod_tree_root mod_data_tree __cacheline_aligned = { > }; > #endif > > -#define module_addr_min mod_tree.addr_min > -#define module_addr_max mod_tree.addr_max > - > struct symsearch { > const struct kernel_symbol *start, *stop; > const s32 *crcs;
Hi, On Sat, 24 Sep 2022, Chen Zhongjin wrote: > Unused macros reported by [-Wunused-macros]. > > These macros are introduced to record the bound address of modules. > > '80b8bf436990 ("module: Always have struct mod_tree_root")' > This commit has made struct mod_tree_root always exist, which means > we can always referencing mod_tree derectly rather than using this > macro. > > So they are useless, remove them for code cleaning. a nit, but I would rephrase the changelog a bit... " Commit 80b8bf436990 ("module: Always have struct mod_tree_root") made "struct mod_tree_root" always present and its members addr_min and addr_max can be directly accessed. Macros module_addr_min and module_addr_min are not used anymore, so remove them. " > Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com> Anyway Reviewed-by: Miroslav Benes <mbenes@suse.cz> M
On Fri, Sep 30, 2022 at 01:37:25PM +0200, Miroslav Benes wrote: > Hi, > > On Sat, 24 Sep 2022, Chen Zhongjin wrote: > > > Unused macros reported by [-Wunused-macros]. > > > > These macros are introduced to record the bound address of modules. > > > > '80b8bf436990 ("module: Always have struct mod_tree_root")' > > This commit has made struct mod_tree_root always exist, which means > > we can always referencing mod_tree derectly rather than using this > > macro. > > > > So they are useless, remove them for code cleaning. > > a nit, but I would rephrase the changelog a bit... > > " > Commit 80b8bf436990 ("module: Always have struct mod_tree_root") made > "struct mod_tree_root" always present and its members addr_min and > addr_max can be directly accessed. > > Macros module_addr_min and module_addr_min are not used anymore, so remove > them. > " > > > Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com> > > Anyway > > Reviewed-by: Miroslav Benes <mbenes@suse.cz> Thanks all, I've changed the commit message as suggested by Miroslav, and will queue this up for 6.2. Luis
diff --git a/kernel/module/main.c b/kernel/module/main.c index a4e4d84b6f4e..96dcc950da60 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -84,9 +84,6 @@ struct mod_tree_root mod_data_tree __cacheline_aligned = { }; #endif -#define module_addr_min mod_tree.addr_min -#define module_addr_max mod_tree.addr_max - struct symsearch { const struct kernel_symbol *start, *stop; const s32 *crcs;
Unused macros reported by [-Wunused-macros]. These macros are introduced to record the bound address of modules. '80b8bf436990 ("module: Always have struct mod_tree_root")' This commit has made struct mod_tree_root always exist, which means we can always referencing mod_tree derectly rather than using this macro. So they are useless, remove them for code cleaning. Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com> --- kernel/module/main.c | 3 --- 1 file changed, 3 deletions(-)