| Message ID | 20220923202911.119729-2-gerhard@engleder-embedded.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | tsnep: multi queue support and some other improvements | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On 23/09/2022 22:29, Gerhard Engleder wrote: > Fix the following dtbs_check error if dma-coherent is used: > > ...: 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' > From schema: .../Documentation/devicetree/bindings/net/engleder,tsnep.yaml Skip last line - it's obvious. What instead you miss here - the DTS/target which has this warning. I assume that some existing DTS uses this property? > > Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> Best regards, Krzysztof
On 24.09.22 11:15, Krzysztof Kozlowski wrote: > On 23/09/2022 22:29, Gerhard Engleder wrote: >> Fix the following dtbs_check error if dma-coherent is used: >> >> ...: 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' >> From schema: .../Documentation/devicetree/bindings/net/engleder,tsnep.yaml > > Skip last line - it's obvious. What instead you miss here - the > DTS/target which has this warning. I assume that some existing DTS uses > this property? I will skip that line. The binding is for an FPGA based Ethernet MAC. I'm working with an evaluation platform currently. The DTS for the evaluation platform is mainline, but my derived DTS was not accepted mainline. So there is no DTS. This is similar for other FPGA based devices. >> >> Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> > Best regards, > Krzysztof Thanks! Gerhard
On 24/09/2022 20:11, Gerhard Engleder wrote: > On 24.09.22 11:15, Krzysztof Kozlowski wrote: >> On 23/09/2022 22:29, Gerhard Engleder wrote: >>> Fix the following dtbs_check error if dma-coherent is used: >>> >>> ...: 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' >>> From schema: .../Documentation/devicetree/bindings/net/engleder,tsnep.yaml >> >> Skip last line - it's obvious. What instead you miss here - the >> DTS/target which has this warning. I assume that some existing DTS uses >> this property? > > I will skip that line. > > The binding is for an FPGA based Ethernet MAC. I'm working with > an evaluation platform currently. The DTS for the evaluation platform > is mainline, but my derived DTS was not accepted mainline. So there is > no DTS. This is similar for other FPGA based devices. If this is not coming from mainline, then there is no warning... we are not interested in warnings in out-of-tree code, because we are not fixing them. Best regards, Krzysztof
On 25.09.22 09:41, Krzysztof Kozlowski wrote: > On 24/09/2022 20:11, Gerhard Engleder wrote: >> On 24.09.22 11:15, Krzysztof Kozlowski wrote: >>> On 23/09/2022 22:29, Gerhard Engleder wrote: >>>> Fix the following dtbs_check error if dma-coherent is used: >>>> >>>> ...: 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' >>>> From schema: .../Documentation/devicetree/bindings/net/engleder,tsnep.yaml >>> >>> Skip last line - it's obvious. What instead you miss here - the >>> DTS/target which has this warning. I assume that some existing DTS uses >>> this property? >> >> I will skip that line. >> >> The binding is for an FPGA based Ethernet MAC. I'm working with >> an evaluation platform currently. The DTS for the evaluation platform >> is mainline, but my derived DTS was not accepted mainline. So there is >> no DTS. This is similar for other FPGA based devices. > > If this is not coming from mainline, then there is no warning... we are > not interested in warnings in out-of-tree code, because we are not > fixing them. Ok. So I would rewrite the description that it just allows dma-coherent and remove the fix/warning stuff. Is that ok? Thanks! Gerhard
On 25/09/2022 10:14, Gerhard Engleder wrote: > On 25.09.22 09:41, Krzysztof Kozlowski wrote: >> On 24/09/2022 20:11, Gerhard Engleder wrote: >>> On 24.09.22 11:15, Krzysztof Kozlowski wrote: >>>> On 23/09/2022 22:29, Gerhard Engleder wrote: >>>>> Fix the following dtbs_check error if dma-coherent is used: >>>>> >>>>> ...: 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' >>>>> From schema: .../Documentation/devicetree/bindings/net/engleder,tsnep.yaml >>>> >>>> Skip last line - it's obvious. What instead you miss here - the >>>> DTS/target which has this warning. I assume that some existing DTS uses >>>> this property? >>> >>> I will skip that line. >>> >>> The binding is for an FPGA based Ethernet MAC. I'm working with >>> an evaluation platform currently. The DTS for the evaluation platform >>> is mainline, but my derived DTS was not accepted mainline. So there is >>> no DTS. This is similar for other FPGA based devices. >> >> If this is not coming from mainline, then there is no warning... we are >> not interested in warnings in out-of-tree code, because we are not >> fixing them. > > Ok. So I would rewrite the description that it just allows dma-coherent > and remove the fix/warning stuff. Is that ok? That would be okay, but please add answer to why you are making this change. Best regards, Krzysztof
On 26.09.22 10:55, Krzysztof Kozlowski wrote: > On 25/09/2022 10:14, Gerhard Engleder wrote: >> On 25.09.22 09:41, Krzysztof Kozlowski wrote: >>> On 24/09/2022 20:11, Gerhard Engleder wrote: >>>> On 24.09.22 11:15, Krzysztof Kozlowski wrote: >>>>> On 23/09/2022 22:29, Gerhard Engleder wrote: >>>>>> Fix the following dtbs_check error if dma-coherent is used: >>>>>> >>>>>> ...: 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' >>>>>> From schema: .../Documentation/devicetree/bindings/net/engleder,tsnep.yaml >>>>> >>>>> Skip last line - it's obvious. What instead you miss here - the >>>>> DTS/target which has this warning. I assume that some existing DTS uses >>>>> this property? >>>> >>>> I will skip that line. >>>> >>>> The binding is for an FPGA based Ethernet MAC. I'm working with >>>> an evaluation platform currently. The DTS for the evaluation platform >>>> is mainline, but my derived DTS was not accepted mainline. So there is >>>> no DTS. This is similar for other FPGA based devices. >>> >>> If this is not coming from mainline, then there is no warning... we are >>> not interested in warnings in out-of-tree code, because we are not >>> fixing them. >> >> Ok. So I would rewrite the description that it just allows dma-coherent >> and remove the fix/warning stuff. Is that ok? > > That would be okay, but please add answer to why you are making this change. I already prepared it: Within SoCs like ZynqMP, FPGA logic can be connected to different kinds of AXI master ports. Also cache coherent AXI master ports are available. The property "dma-coherent" is used to signal that DMA is cache coherent. Add "dma-coherent" property to allow the configuration of cache coherent DMA. Thanks! Gerhard
On 26/09/2022 19:46, Gerhard Engleder wrote: >> That would be okay, but please add answer to why you are making this change. > > I already prepared it: > > Within SoCs like ZynqMP, FPGA logic can be connected to different kinds > of AXI master ports. Also cache coherent AXI master ports are available. > The property "dma-coherent" is used to signal that DMA is cache > coherent. > Add "dma-coherent" property to allow the configuration of cache coherent > DMA. > Sounds good, thanks. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/engleder,tsnep.yaml b/Documentation/devicetree/bindings/net/engleder,tsnep.yaml index d0e1476e15b5..37e08ee744a8 100644 --- a/Documentation/devicetree/bindings/net/engleder,tsnep.yaml +++ b/Documentation/devicetree/bindings/net/engleder,tsnep.yaml @@ -22,6 +22,8 @@ properties: interrupts: maxItems: 1 + dma-coherent: true + local-mac-address: true mac-address: true
Fix the following dtbs_check error if dma-coherent is used: ...: 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: .../Documentation/devicetree/bindings/net/engleder,tsnep.yaml Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> --- Documentation/devicetree/bindings/net/engleder,tsnep.yaml | 2 ++ 1 file changed, 2 insertions(+)