| Message ID | 20220927094727.12762-2-michal.orzel@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | GitLab CI cleanup & improvements for Arm | expand |
Hi Michal, > -----Original Message----- > From: Michal Orzel <michal.orzel@amd.com> > Subject: [for-4.17,PATCH v3 01/10] automation: qemu-smoke-arm{32/64}.sh: > Fix typo in DEBIAN_FRONTENT > > The correct variable name is DEBIAN_FRONTEND and not DEBIAN_FRONTENT. > > Signed-off-by: Michal Orzel <michal.orzel@amd.com> > --- > CC: Henry Wang <Henry.Wang@arm.com> > > Rationale for taking this patch for 4.17: > Setting DEBIAN_FRONTEND to noninteractive menas that we need zero > interaction > while installing/upgrading the system via apt-get. It accepts the default > answer to all the questions (using apt-get -y only works for "yes"/"no" > prompts). With the typo not fixed, we might get stuck in CI jobs. > The risk is very low as we perform pre-push testing using GitLab CI to make > sure the changes will not break the pipeline. I have no objection to take this patch for 4.17, so as long as you have the R-b or ack from CI maintainers, you can have my release ack. Kind regards, Henry
> On 27 Sep 2022, at 10:47, Michal Orzel <michal.orzel@amd.com> wrote: > > The correct variable name is DEBIAN_FRONTEND and not DEBIAN_FRONTENT. > > Signed-off-by: Michal Orzel <michal.orzel@amd.com> > --- > CC: Henry Wang <Henry.Wang@arm.com> > > Rationale for taking this patch for 4.17: > Setting DEBIAN_FRONTEND to noninteractive menas that we need zero interaction > while installing/upgrading the system via apt-get. It accepts the default > answer to all the questions (using apt-get -y only works for "yes"/"no" > prompts). With the typo not fixed, we might get stuck in CI jobs. > The risk is very low as we perform pre-push testing using GitLab CI to make > sure the changes will not break the pipeline. > > Changes in v3: > - new patch > --- Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
On Tue, 27 Sep 2022, Michal Orzel wrote: > The correct variable name is DEBIAN_FRONTEND and not DEBIAN_FRONTENT. > > Signed-off-by: Michal Orzel <michal.orzel@amd.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> and committed > --- > CC: Henry Wang <Henry.Wang@arm.com> > > Rationale for taking this patch for 4.17: > Setting DEBIAN_FRONTEND to noninteractive menas that we need zero interaction > while installing/upgrading the system via apt-get. It accepts the default > answer to all the questions (using apt-get -y only works for "yes"/"no" > prompts). With the typo not fixed, we might get stuck in CI jobs. > The risk is very low as we perform pre-push testing using GitLab CI to make > sure the changes will not break the pipeline. > > Changes in v3: > - new patch > --- > automation/scripts/qemu-smoke-arm32.sh | 2 +- > automation/scripts/qemu-smoke-arm64.sh | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh > index 530f3892fdd3..c8ae0bfb9b1c 100755 > --- a/automation/scripts/qemu-smoke-arm32.sh > +++ b/automation/scripts/qemu-smoke-arm32.sh > @@ -2,7 +2,7 @@ > > set -ex > > -export DEBIAN_FRONTENT=noninteractive > +export DEBIAN_FRONTEND=noninteractive > apt-get -qy update > apt-get -qy install --no-install-recommends device-tree-compiler \ > curl \ > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index f803835779f4..5b566072f72a 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -38,7 +38,7 @@ fi > " > fi > > -export DEBIAN_FRONTENT=noninteractive > +export DEBIAN_FRONTEND=noninteractive > apt-get -qy update > apt-get -qy install --no-install-recommends u-boot-qemu \ > u-boot-tools \ > -- > 2.25.1 >
diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh index 530f3892fdd3..c8ae0bfb9b1c 100755 --- a/automation/scripts/qemu-smoke-arm32.sh +++ b/automation/scripts/qemu-smoke-arm32.sh @@ -2,7 +2,7 @@ set -ex -export DEBIAN_FRONTENT=noninteractive +export DEBIAN_FRONTEND=noninteractive apt-get -qy update apt-get -qy install --no-install-recommends device-tree-compiler \ curl \ diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index f803835779f4..5b566072f72a 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -38,7 +38,7 @@ fi " fi -export DEBIAN_FRONTENT=noninteractive +export DEBIAN_FRONTEND=noninteractive apt-get -qy update apt-get -qy install --no-install-recommends u-boot-qemu \ u-boot-tools \
The correct variable name is DEBIAN_FRONTEND and not DEBIAN_FRONTENT. Signed-off-by: Michal Orzel <michal.orzel@amd.com> --- CC: Henry Wang <Henry.Wang@arm.com> Rationale for taking this patch for 4.17: Setting DEBIAN_FRONTEND to noninteractive menas that we need zero interaction while installing/upgrading the system via apt-get. It accepts the default answer to all the questions (using apt-get -y only works for "yes"/"no" prompts). With the typo not fixed, we might get stuck in CI jobs. The risk is very low as we perform pre-push testing using GitLab CI to make sure the changes will not break the pipeline. Changes in v3: - new patch --- automation/scripts/qemu-smoke-arm32.sh | 2 +- automation/scripts/qemu-smoke-arm64.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)