| Message ID | 20220927122913.2642497-1-waynec@nvidia.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/1] usb: typec: ucsi: Don't warn on probe deferral | expand |
On Tue, Sep 27, 2022 at 08:29:13PM +0800, Wayne Chang wrote: > Deferred probe is an expected return value for fwnode_usb_role_switch_get(). > Given that the driver deals with it properly, there's no need to output a > warning that may potentially confuse users. > > Fixes: 3c162511530c ("usb: typec: ucsi: Wait for the USB role switches") > Cc: stable@vger.kernel.org Why is this a bugfix that needs to be backported? The current code works the same as what you are changing it to be, there's no functional difference, right? thanks, greg k-h
Hi Greg, Thanks for the review. On 9/27/22 20:40, Greg KH wrote: > External email: Use caution opening links or attachments > > > On Tue, Sep 27, 2022 at 08:29:13PM +0800, Wayne Chang wrote: >> Deferred probe is an expected return value for fwnode_usb_role_switch_get(). >> Given that the driver deals with it properly, there's no need to output a >> warning that may potentially confuse users. >> >> Fixes: 3c162511530c ("usb: typec: ucsi: Wait for the USB role switches") >> Cc: stable@vger.kernel.org > > Why is this a bugfix that needs to be backported? The current code > works the same as what you are changing it to be, there's no functional > difference, right? > > thanks, > > greg k-h > Yes, there's no functional difference but clears probe deferral warnings. I'll send v3 to remove them. thanks, Wayne.
diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index 7f2624f42724..e961ebecd7df 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -1069,11 +1069,9 @@ static int ucsi_register_port(struct ucsi *ucsi, int index) cap->fwnode = ucsi_find_fwnode(con); con->usb_role_sw = fwnode_usb_role_switch_get(cap->fwnode); - if (IS_ERR(con->usb_role_sw)) { - dev_err(ucsi->dev, "con%d: failed to get usb role switch\n", - con->num); - return PTR_ERR(con->usb_role_sw); - } + if (IS_ERR(con->usb_role_sw)) + return dev_err_probe(ucsi->dev, PTR_ERR(con->usb_role_sw), + "con%d: failed to get usb role switch\n", con->num); /* Delay other interactions with the con until registration is complete */ mutex_lock(&con->lock);
Deferred probe is an expected return value for fwnode_usb_role_switch_get(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users. Fixes: 3c162511530c ("usb: typec: ucsi: Wait for the USB role switches") Cc: stable@vger.kernel.org Signed-off-by: Wayne Chang <waynec@nvidia.com> --- V1 -> V2: adjust the coding style for better reading format. drivers/usb/typec/ucsi/ucsi.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)