mbox series

[net-next,0/2] Add helper functions to parse netlink msg of ip_tunnel

Message ID 20220926131944.137094-1-liujian56@huawei.com (mailing list archive)
Headers show
Series Add helper functions to parse netlink msg of ip_tunnel | expand

Message

liujian (CE) Sept. 26, 2022, 1:19 p.m. UTC 
Add helper functions to parse netlinkmsg of ip_tunnel

Liu Jian (2):
  net: Add helper function to parse netlink msg of ip_tunnel_encap
  net: Add helper function to parse netlink msg of ip_tunnel_parm

 include/net/ip_tunnels.h | 66 ++++++++++++++++++++++++++++++++++++++++
 net/ipv4/ipip.c          | 62 ++-----------------------------------
 net/ipv6/ip6_tunnel.c    | 37 ++--------------------
 net/ipv6/sit.c           | 65 ++-------------------------------------
 4 files changed, 74 insertions(+), 156 deletions(-)

Comments

Jakub Kicinski Sept. 27, 2022, 2:58 p.m. UTC | #1 
On Mon, 26 Sep 2022 21:19:42 +0800 Liu Jian wrote:
> Add helper functions to parse netlinkmsg of ip_tunnel
> 
> Liu Jian (2):
>   net: Add helper function to parse netlink msg of ip_tunnel_encap
>   net: Add helper function to parse netlink msg of ip_tunnel_parm
> 
>  include/net/ip_tunnels.h | 66 ++++++++++++++++++++++++++++++++++++++++
>  net/ipv4/ipip.c          | 62 ++-----------------------------------
>  net/ipv6/ip6_tunnel.c    | 37 ++--------------------
>  net/ipv6/sit.c           | 65 ++-------------------------------------

Do they need to be in a header file? Could you put them in
net/ipv4/ip_tunnel.c or net/ipv4/ip_tunnel_core.c instead?
liujian (CE) Sept. 28, 2022, 3:34 a.m. UTC | #2 
> -----Original Message-----
> From: Jakub Kicinski [mailto:kuba@kernel.org]
> Sent: Tuesday, September 27, 2022 10:59 PM
> To: liujian (CE) <liujian56@huawei.com>
> Cc: davem@davemloft.net; yoshfuji@linux-ipv6.org; dsahern@kernel.org;
> edumazet@google.com; pabeni@redhat.com; netdev@vger.kernel.org
> Subject: Re: [PATCH net-next 0/2] Add helper functions to parse netlink msg
> of ip_tunnel
> 
> On Mon, 26 Sep 2022 21:19:42 +0800 Liu Jian wrote:
> > Add helper functions to parse netlinkmsg of ip_tunnel
> >
> > Liu Jian (2):
> >   net: Add helper function to parse netlink msg of ip_tunnel_encap
> >   net: Add helper function to parse netlink msg of ip_tunnel_parm
> >
> >  include/net/ip_tunnels.h | 66
> ++++++++++++++++++++++++++++++++++++++++
> >  net/ipv4/ipip.c          | 62 ++-----------------------------------
> >  net/ipv6/ip6_tunnel.c    | 37 ++--------------------
> >  net/ipv6/sit.c           | 65 ++-------------------------------------
> 
> Do they need to be in a header file? Could you put them in
> net/ipv4/ip_tunnel.c or net/ipv4/ip_tunnel_core.c instead?
The v2 version has been sent. Thanks for your review.