| Message ID | 20220928031628.6463-2-zhuyinbo@loongson.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/3] MAINTAINERS: add maintainer for thermal driver for loongson2 SoCs | expand |
On 28/09/2022 05:16, Yinbo Zhu wrote: > Add the loongson2k thermal binding with DT schema format using > json-schema. > > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> Thank you for your patch. There is something to discuss/improve. > +$id: http://devicetree.org/schemas/thermal/loongson,ls2k-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Thermal sensors on loongson2k SoCs > + > +maintainers: > + - zhanghongchen <zhanghongchen@loongson.cn> > + - Yinbo Zhu <zhuyinbo@loongson.cn> > + > +properties: > + compatible: > + const: loongson,ls2k-thermal > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + "#thermal-sensor-cells": Use same quotes in all places - either ' or " > + const: 1> + > +required: > + - compatible > + - reg > + - interrupts > + - '#thermal-sensor-cells' With quotes fixed: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
在 2022/9/28 下午4:01, Krzysztof Kozlowski 写道: > On 28/09/2022 05:16, Yinbo Zhu wrote: >> Add the loongson2k thermal binding with DT schema format using >> json-schema. >> >> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> > > Thank you for your patch. There is something to discuss/improve. > >> +$id: http://devicetree.org/schemas/thermal/loongson,ls2k-thermal.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Thermal sensors on loongson2k SoCs >> + >> +maintainers: >> + - zhanghongchen <zhanghongchen@loongson.cn> >> + - Yinbo Zhu <zhuyinbo@loongson.cn> >> + >> +properties: >> + compatible: >> + const: loongson,ls2k-thermal >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + "#thermal-sensor-cells": > > Use same quotes in all places - either ' or " Thanks for reminding me, I will fix it. > >> + const: 1> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - '#thermal-sensor-cells' > > With quotes fixed: I will use "'" uniformly. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml new file mode 100644 index 000000000000..68324ca50daa --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/loongson,ls2k-thermal.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Thermal sensors on loongson2k SoCs + +maintainers: + - zhanghongchen <zhanghongchen@loongson.cn> + - Yinbo Zhu <zhuyinbo@loongson.cn> + +properties: + compatible: + const: loongson,ls2k-thermal + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + "#thermal-sensor-cells": + const: 1 + +required: + - compatible + - reg + - interrupts + - '#thermal-sensor-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + thermal: thermal-sensor@1fe01500 { + compatible = "loongson,ls2k-thermal"; + reg = <0 0x1fe01500 0 0x30>; + interrupt-parent = <&liointc0>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; + #thermal-sensor-cells = <1>; + };
Add the loongson2k thermal binding with DT schema format using json-schema. Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> --- Change in v4: 1. Fixup the compatible. 2. Update the binding file name. 3. Include irq.h to fix compile issue. .../thermal/loongson,ls2k-thermal.yaml | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml