| Message ID | 20220922113347.144383-2-sergiu.moga@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Make atmel serial driver aware of GCLK | expand |
On Thu, 22 Sep 2022, Sergiu Moga wrote: > Another functionality of FLEXCOM is that of SPI. In order for > the proper validation of the SPI children nodes through the binding > to occur, the proper binding for SPI must be referenced. > > Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > > > v1 -> v2: > - use full schema paths > > > v2 -> v3: > - Added Reviewed-by tag, previously this was [PATCH 3] > > > v3 -> v4: > - Nothing, previously this was [PATCH 5] > > > v4 -> v5: > - Nothing > > > > .../devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Not sure how these can be handled. I guess I cannot take these until the other patches are applied. NB: The patch doesn't apply cleanly anyway, so will need to be rebased. > diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > index 0c80f4e98c54..f283cfd84b2d 100644 > --- a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > @@ -78,10 +78,9 @@ patternProperties: > of USART bindings. > > "^spi@[0-9a-f]+$": > - type: object > + $ref: /schemas/spi/atmel,at91rm9200-spi.yaml > description: > - Child node describing SPI. See ../spi/spi_atmel.txt for details > - of SPI bindings. > + Child node describing SPI. > > "^i2c@[0-9a-f]+$": > $ref: /schemas/i2c/atmel,at91sam-i2c.yaml
On 28.09.2022 18:03, Lee Jones wrote: > On Thu, 22 Sep 2022, Sergiu Moga wrote: > >> Another functionality of FLEXCOM is that of SPI. In order for >> the proper validation of the SPI children nodes through the binding >> to occur, the proper binding for SPI must be referenced. >> >> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> >> >> v1 -> v2: >> - use full schema paths >> >> >> v2 -> v3: >> - Added Reviewed-by tag, previously this was [PATCH 3] >> >> >> v3 -> v4: >> - Nothing, previously this was [PATCH 5] >> >> >> v4 -> v5: >> - Nothing >> >> >> >> .../devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) > > Not sure how these can be handled. > > I guess I cannot take these until the other patches are applied. > > NB: The patch doesn't apply cleanly anyway, so will need to be rebased. > Hello, The sama5d2-flexcom binding related patches are dependent on: https://lore.kernel.org/linux-arm-kernel/20220916075744.1879428-1-kavyasree.kotagiri@microchip.com/ as specified in the cover letter. Regards, Sergiu >> diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml >> index 0c80f4e98c54..f283cfd84b2d 100644 >> --- a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml >> +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml >> @@ -78,10 +78,9 @@ patternProperties: >> of USART bindings. >> >> "^spi@[0-9a-f]+$": >> - type: object >> + $ref: /schemas/spi/atmel,at91rm9200-spi.yaml >> description: >> - Child node describing SPI. See ../spi/spi_atmel.txt for details >> - of SPI bindings. >> + Child node describing SPI. >> >> "^i2c@[0-9a-f]+$": >> $ref: /schemas/i2c/atmel,at91sam-i2c.yaml > > -- > Lee Jones [李琼斯]
On Wed, 28 Sep 2022, Sergiu.Moga@microchip.com wrote: > On 28.09.2022 18:03, Lee Jones wrote: > > On Thu, 22 Sep 2022, Sergiu Moga wrote: > > > >> Another functionality of FLEXCOM is that of SPI. In order for > >> the proper validation of the SPI children nodes through the binding > >> to occur, the proper binding for SPI must be referenced. > >> > >> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com> > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > >> > >> > >> v1 -> v2: > >> - use full schema paths > >> > >> > >> v2 -> v3: > >> - Added Reviewed-by tag, previously this was [PATCH 3] > >> > >> > >> v3 -> v4: > >> - Nothing, previously this was [PATCH 5] > >> > >> > >> v4 -> v5: > >> - Nothing > >> > >> > >> > >> .../devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml | 5 ++--- > >> 1 file changed, 2 insertions(+), 3 deletions(-) > > > > Not sure how these can be handled. > > > > I guess I cannot take these until the other patches are applied. > > > > NB: The patch doesn't apply cleanly anyway, so will need to be rebased. > > > > > Hello, > > The sama5d2-flexcom binding related patches are dependent on: > https://lore.kernel.org/linux-arm-kernel/20220916075744.1879428-1-kavyasree.kotagiri@microchip.com/ I would be very cautious about relying on comments made in the cover-letter. Better to make this a hard requirement and place them in the same patch-set.
On 28.09.2022 18:23, Lee Jones wrote: > On Wed, 28 Sep 2022, Sergiu.Moga@microchip.com wrote: > >> On 28.09.2022 18:03, Lee Jones wrote: >>> On Thu, 22 Sep 2022, Sergiu Moga wrote: >>> >>>> Another functionality of FLEXCOM is that of SPI. In order for >>>> the proper validation of the SPI children nodes through the binding >>>> to occur, the proper binding for SPI must be referenced. >>>> >>>> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>>> >>>> >>>> v1 -> v2: >>>> - use full schema paths >>>> >>>> >>>> v2 -> v3: >>>> - Added Reviewed-by tag, previously this was [PATCH 3] >>>> >>>> >>>> v3 -> v4: >>>> - Nothing, previously this was [PATCH 5] >>>> >>>> >>>> v4 -> v5: >>>> - Nothing >>>> >>>> >>>> >>>> .../devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml | 5 ++--- >>>> 1 file changed, 2 insertions(+), 3 deletions(-) >>> >>> Not sure how these can be handled. >>> >>> I guess I cannot take these until the other patches are applied. >>> >>> NB: The patch doesn't apply cleanly anyway, so will need to be rebased. >>> >> >> >> Hello, >> >> The sama5d2-flexcom binding related patches are dependent on: >> https://lore.kernel.org/linux-arm-kernel/20220916075744.1879428-1-kavyasree.kotagiri@microchip.com/ > > I would be very cautious about relying on comments made in the > cover-letter. Better to make this a hard requirement and place them > in the same patch-set. > > -- > Lee Jones [李琼斯] Understood, my apologies, I will keep this in mind the next time this happens :). Otherwise, by applying the patch series linked above, my sama5d2-flexcom patches should apply cleanly afterwards. Thanks, Sergiu
On Wed, 28 Sep 2022, Sergiu.Moga@microchip.com wrote: > On 28.09.2022 18:23, Lee Jones wrote: > > On Wed, 28 Sep 2022, Sergiu.Moga@microchip.com wrote: > > > >> On 28.09.2022 18:03, Lee Jones wrote: > >>> On Thu, 22 Sep 2022, Sergiu Moga wrote: > >>> > >>>> Another functionality of FLEXCOM is that of SPI. In order for > >>>> the proper validation of the SPI children nodes through the binding > >>>> to occur, the proper binding for SPI must be referenced. > >>>> > >>>> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com> > >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>>> --- > >>>> > >>>> > >>>> v1 -> v2: > >>>> - use full schema paths > >>>> > >>>> > >>>> v2 -> v3: > >>>> - Added Reviewed-by tag, previously this was [PATCH 3] > >>>> > >>>> > >>>> v3 -> v4: > >>>> - Nothing, previously this was [PATCH 5] > >>>> > >>>> > >>>> v4 -> v5: > >>>> - Nothing > >>>> > >>>> > >>>> > >>>> .../devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml | 5 ++--- > >>>> 1 file changed, 2 insertions(+), 3 deletions(-) > >>> > >>> Not sure how these can be handled. > >>> > >>> I guess I cannot take these until the other patches are applied. > >>> > >>> NB: The patch doesn't apply cleanly anyway, so will need to be rebased. > >>> > >> > >> > >> Hello, > >> > >> The sama5d2-flexcom binding related patches are dependent on: > >> https://lore.kernel.org/linux-arm-kernel/20220916075744.1879428-1-kavyasree.kotagiri@microchip.com/ > > > > I would be very cautious about relying on comments made in the > > cover-letter. Better to make this a hard requirement and place them > > in the same patch-set. > > > > > > Understood, my apologies, I will keep this in mind the next time this > happens :). > > Otherwise, by applying the patch series linked above, my sama5d2-flexcom > patches should apply cleanly afterwards. Please re-send this once the other set has been applied.
diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml index 0c80f4e98c54..f283cfd84b2d 100644 --- a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml @@ -78,10 +78,9 @@ patternProperties: of USART bindings. "^spi@[0-9a-f]+$": - type: object + $ref: /schemas/spi/atmel,at91rm9200-spi.yaml description: - Child node describing SPI. See ../spi/spi_atmel.txt for details - of SPI bindings. + Child node describing SPI. "^i2c@[0-9a-f]+$": $ref: /schemas/i2c/atmel,at91sam-i2c.yaml