| Message ID | 20220901135523.52151-1-sebastian.reichel@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] dt-bindings: pwm: rockchip: Add description for rk3588 | expand |
On 01/09/2022 16:55, Sebastian Reichel wrote: > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found > on a rk3588 platform. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Am Donnerstag, 1. September 2022, 15:55:23 CEST schrieb Sebastian Reichel: > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found > on a rk3588 platform. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > No driver changes required. > --- > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml > index a336ff9364a9..f946861e3f8a 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml > +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml > @@ -30,6 +30,7 @@ properties: > - rockchip,px30-pwm > - rockchip,rk3308-pwm > - rockchip,rk3568-pwm > + - rockchip,rk3588-pwm > - const: rockchip,rk3328-pwm > > reg: >
On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found > on a rk3588 platform. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > No driver changes required. > --- > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > 1 file changed, 1 insertion(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ pwm@10280000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@10280010: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@10280020: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@10280030: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@20040000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@20040010: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@20040020: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@20040030: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@ff1b0030: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/rockchip/rk3318-a95x-z2.dtb arch/arm64/boot/dts/rockchip/rk3328-a1.dtb arch/arm64/boot/dts/rockchip/rk3328-evb.dtb arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dtb arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dtb arch/arm64/boot/dts/rockchip/rk3328-rock64.dtb arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtb arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dtb
Hello Rob, On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote: > On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: > > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found > > on a rk3588 platform. > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > --- > > No driver changes required. > > --- > > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. Is this a list of *new* warnings, or is the report (somewhat) orthogonal to the actual change and you just used the opportunity that someone touched the pwm-rockchip binding to point out that there is some cleanup to do? > Full log is available here: https://patchwork.ozlabs.org/patch/ Hm, that gives me a 404. Best regards Uwe
Hi, On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote: > Hello Rob, > > On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote: > > On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: > > > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found > > > on a rk3588 platform. > > > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > > --- > > > No driver changes required. > > > --- > > > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > Is this a list of *new* warnings, or is the report (somewhat) orthogonal > to the actual change and you just used the opportunity that someone > touched the pwm-rockchip binding to point out that there is some cleanup > to do? > > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > Hm, that gives me a 404. This is an existing problem with the rv1108 binding. The rk3588 does not have pwm interrupts. -- Sebastian
On Tue, Sep 13, 2022 at 04:16:01PM +0200, Sebastian Reichel wrote: > Hi, > > On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote: > > Hello Rob, > > > > On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote: > > > On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: > > > > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found > > > > on a rk3588 platform. > > > > > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > > > --- > > > > No driver changes required. > > > > --- > > > > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > > following warnings. Consider if they are expected or the schema is > > > incorrect. These may not be new warnings. > > > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > > This will change in the future. > > > > Is this a list of *new* warnings, or is the report (somewhat) orthogonal > > to the actual change and you just used the opportunity that someone > > touched the pwm-rockchip binding to point out that there is some cleanup > > to do? > > > > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > > Hm, that gives me a 404. > > This is an existing problem with the rv1108 binding. > The rk3588 does not have pwm interrupts. I thought so, so: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
On Tue, Sep 13, 2022 at 04:16:01PM +0200, Sebastian Reichel wrote: > Hi, > > On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote: > > Hello Rob, > > > > On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote: > > > On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: > > > > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found > > > > on a rk3588 platform. > > > > > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > > > --- > > > > No driver changes required. > > > > --- > > > > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > > following warnings. Consider if they are expected or the schema is > > > incorrect. These may not be new warnings. > > > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > > This will change in the future. > > > > Is this a list of *new* warnings, or is the report (somewhat) orthogonal > > to the actual change and you just used the opportunity that someone > > touched the pwm-rockchip binding to point out that there is some cleanup > > to do? > > > > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > > Hm, that gives me a 404. > > This is an existing problem with the rv1108 binding. > The rk3588 does not have pwm interrupts. Can somebody go and fix that, then? Thierry
Hi, On Wed, Sep 28, 2022 at 01:48:29PM +0200, Thierry Reding wrote: > On Tue, Sep 13, 2022 at 04:16:01PM +0200, Sebastian Reichel wrote: > > Hi, > > > > On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote: > > > Hello Rob, > > > > > > On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote: > > > > On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: > > > > > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found > > > > > on a rk3588 platform. > > > > > > > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > > > > --- > > > > > No driver changes required. > > > > > --- > > > > > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > > > following warnings. Consider if they are expected or the schema is > > > > incorrect. These may not be new warnings. > > > > > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > > > This will change in the future. > > > > > > Is this a list of *new* warnings, or is the report (somewhat) orthogonal > > > to the actual change and you just used the opportunity that someone > > > touched the pwm-rockchip binding to point out that there is some cleanup > > > to do? > > > > > > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > > > > Hm, that gives me a 404. > > > > This is an existing problem with the rv1108 binding. > > The rk3588 does not have pwm interrupts. > > Can somebody go and fix that, then? I assume this will be taken care of with the rk3128 patchset, since that is affected anyways: https://lore.kernel.org/linux-pwm/f5dd0ee4-d97e-d878-ffde-c06e9b233e38@gmail.com/ -- Sebastian
On Wed, Sep 28, 2022 at 03:06:34PM +0200, Sebastian Reichel wrote: > Hi, > > On Wed, Sep 28, 2022 at 01:48:29PM +0200, Thierry Reding wrote: > > On Tue, Sep 13, 2022 at 04:16:01PM +0200, Sebastian Reichel wrote: > > > Hi, > > > > > > On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote: > > > > Hello Rob, > > > > > > > > On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote: > > > > > On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: > > > > > > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found > > > > > > on a rk3588 platform. > > > > > > > > > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > > > > > --- > > > > > > No driver changes required. > > > > > > --- > > > > > > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > > > > following warnings. Consider if they are expected or the schema is > > > > > incorrect. These may not be new warnings. > > > > > > > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > > > > This will change in the future. > > > > > > > > Is this a list of *new* warnings, or is the report (somewhat) orthogonal > > > > to the actual change and you just used the opportunity that someone > > > > touched the pwm-rockchip binding to point out that there is some cleanup > > > > to do? > > > > > > > > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > > > > > > Hm, that gives me a 404. > > > > > > This is an existing problem with the rv1108 binding. > > > The rk3588 does not have pwm interrupts. > > > > Can somebody go and fix that, then? > > I assume this will be taken care of with the rk3128 patchset, since > that is affected anyways: > > https://lore.kernel.org/linux-pwm/f5dd0ee4-d97e-d878-ffde-c06e9b233e38@gmail.com/ That patch is already acked and I've pulled it in, so better make it a separate patch. The point I was trying to make is that somebody needs to fix this, otherwise the automated checks are not going to be useful. So saying things like "this is an existing problem and the new compatible is not affected" is not helpful. Thierry
On 9/28/22 15:56, Thierry Reding wrote: > On Wed, Sep 28, 2022 at 03:06:34PM +0200, Sebastian Reichel wrote: >> Hi, >> >> On Wed, Sep 28, 2022 at 01:48:29PM +0200, Thierry Reding wrote: >>> On Tue, Sep 13, 2022 at 04:16:01PM +0200, Sebastian Reichel wrote: >>>> Hi, >>>> >>>> On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote: >>>>> Hello Rob, >>>>> >>>>> On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote: >>>>>> On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: >>>>>>> Add "rockchip,rk3588-pwm" compatible string for PWM nodes found >>>>>>> on a rk3588 platform. >>>>>>> >>>>>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> >>>>>>> --- >>>>>>> No driver changes required. >>>>>>> --- >>>>>>> Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + >>>>>>> 1 file changed, 1 insertion(+) >>>>>>> >>>>>> >>>>>> Running 'make dtbs_check' with the schema in this patch gives the >>>>>> following warnings. Consider if they are expected or the schema is >>>>>> incorrect. These may not be new warnings. >>>>>> >>>>>> Note that it is not yet a requirement to have 0 warnings for dtbs_check. >>>>>> This will change in the future. >>>>> >>>>> Is this a list of *new* warnings, or is the report (somewhat) orthogonal >>>>> to the actual change and you just used the opportunity that someone >>>>> touched the pwm-rockchip binding to point out that there is some cleanup >>>>> to do? >>>>> >>>>>> Full log is available here: https://patchwork.ozlabs.org/patch/ >>>>> >>>>> Hm, that gives me a 404. >>>> >>>> This is an existing problem with the rv1108 binding. >>>> The rk3588 does not have pwm interrupts. >>> I can provide DT and YAML changes, but I pass for changes to the currently to me unknown PWM framework and missing hardware. Johan >> >> I assume this will be taken care of with the rk3128 patchset, since >> that is affected anyways: >> >> https://lore.kernel.org/linux-pwm/f5dd0ee4-d97e-d878-ffde-c06e9b233e38@gmail.com/ > > That patch is already acked and I've pulled it in, so better make it a > separate patch. > > The point I was trying to make is that somebody needs to fix this, > otherwise the automated checks are not going to be useful. So saying > things like "this is an existing problem and the new compatible is not > affected" is not helpful. > > Thierry > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hi, On Wed, Sep 28, 2022 at 03:56:52PM +0200, Thierry Reding wrote: > On Wed, Sep 28, 2022 at 03:06:34PM +0200, Sebastian Reichel wrote: > > Hi, > > > > On Wed, Sep 28, 2022 at 01:48:29PM +0200, Thierry Reding wrote: > > > On Tue, Sep 13, 2022 at 04:16:01PM +0200, Sebastian Reichel wrote: > > > > Hi, > > > > > > > > On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote: > > > > > Hello Rob, > > > > > > > > > > On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote: > > > > > > On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: > > > > > > > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found > > > > > > > on a rk3588 platform. > > > > > > > > > > > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > > > > > > --- > > > > > > > No driver changes required. > > > > > > > --- > > > > > > > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > > > > > following warnings. Consider if they are expected or the schema is > > > > > > incorrect. These may not be new warnings. > > > > > > > > > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > > > > > This will change in the future. > > > > > > > > > > Is this a list of *new* warnings, or is the report (somewhat) orthogonal > > > > > to the actual change and you just used the opportunity that someone > > > > > touched the pwm-rockchip binding to point out that there is some cleanup > > > > > to do? > > > > > > > > > > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > > > > > > > > Hm, that gives me a 404. > > > > > > > > This is an existing problem with the rv1108 binding. > > > > The rk3588 does not have pwm interrupts. > > > > > > Can somebody go and fix that, then? > > > > I assume this will be taken care of with the rk3128 patchset, since > > that is affected anyways: > > > > https://lore.kernel.org/linux-pwm/f5dd0ee4-d97e-d878-ffde-c06e9b233e38@gmail.com/ > > That patch is already acked and I've pulled it in, so better make it a > separate patch. > > The point I was trying to make is that somebody needs to fix this, > otherwise the automated checks are not going to be useful. So saying > things like "this is an existing problem and the new compatible is not > affected" is not helpful. The point I'm making is: I do not have that hardware. I only have rk3588, which has no interrupts and I don't know anything about rv1108. Based on the driver and the bindings I would just remove the interrupts from DT; but I can't do any testing beyond compile testing. -- Sebastian
On 9/13/22 16:16, Sebastian Reichel wrote: > Hi, > > On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote: >> Hello Rob, >> >> On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote: >>> On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: >>>> Add "rockchip,rk3588-pwm" compatible string for PWM nodes found >>>> on a rk3588 platform. >>>> >>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> >>>> --- >>>> No driver changes required. >>>> --- >>>> Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>> >>> Running 'make dtbs_check' with the schema in this patch gives the >>> following warnings. Consider if they are expected or the schema is >>> incorrect. These may not be new warnings. >>> >>> Note that it is not yet a requirement to have 0 warnings for dtbs_check. >>> This will change in the future. >> >> Is this a list of *new* warnings, or is the report (somewhat) orthogonal >> to the actual change and you just used the opportunity that someone >> touched the pwm-rockchip binding to point out that there is some cleanup >> to do? >> >>> Full log is available here: https://patchwork.ozlabs.org/patch/ >> >> Hm, that gives me a 404. > > This is an existing problem with the rv1108 binding. > The rk3588 does not have pwm interrupts. Hi, Could you recheck? From Rockchip RK3588 Datasheet V0.1-20210727.pdf: PWM Support 16 on-chip PWMs(PWM0~PWM15) with interrupt-based operation Programmable pre-scaled operation to bus clock and then further scaled Embedded 32-bit timer/counter facility Support capture mode Support continuous mode or one-shot mode Provides reference mode and output various duty-cycle waveform Optimized for IR application for PWM3, PWM7, PWM11, PWM15 === ARM: dts: rk3288: add the interrupts property for PWM https://github.com/rockchip-linux/kernel/commit/16b7b284618d1652e694f6286f575ce82f5f03e5 Comment: At the moment, we can find the remotectl pwm is needed on box. We can add the property for all PWMs. AFAIK, the pwm driver don't use it but the drivers/input/remotectl/rockchip_pwm_remotectl.c === From Rockchip RK3568 TRM Part1 V1.1-20210301.pdf 8-bit repeat counter for one-shot operation. One-shot operation will produce N + 1 periods of the waveform, where N is the repeat counter value, and generates a single interrupt at the end of operation Continuous mode generates the waveform continuously, and does not generates any interrupts > > -- Sebastian > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hi, On Wed, Sep 28, 2022 at 08:29:35PM +0200, Johan Jonker wrote: > On 9/13/22 16:16, Sebastian Reichel wrote: > > On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote: > >> Hello Rob, > >> > >> On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote: > >>> On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: > >>>> Add "rockchip,rk3588-pwm" compatible string for PWM nodes found > >>>> on a rk3588 platform. > >>>> > >>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > >>>> --- > >>>> No driver changes required. > >>>> --- > >>>> Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > >>>> 1 file changed, 1 insertion(+) > >>>> > >>> > >>> Running 'make dtbs_check' with the schema in this patch gives the > >>> following warnings. Consider if they are expected or the schema is > >>> incorrect. These may not be new warnings. > >>> > >>> Note that it is not yet a requirement to have 0 warnings for dtbs_check. > >>> This will change in the future. > >> > >> Is this a list of *new* warnings, or is the report (somewhat) orthogonal > >> to the actual change and you just used the opportunity that someone > >> touched the pwm-rockchip binding to point out that there is some cleanup > >> to do? > >> > >>> Full log is available here: https://patchwork.ozlabs.org/patch/ > >> > >> Hm, that gives me a 404. > > > > > This is an existing problem with the rv1108 binding. > > The rk3588 does not have pwm interrupts. > > Hi, > > Could you recheck? > > From Rockchip RK3588 Datasheet V0.1-20210727.pdf: Indeed. Looks like I missed the PWM interrupts because the list of interrupts is in two columns in the datasheet and I only looked through the first one assuming it was one long line. I should have checked this more carefully. Sorry about that. > === > ARM: dts: rk3288: add the interrupts property for PWM > https://github.com/rockchip-linux/kernel/commit/16b7b284618d1652e694f6286f575ce82f5f03e5 > > Comment: > At the moment, we can find the remotectl pwm is needed on box. > We can add the property for all PWMs. AFAIK, the pwm driver don't use it > but the drivers/input/remotectl/rockchip_pwm_remotectl.c > === rk3288 != rk3588. That's a different SoC. The downstream kernel I used is this one and does not describe the interrupts: https://github.com/radxa/kernel/tree/stable-5.10-rock5/arch/arm64/boot/dts/rockchip I suppose we have these options: 1. Remove the 'interrupts' property from any upstream rockchip DT, since they are not used by SW? They can always be properly introduced without breaking backwards compatibility. 2. Describe 'interrupts' in the DT binding as optional with description to shut up the warning and otherwise ignore the problem until somebody has code to use the interrupts. 3. Same as 2, but also add the interrupts for rk356x and rk3588 even though they are not used at the moment. 4. Describe 'interrupts' as mandatory in the DT binding for any rockchip SoC that has them and add them in DT. Considering normal PWM usage does not need them at all that seems wrong to me. -- Sebastian
diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml index a336ff9364a9..f946861e3f8a 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml @@ -30,6 +30,7 @@ properties: - rockchip,px30-pwm - rockchip,rk3308-pwm - rockchip,rk3568-pwm + - rockchip,rk3588-pwm - const: rockchip,rk3328-pwm reg:
Add "rockchip,rk3588-pwm" compatible string for PWM nodes found on a rk3588 platform. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- No driver changes required. --- Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + 1 file changed, 1 insertion(+)