Message ID | 09f0619e8038654d01588d9ad3a023485b2bd77f.1664285209.git.geert+renesas@glider.be (mailing list archive) |
---|---|
State | Accepted |
Commit | 136f4b1ec7c962ee37a787e095fd37b058d72bd3 |
Headers | show |
Series | ARM: Drop CMDLINE_* dependency on ATAGS | expand |
On Tue, 27 Sept 2022 at 15:28, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > On arm32, the configuration options to specify the kernel command line > type depend on ATAGS. However, the actual CMDLINE cofiguration option > does not depend on ATAGS, and the code that handles this is not specific > to ATAGS (see drivers/of/fdt.c:early_init_dt_scan_chosen()). > > Hence users who desire to override the kernel command line on arm32 must > enable support for ATAGS, even on a pure-DT system. Other architectures > (arm64, loongarch, microblaze, nios2, powerpc, and riscv) do not impose > such a restriction. > > Hence drop the dependency on ATAGS. > > Fixes: bd51e2f595580fb6 ("ARM: 7506/1: allow for ATAGS to be configured out when DT support is selected") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Ard Biesheuvel <ardb@kernel.org> > --- > arch/arm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index ea8adbf25651438a..68923a69b1d41188 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1599,7 +1599,6 @@ config CMDLINE > choice > prompt "Kernel command line type" if CMDLINE != "" > default CMDLINE_FROM_BOOTLOADER > - depends on ATAGS > > config CMDLINE_FROM_BOOTLOADER > bool "Use bootloader kernel arguments if available" > -- > 2.25.1 >
Hello: This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <arnd@arndb.de>: On Tue, 27 Sep 2022 15:28:26 +0200 you wrote: > On arm32, the configuration options to specify the kernel command line > type depend on ATAGS. However, the actual CMDLINE cofiguration option > does not depend on ATAGS, and the code that handles this is not specific > to ATAGS (see drivers/of/fdt.c:early_init_dt_scan_chosen()). > > Hence users who desire to override the kernel command line on arm32 must > enable support for ATAGS, even on a pure-DT system. Other architectures > (arm64, loongarch, microblaze, nios2, powerpc, and riscv) do not impose > such a restriction. > > [...] Here is the summary with links: - ARM: Drop CMDLINE_* dependency on ATAGS https://git.kernel.org/soc/soc/c/136f4b1ec7c9 You are awesome, thank you!
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index ea8adbf25651438a..68923a69b1d41188 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1599,7 +1599,6 @@ config CMDLINE choice prompt "Kernel command line type" if CMDLINE != "" default CMDLINE_FROM_BOOTLOADER - depends on ATAGS config CMDLINE_FROM_BOOTLOADER bool "Use bootloader kernel arguments if available"
On arm32, the configuration options to specify the kernel command line type depend on ATAGS. However, the actual CMDLINE cofiguration option does not depend on ATAGS, and the code that handles this is not specific to ATAGS (see drivers/of/fdt.c:early_init_dt_scan_chosen()). Hence users who desire to override the kernel command line on arm32 must enable support for ATAGS, even on a pure-DT system. Other architectures (arm64, loongarch, microblaze, nios2, powerpc, and riscv) do not impose such a restriction. Hence drop the dependency on ATAGS. Fixes: bd51e2f595580fb6 ("ARM: 7506/1: allow for ATAGS to be configured out when DT support is selected") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm/Kconfig | 1 - 1 file changed, 1 deletion(-)