| Message ID | 20220928083702.17309-2-zhuyinbo@loongson.cn (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v5,1/3] MAINTAINERS: add maintainer for thermal driver for loongson2 SoCs | expand |
On 28/09/2022 10:37, Yinbo Zhu wrote: > Add the loongson2k thermal binding with DT schema format using > json-schema. > > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 If a tag was not added on purpose, please state why and what changed. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, 28 Sep 2022 16:37:01 +0800, Yinbo Zhu wrote: > Add the loongson2k thermal binding with DT schema format using > json-schema. > > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> > --- > Change in v5: > 1. Keep use same quotes "'" in all places. > > .../thermal/loongson,ls2k-thermal.yaml | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.example.dtb: thermal-sensor@1fe01500: reg: [[0, 534779136], [0, 48]] is too long From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 28/09/2022 10:37, Krzysztof Kozlowski wrote: > On 28/09/2022 10:37, Yinbo Zhu wrote: >> Add the loongson2k thermal binding with DT schema format using >> json-schema. >> >> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 > > If a tag was not added on purpose, please state why and what changed. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> ... and please test your patches before sending :( Best regards, Krzysztof
在 2022/9/28 下午10:18, Krzysztof Kozlowski 写道: > On 28/09/2022 10:37, Krzysztof Kozlowski wrote: >> On 28/09/2022 10:37, Yinbo Zhu wrote: >>> Add the loongson2k thermal binding with DT schema format using >>> json-schema. >>> >>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> >> >> Please add Acked-by/Reviewed-by tags when posting new versions. However, >> there's no need to repost patches *only* to add the tags. The upstream >> maintainer will do that for acks received on the version they apply. >> >> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 >> >> If a tag was not added on purpose, please state why and what changed. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > ... and please test your patches before sending :( > > Best regards, > Krzysztof Hi Krzysztof, I have a function test for these three patch, that it's okay. for binding patch I have a compile test, as follow, it is okay. root@m-pc:/home/m/workspace/test/code/upstream# make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/ls2k-thermal.yaml BRs, Yinbo Zhu. >
在 2022/9/29 上午11:42, Yinbo Zhu 写道: > > > 在 2022/9/28 下午10:18, Krzysztof Kozlowski 写道: >> On 28/09/2022 10:37, Krzysztof Kozlowski wrote: >>> On 28/09/2022 10:37, Yinbo Zhu wrote: >>>> Add the loongson2k thermal binding with DT schema format using >>>> json-schema. >>>> >>>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> >>> >>> Please add Acked-by/Reviewed-by tags when posting new versions. However, >>> there's no need to repost patches *only* to add the tags. The upstream >>> maintainer will do that for acks received on the version they apply. >>> >>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 >>> >>> >>> If a tag was not added on purpose, please state why and what changed. >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> ... and please test your patches before sending :( You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ? Need fix that warning, right? >> >> Best regards, >> Krzysztof > Hi Krzysztof, > > I have a function test for these three patch, that it's okay. > for binding patch I have a compile test, as follow, it is okay. > root@m-pc:/home/m/workspace/test/code/upstream# make DT_CHECKER_FLAGS=-m > dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/ls2k-thermal.yaml > > BRs, > Yinbo Zhu. >>
On 29/09/2022 05:57, Yinbo Zhu wrote: > > > 在 2022/9/29 上午11:42, Yinbo Zhu 写道: >> >> >> 在 2022/9/28 下午10:18, Krzysztof Kozlowski 写道: >>> On 28/09/2022 10:37, Krzysztof Kozlowski wrote: >>>> On 28/09/2022 10:37, Yinbo Zhu wrote: >>>>> Add the loongson2k thermal binding with DT schema format using >>>>> json-schema. >>>>> >>>>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> >>>> >>>> Please add Acked-by/Reviewed-by tags when posting new versions. However, >>>> there's no need to repost patches *only* to add the tags. The upstream >>>> maintainer will do that for acks received on the version they apply. >>>> >>>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 >>>> >>>> >>>> If a tag was not added on purpose, please state why and what changed. >>>> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> ... and please test your patches before sending :( > You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ? > Need fix that warning, right? Yes. You said you tested it but then sent with an error... so it's not really a testing. Best regards, Krzysztof
在 2022/9/29 下午3:00, Krzysztof Kozlowski 写道: > On 29/09/2022 05:57, Yinbo Zhu wrote: >> >> >> 在 2022/9/29 上午11:42, Yinbo Zhu 写道: >>> >>> >>> 在 2022/9/28 下午10:18, Krzysztof Kozlowski 写道: >>>> On 28/09/2022 10:37, Krzysztof Kozlowski wrote: >>>>> On 28/09/2022 10:37, Yinbo Zhu wrote: >>>>>> Add the loongson2k thermal binding with DT schema format using >>>>>> json-schema. >>>>>> >>>>>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> >>>>> >>>>> Please add Acked-by/Reviewed-by tags when posting new versions. However, >>>>> there's no need to repost patches *only* to add the tags. The upstream >>>>> maintainer will do that for acks received on the version they apply. >>>>> >>>>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 >>>>> >>>>> >>>>> If a tag was not added on purpose, please state why and what changed. >>>>> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> >>>> ... and please test your patches before sending :( >> You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ? >> Need fix that warning, right? > > Yes. You said you tested it but then sent with an error... so it's not > really a testing. sorry, I did do some testing. but I think It is okay that can generate a dtb without reporting an error when compile yaml file, in fact, I ignore the warning, I will fix it in v6. > > Best regards, > Krzysztof >
On 29/09/2022 09:07, Yinbo Zhu wrote: >>>>> >>>>> ... and please test your patches before sending :( >>> You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ? >>> Need fix that warning, right? >> >> Yes. You said you tested it but then sent with an error... so it's not >> really a testing. > sorry, I did do some testing. but I think It is okay that can generate a > dtb without reporting an error when compile yaml file, in fact, I > ignore the warning, I will fix it in v6. Do you also send the code with warnings reported by GCC? Judging by number of kernel test robot reports, it could be. So just to be very, very clear: do not send any code which generates any warning. For GCC this means W=1 builds. Best regards, Krzysztof
在 2022/9/29 下午3:45, Krzysztof Kozlowski 写道: > On 29/09/2022 09:07, Yinbo Zhu wrote: >>>>>> >>>>>> ... and please test your patches before sending :( >>>> You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ? >>>> Need fix that warning, right? >>> >>> Yes. You said you tested it but then sent with an error... so it's not >>> really a testing. >> sorry, I did do some testing. but I think It is okay that can generate a >> dtb without reporting an error when compile yaml file, in fact, I >> ignore the warning, I will fix it in v6. > > > Do you also send the code with warnings reported by GCC? Judging by > number of kernel test robot reports, it could be. So just to be very, > very clear: do not send any code which generates any warning. For GCC > this means W=1 builds. I don't find about the warning about GCC when compile yaml file. and I dont't know the meaning about W=1, you said about "W=1" is to execute following command to compile the yaml, right? root@m-pc:/home/m/workspace/test/code/upstream# make DT_CHECKER_FLAGS=-m dt_binding_check W=1 DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml I compile it use v6 patch that compile result as follows: root@m-pc:/home/m/workspace/test/code/upstream# make DT_CHECKER_FLAGS=-m dt_binding_check W=1 DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml DTC Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.example.dtb CHECK Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.example.dtb In addtion, if you said was about loongson2_thermal.c, this code has no warning that I had check. BRs, Yinbo Zhu. > > Best regards, > Krzysztof >
On 29/09/2022 10:23, Yinbo Zhu wrote: > > > 在 2022/9/29 下午3:45, Krzysztof Kozlowski 写道: >> On 29/09/2022 09:07, Yinbo Zhu wrote: >>>>>>> >>>>>>> ... and please test your patches before sending :( >>>>> You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ? >>>>> Need fix that warning, right? >>>> >>>> Yes. You said you tested it but then sent with an error... so it's not >>>> really a testing. >>> sorry, I did do some testing. but I think It is okay that can generate a >>> dtb without reporting an error when compile yaml file, in fact, I >>> ignore the warning, I will fix it in v6. >> >> >> Do you also send the code with warnings reported by GCC? Judging by >> number of kernel test robot reports, it could be. So just to be very, >> very clear: do not send any code which generates any warning. For GCC >> this means W=1 builds. > I don't find about the warning about GCC when compile yaml file. > and I dont't know the meaning about W=1, you said about "W=1" is to execute > following command to compile the yaml, right? GCC is about your C code. You were sending patches knowing that they have warnings. It's not good. All warnings must be fixed. Best regards, Krzysztof
在 2022/9/29 下午5:04, Krzysztof Kozlowski 写道: > On 29/09/2022 10:23, Yinbo Zhu wrote: >> >> >> 在 2022/9/29 下午3:45, Krzysztof Kozlowski 写道: >>> On 29/09/2022 09:07, Yinbo Zhu wrote: >>>>>>>> >>>>>>>> ... and please test your patches before sending :( >>>>>> You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ? >>>>>> Need fix that warning, right? >>>>> >>>>> Yes. You said you tested it but then sent with an error... so it's not >>>>> really a testing. >>>> sorry, I did do some testing. but I think It is okay that can generate a >>>> dtb without reporting an error when compile yaml file, in fact, I >>>> ignore the warning, I will fix it in v6. >>> >>> >>> Do you also send the code with warnings reported by GCC? Judging by >>> number of kernel test robot reports, it could be. So just to be very, >>> very clear: do not send any code which generates any warning. For GCC >>> this means W=1 builds. >> I don't find about the warning about GCC when compile yaml file. >> and I dont't know the meaning about W=1, you said about "W=1" is to execute >> following command to compile the yaml, right? > > GCC is about your C code. You were sending patches knowing that they > have warnings. It's not good. All warnings must be fixed. what you said about C code warning whether is follows ? If is it, and I had add a static for loongson2_thermal_remove in v3 version code, I think it shoud be fixed about the warning. >> drivers/thermal/loongson2_thermal.c:183:5: warning: no previous prototype for function 'loongson2_thermal_remove' [-Wmissing-prototypes] int loongson2_thermal_remove(struct platform_device *pdev) ^ drivers/thermal/loongson2_thermal.c:183:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int loongson2_thermal_remove(struct platform_device *pdev) ^ static 1 warning generated. If you said about C code warning isn't about about "loongson2_thermal_remove" and I may be loss a mail about that C code warning, Could you foward a mail about that C code warning. because I don't find any C code warning when compile C code. About the C code warning, it was base on v6 code? TKs, Yinbo Zhu. > > Best regards, > Krzysztof >
在 2022/9/29 下午3:45, Krzysztof Kozlowski 写道: > On 29/09/2022 09:07, Yinbo Zhu wrote: >>>>>> >>>>>> ... and please test your patches before sending :( >>>> You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ? >>>> Need fix that warning, right? >>> >>> Yes. You said you tested it but then sent with an error... so it's not >>> really a testing. >> sorry, I did do some testing. but I think It is okay that can generate a >> dtb without reporting an error when compile yaml file, in fact, I >> ignore the warning, I will fix it in v6. > > > Do you also send the code with warnings reported by GCC? Judging by > number of kernel test robot reports, it could be. So just to be very, > very clear: do not send any code which generates any warning. For GCC > this means W=1 builds. When use W=1, I can reproduce the warning and I will fix it in v7. BRs, Yinbo Zhu. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml new file mode 100644 index 000000000000..3fb841797771 --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/loongson,ls2k-thermal.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Thermal sensors on loongson2k SoCs + +maintainers: + - zhanghongchen <zhanghongchen@loongson.cn> + - Yinbo Zhu <zhuyinbo@loongson.cn> + +properties: + compatible: + const: loongson,ls2k-thermal + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + '#thermal-sensor-cells': + const: 1 + +required: + - compatible + - reg + - interrupts + - '#thermal-sensor-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + thermal: thermal-sensor@1fe01500 { + compatible = "loongson,ls2k-thermal"; + reg = <0 0x1fe01500 0 0x30>; + interrupt-parent = <&liointc0>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; + #thermal-sensor-cells = <1>; + };
Add the loongson2k thermal binding with DT schema format using json-schema. Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> --- Change in v5: 1. Keep use same quotes "'" in all places. .../thermal/loongson,ls2k-thermal.yaml | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml