| Message ID | 20220902202248.3061262-1-dlatypov@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cb8a7d5340a3b1ad3f9099f9fbd7fa4e2309e83b |
| Delegated to: | Brendan Higgins |
| Headers | show |
| Series | [1/2] kunit: tool: remove UML specific options from all_tests_uml.config | expand |
On Sat, Sep 3, 2022 at 4:22 AM Daniel Latypov <dlatypov@google.com> wrote: > > Commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML") > made it so we enable these options by default for UML. > Specifying them here is now redundant. > > Signed-off-by: Daniel Latypov <dlatypov@google.com> > --- Looks good to me, thanks! Reviewed-by: David Gow <davidgow@google.com> Cheers, -- David > tools/testing/kunit/configs/all_tests_uml.config | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/testing/kunit/configs/all_tests_uml.config b/tools/testing/kunit/configs/all_tests_uml.config > index bdee36bef4a3..f990cbb73250 100644 > --- a/tools/testing/kunit/configs/all_tests_uml.config > +++ b/tools/testing/kunit/configs/all_tests_uml.config > @@ -16,8 +16,6 @@ CONFIG_EXT4_FS=y > CONFIG_MSDOS_FS=y > CONFIG_VFAT_FS=y > > -CONFIG_VIRTIO_UML=y > -CONFIG_UML_PCI_OVER_VIRTIO=y > CONFIG_PCI=y > CONFIG_USB4=y > > > base-commit: 0b3acd1cc0222953035d18176b1e4aa06624fd6e > -- > 2.37.2.789.g6183377224-goog >
diff --git a/tools/testing/kunit/configs/all_tests_uml.config b/tools/testing/kunit/configs/all_tests_uml.config index bdee36bef4a3..f990cbb73250 100644 --- a/tools/testing/kunit/configs/all_tests_uml.config +++ b/tools/testing/kunit/configs/all_tests_uml.config @@ -16,8 +16,6 @@ CONFIG_EXT4_FS=y CONFIG_MSDOS_FS=y CONFIG_VFAT_FS=y -CONFIG_VIRTIO_UML=y -CONFIG_UML_PCI_OVER_VIRTIO=y CONFIG_PCI=y CONFIG_USB4=y
Commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML") made it so we enable these options by default for UML. Specifying them here is now redundant. Signed-off-by: Daniel Latypov <dlatypov@google.com> --- tools/testing/kunit/configs/all_tests_uml.config | 2 -- 1 file changed, 2 deletions(-) base-commit: 0b3acd1cc0222953035d18176b1e4aa06624fd6e