diff mbox series

[-next] scsi: ufs: Remove redundant dev_err call

Message ID 20220923101217.18345-1-shangxiaojing@huawei.com (mailing list archive)
State Accepted
Headers show
Series [-next] scsi: ufs: Remove redundant dev_err call | expand

Commit Message

Shang XiaoJing Sept. 23, 2022, 10:12 a.m. UTC
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.

Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
---
 drivers/ufs/host/ufs-qcom-ice.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Bart Van Assche Sept. 30, 2022, 6:06 p.m. UTC | #1
On 9/23/22 03:12, Shang XiaoJing wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Martin K. Petersen Oct. 1, 2022, 9:29 a.m. UTC | #2
Shang,

> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.

Applied to 6.1/scsi-staging, thanks!
diff mbox series

Patch

diff --git a/drivers/ufs/host/ufs-qcom-ice.c b/drivers/ufs/host/ufs-qcom-ice.c
index 745e48ec598f..62387ccd5b30 100644
--- a/drivers/ufs/host/ufs-qcom-ice.c
+++ b/drivers/ufs/host/ufs-qcom-ice.c
@@ -118,7 +118,6 @@  int ufs_qcom_ice_init(struct ufs_qcom_host *host)
 	host->ice_mmio = devm_ioremap_resource(dev, res);
 	if (IS_ERR(host->ice_mmio)) {
 		err = PTR_ERR(host->ice_mmio);
-		dev_err(dev, "Failed to map ICE registers; err=%d\n", err);
 		return err;
 	}