| Message ID | 20221001030752.14486-1-irui.wang@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: mediatek: vcodec: Add the platform compatible to schema | expand |
On 01/10/2022 05:07, Irui Wang wrote: > There are venc node warnings when running dtbs_check, the clock-names > was unexpected, missing properties '#address-cells' and '#size-cells'. > Add the corresponding platform compatible to schema. > > Signed-off-by: Irui Wang <irui.wang@mediatek.com> > --- > .../bindings/media/mediatek,vcodec-encoder.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sat, 01 Oct 2022 11:07:52 +0800, Irui Wang wrote: > There are venc node warnings when running dtbs_check, the clock-names > was unexpected, missing properties '#address-cells' and '#size-cells'. > Add the corresponding platform compatible to schema. > > Signed-off-by: Irui Wang <irui.wang@mediatek.com> > --- > .../bindings/media/mediatek,vcodec-encoder.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ vcodec@17020000: clock-names:0: 'venc_sel' was expected arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dtb arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dtb arch/arm64/boot/dts/mediatek/mt8192-evb.dtb
Dear Rob, Thanks for your reviewing. On Mon, 2022-10-03 at 08:24 -0500, Rob Herring wrote: > On Sat, 01 Oct 2022 11:07:52 +0800, Irui Wang wrote: > > There are venc node warnings when running dtbs_check, the clock- > > names > > was unexpected, missing properties '#address-cells' and '#size- > > cells'. > > Add the corresponding platform compatible to schema. > > > > Signed-off-by: Irui Wang <irui.wang@mediatek.com> > > --- > > .../bindings/media/mediatek,vcodec-encoder.yaml | 12 > > +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for > dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ Yes, it's not a new warning, the 'clock-names' in mt8192.dtsi was already unexpected without the patch's schema, we will fix it in the future patch. Thanks Best Regards > > > vcodec@17020000: clock-names:0: 'venc_sel' was expected > arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dtb > arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dtb > arch/arm64/boot/dts/mediatek/mt8192-evb.dtb >
diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml index 32aee09aea33..0f2ea8d9a10c 100644 --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml @@ -67,6 +67,12 @@ properties: power-domains: maxItems: 1 + "#address-cells": + const: 2 + + "#size-cells": + const: 2 + required: - compatible - reg @@ -84,7 +90,9 @@ allOf: contains: enum: - mediatek,mt8183-vcodec-enc + - mediatek,mt8188-vcodec-enc - mediatek,mt8192-vcodec-enc + - mediatek,mt8195-vcodec-enc then: required: @@ -107,7 +115,9 @@ allOf: compatible: enum: - mediatek,mt8173-vcodec-enc + - mediatek,mt8188-vcodec-enc - mediatek,mt8192-vcodec-enc + - mediatek,mt8195-vcodec-enc then: properties: @@ -118,7 +128,7 @@ allOf: clock-names: items: - const: venc_sel - else: # for vp8 hw decoder + else: # for vp8 hw encoder properties: clock: items:
There are venc node warnings when running dtbs_check, the clock-names was unexpected, missing properties '#address-cells' and '#size-cells'. Add the corresponding platform compatible to schema. Signed-off-by: Irui Wang <irui.wang@mediatek.com> --- .../bindings/media/mediatek,vcodec-encoder.yaml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)