diff mbox series

[2/2] wifi: mt76: mt7915: add two additional errors to ack-failure mask.

Message ID 20220929151526.9559-2-greearb@candelatech.com (mailing list archive)
State Rejected
Delegated to: Felix Fietkau
Headers show
Series [1/2] wifi: mt76: mt7915: fix bounds checking for tx-free-done command | expand

Commit Message

Ben Greear Sept. 29, 2022, 3:15 p.m. UTC 
From: Ben Greear <greearb@candelatech.com>

These other two bits also indicate tx failure as far as I can tell from
reading the documents.

Signed-off-by: Ben Greear <greearb@candelatech.com>
---
 drivers/net/wireless/mediatek/mt76/mt76_connac2_mac.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Felix Fietkau Oct. 1, 2022, 11:44 a.m. UTC | #1 
On 29.09.22 17:15, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> These other two bits also indicate tx failure as far as I can tell from
> reading the documents.
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>
The bits seem to have overlapping meaning, not sure if they always 
reliably indicate an error. I think we should leave this patch out, as 
it could potentially cause regressions.

- Felix
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac2_mac.h b/drivers/net/wireless/mediatek/mt76/mt76_connac2_mac.h
index 67ce216fb564..075048ab784f 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac2_mac.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac2_mac.h
@@ -133,10 +133,12 @@  enum {
 #define MT_TXS0_TXOP_TIMEOUT		BIT(20)
 #define MT_TXS0_BIP_ERROR		BIT(19)
 
+#define MT_TXS0_TXOP_LIMIT		BIT(20)
+#define MT_TXS0_BIP_OR_BF_ERROR		BIT(19)
 #define MT_TXS0_QUEUE_TIMEOUT		BIT(18)
 #define MT_TXS0_RTS_TIMEOUT		BIT(17)
 #define MT_TXS0_ACK_TIMEOUT		BIT(16)
-#define MT_TXS0_ACK_ERROR_MASK		GENMASK(18, 16)
+#define MT_TXS0_ACK_ERROR_MASK		GENMASK(20, 16)
 
 #define MT_TXS0_TX_STATUS_HOST		BIT(15)
 #define MT_TXS0_TX_STATUS_MCU		BIT(14)