diff mbox series

[v2,-next,1/4] ASoC: wm8997: Fix PM disable depth imbalance in wm8997_probe

Message ID 20220929150653.63845-2-zhangqilong3@huawei.com (mailing list archive)
State Accepted
Commit fdabc3f10e774ddc86ba715b9bc0c861d7e0834c
Headers show
Series Fix PM disable depth imbalance in probe | expand

Commit Message

Zhang Qilong Sept. 29, 2022, 3:06 p.m. UTC 
The pm_runtime_enable will increase power disable depth. Thus
a pairing decrement is needed on the error handling path to
keep it balanced according to context. We fix it by calling
pm_runtime_disable when error returns.

Fixes:40843aea5a9bd ("ASoC: wm8997: Initial CODEC driver")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
v2:
- call pm_runtime_disable when error returns
---
 sound/soc/codecs/wm8997.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Charles Keepax Oct. 3, 2022, 10:05 a.m. UTC | #1 
On Thu, Sep 29, 2022 at 11:06:50PM +0800, Zhang Qilong wrote:
> The pm_runtime_enable will increase power disable depth. Thus
> a pairing decrement is needed on the error handling path to
> keep it balanced according to context. We fix it by calling
> pm_runtime_disable when error returns.
> 
> Fixes:40843aea5a9bd ("ASoC: wm8997: Initial CODEC driver")
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
> v2:
> - call pm_runtime_disable when error returns
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
diff mbox series

Patch

diff --git a/sound/soc/codecs/wm8997.c b/sound/soc/codecs/wm8997.c
index 210ad662fc26..c0207e9a7d53 100644
--- a/sound/soc/codecs/wm8997.c
+++ b/sound/soc/codecs/wm8997.c
@@ -1187,6 +1187,7 @@  static int wm8997_probe(struct platform_device *pdev)
 err_spk_irqs:
 	arizona_free_spk_irqs(arizona);
 err_jack_codec_dev:
+	pm_runtime_disable(&pdev->dev);
 	arizona_jack_codec_dev_remove(&wm8997->core);
 
 	return ret;