| Message ID | 20220923160137.1991101-1-andrzej.hajda@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [i-g-t] gem_ctx_persistence: adjust reset timeout | expand |
Acked-by: Nirmoy Das <nirmoy.das@intel.com> On 9/23/2022 6:01 PM, Andrzej Hajda wrote: > Tests on DG2 show that context cancel can take even 350ms, > due to error state capturing in guc_handle_context_reset. > Since it happens only in debug mode and tests runs in debug mode > it should be fine to adjust the timeout. > Let's double this value, to be on safe side. > It should fix multiple test timeout failures. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1551 > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5891 > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3952 > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> > --- > tests/i915/gem_ctx_persistence.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c > index 50196edb19f..a844439de19 100644 > --- a/tests/i915/gem_ctx_persistence.c > +++ b/tests/i915/gem_ctx_persistence.c > @@ -1214,7 +1214,7 @@ static void do_test(void (*test)(int i915, const intel_ctx_cfg_t *cfg, > if (timeout != -1) { > igt_require(gem_engine_property_printf(i915, name, > ATTR, "%d", 50) > 0); > - reset_timeout_ms = 200; > + reset_timeout_ms = 700; > } > > test(i915, cfg, engine);
On 2022-09-23 at 18:01:37 +0200, Andrzej Hajda wrote: > Tests on DG2 show that context cancel can take even 350ms, > due to error state capturing in guc_handle_context_reset. > Since it happens only in debug mode and tests runs in debug mode > it should be fine to adjust the timeout. > Let's double this value, to be on safe side. > It should fix multiple test timeout failures. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1551 > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5891 > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3952 > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com> > --- > tests/i915/gem_ctx_persistence.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c > index 50196edb19f..a844439de19 100644 > --- a/tests/i915/gem_ctx_persistence.c > +++ b/tests/i915/gem_ctx_persistence.c > @@ -1214,7 +1214,7 @@ static void do_test(void (*test)(int i915, const intel_ctx_cfg_t *cfg, > if (timeout != -1) { > igt_require(gem_engine_property_printf(i915, name, > ATTR, "%d", 50) > 0); > - reset_timeout_ms = 200; > + reset_timeout_ms = 700; > } > > test(i915, cfg, engine); > -- > 2.34.1 >
diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c index 50196edb19f..a844439de19 100644 --- a/tests/i915/gem_ctx_persistence.c +++ b/tests/i915/gem_ctx_persistence.c @@ -1214,7 +1214,7 @@ static void do_test(void (*test)(int i915, const intel_ctx_cfg_t *cfg, if (timeout != -1) { igt_require(gem_engine_property_printf(i915, name, ATTR, "%d", 50) > 0); - reset_timeout_ms = 200; + reset_timeout_ms = 700; } test(i915, cfg, engine);
Tests on DG2 show that context cancel can take even 350ms, due to error state capturing in guc_handle_context_reset. Since it happens only in debug mode and tests runs in debug mode it should be fine to adjust the timeout. Let's double this value, to be on safe side. It should fix multiple test timeout failures. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1551 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5891 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3952 Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> --- tests/i915/gem_ctx_persistence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)