| Message ID | 20220928043957.2636877-4-joel@jms.id.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tpm: tsi-i2c: Add compatible strings | expand |
On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote: > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface. > > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/ > > Add a compatible string for it, and the generic compatible. > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > drivers/char/tpm/tpm_tis_i2c.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c > index 0692510dfcab..4af27b7ec5b1 100644 > --- a/drivers/char/tpm/tpm_tis_i2c.c > +++ b/drivers/char/tpm/tpm_tis_i2c.c > @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id); > #ifdef CONFIG_OF > static const struct of_device_id of_tis_i2c_match[] = { > { .compatible = "infineon,slb9673", }, > + { .compatible = "nuvoton,npct75x", }, > + { .compatible = "tcg,tpm-tis-i2c", }, If there is not currently any distinction that the kernel makes, you only need to add "tcg,tpm-tis-i2c". > {} > }; > MODULE_DEVICE_TABLE(of, of_tis_i2c_match); > -- > 2.35.1 > >
On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote: > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface. > > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/ > > Add a compatible string for it, and the generic compatible. > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > drivers/char/tpm/tpm_tis_i2c.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c > index 0692510dfcab..4af27b7ec5b1 100644 > --- a/drivers/char/tpm/tpm_tis_i2c.c > +++ b/drivers/char/tpm/tpm_tis_i2c.c > @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id); > #ifdef CONFIG_OF > static const struct of_device_id of_tis_i2c_match[] = { > { .compatible = "infineon,slb9673", }, > + { .compatible = "nuvoton,npct75x", }, > + { .compatible = "tcg,tpm-tis-i2c", }, > {} > }; > MODULE_DEVICE_TABLE(of, of_tis_i2c_match); > -- > 2.35.1 > Acked-by: Jarkko Sakkinen <jarkko@kernel.org> IMHO could be picked to the same tree with DT changes instead of my tree. BR, Jarkko
On Fri, Sep 30, 2022 at 4:47 PM Jarkko Sakkinen <jarkko@kernel.org> wrote: > > On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote: > > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface. > > > > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/ > > > > Add a compatible string for it, and the generic compatible. > > > > Signed-off-by: Joel Stanley <joel@jms.id.au> > > --- > > drivers/char/tpm/tpm_tis_i2c.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c > > index 0692510dfcab..4af27b7ec5b1 100644 > > --- a/drivers/char/tpm/tpm_tis_i2c.c > > +++ b/drivers/char/tpm/tpm_tis_i2c.c > > @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id); > > #ifdef CONFIG_OF > > static const struct of_device_id of_tis_i2c_match[] = { > > { .compatible = "infineon,slb9673", }, > > + { .compatible = "nuvoton,npct75x", }, > > + { .compatible = "tcg,tpm-tis-i2c", }, > > {} > > }; > > MODULE_DEVICE_TABLE(of, of_tis_i2c_match); > > -- > > 2.35.1 > > > > Acked-by: Jarkko Sakkinen <jarkko@kernel.org> > > IMHO could be picked to the same tree with DT changes instead > of my tree. It's supposed to be the other way around. DT bindings go with drivers via subsystem tree. I don't take drivers. But it seems this first needs some coordination with this[1] series. Rob [1] https://lore.kernel.org/all/20220930165116.13329-1-Alexander.Steffen@infineon.com/
On Tue, Oct 04, 2022 at 04:20:56PM -0500, Rob Herring wrote: > On Fri, Sep 30, 2022 at 4:47 PM Jarkko Sakkinen <jarkko@kernel.org> wrote: > > > > On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote: > > > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface. > > > > > > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/ > > > > > > Add a compatible string for it, and the generic compatible. > > > > > > Signed-off-by: Joel Stanley <joel@jms.id.au> > > > --- > > > drivers/char/tpm/tpm_tis_i2c.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c > > > index 0692510dfcab..4af27b7ec5b1 100644 > > > --- a/drivers/char/tpm/tpm_tis_i2c.c > > > +++ b/drivers/char/tpm/tpm_tis_i2c.c > > > @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id); > > > #ifdef CONFIG_OF > > > static const struct of_device_id of_tis_i2c_match[] = { > > > { .compatible = "infineon,slb9673", }, > > > + { .compatible = "nuvoton,npct75x", }, > > > + { .compatible = "tcg,tpm-tis-i2c", }, > > > {} > > > }; > > > MODULE_DEVICE_TABLE(of, of_tis_i2c_match); > > > -- > > > 2.35.1 > > > > > > > Acked-by: Jarkko Sakkinen <jarkko@kernel.org> > > > > IMHO could be picked to the same tree with DT changes instead > > of my tree. > > It's supposed to be the other way around. DT bindings go with drivers > via subsystem tree. I don't take drivers. > > But it seems this first needs some coordination with this[1] series. > > Rob > > [1] https://lore.kernel.org/all/20220930165116.13329-1-Alexander.Steffen@infineon.com/ WFM, I can pick it (once the issues are fixed). BR, Jarkko
On Fri, 30 Sept 2022 at 14:44, Rob Herring <robh@kernel.org> wrote: > > On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote: > > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface. > > > > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/ > > > > Add a compatible string for it, and the generic compatible. > > > > Signed-off-by: Joel Stanley <joel@jms.id.au> > > --- > > drivers/char/tpm/tpm_tis_i2c.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c > > index 0692510dfcab..4af27b7ec5b1 100644 > > --- a/drivers/char/tpm/tpm_tis_i2c.c > > +++ b/drivers/char/tpm/tpm_tis_i2c.c > > @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id); > > #ifdef CONFIG_OF > > static const struct of_device_id of_tis_i2c_match[] = { > > { .compatible = "infineon,slb9673", }, > > + { .compatible = "nuvoton,npct75x", }, > > + { .compatible = "tcg,tpm-tis-i2c", }, > > If there is not currently any distinction that the kernel makes, you > only need to add "tcg,tpm-tis-i2c". There are device trees that just have one or the other, so it makes sense to list both. > > > {} > > }; > > MODULE_DEVICE_TABLE(of, of_tis_i2c_match); > > -- > > 2.35.1 > > > >
On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote: > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface. > > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/ > > Add a compatible string for it, and the generic compatible. > > Signed-off-by: Joel Stanley <joel@jms.id.au> Does anyone happen to know why this patch never made it upstream ? Thanks, Guenter > --- > drivers/char/tpm/tpm_tis_i2c.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c > index 0692510dfcab..4af27b7ec5b1 100644 > --- a/drivers/char/tpm/tpm_tis_i2c.c > +++ b/drivers/char/tpm/tpm_tis_i2c.c > @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id); > #ifdef CONFIG_OF > static const struct of_device_id of_tis_i2c_match[] = { > { .compatible = "infineon,slb9673", }, > + { .compatible = "nuvoton,npct75x", }, > + { .compatible = "tcg,tpm-tis-i2c", }, > {} > }; > MODULE_DEVICE_TABLE(of, of_tis_i2c_match); > -- > 2.35.1 >
diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c index 0692510dfcab..4af27b7ec5b1 100644 --- a/drivers/char/tpm/tpm_tis_i2c.c +++ b/drivers/char/tpm/tpm_tis_i2c.c @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id); #ifdef CONFIG_OF static const struct of_device_id of_tis_i2c_match[] = { { .compatible = "infineon,slb9673", }, + { .compatible = "nuvoton,npct75x", }, + { .compatible = "tcg,tpm-tis-i2c", }, {} }; MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface. https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/ Add a compatible string for it, and the generic compatible. Signed-off-by: Joel Stanley <joel@jms.id.au> --- drivers/char/tpm/tpm_tis_i2c.c | 2 ++ 1 file changed, 2 insertions(+)