| Message ID | 20221005152752.318493-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (fschmd) Make const arrays static const | expand |
On Wed, Oct 05, 2022 at 04:27:52PM +0100, Colin Ian King wrote: > Don't populate the read-only const arrays names and watchdog_minors > on the stack but instead make them static const. Also makes the > object code a little smaller. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Applied to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/fschmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c > index 0a77d6161928..e1f426e86f36 100644 > --- a/drivers/hwmon/fschmd.c > +++ b/drivers/hwmon/fschmd.c > @@ -1083,9 +1083,9 @@ static int fschmd_detect(struct i2c_client *client, > static int fschmd_probe(struct i2c_client *client) > { > struct fschmd_data *data; > - const char * const names[7] = { "Poseidon", "Hermes", "Scylla", > + static const char * const names[7] = { "Poseidon", "Hermes", "Scylla", > "Heracles", "Heimdall", "Hades", "Syleus" }; > - const int watchdog_minors[] = { WATCHDOG_MINOR, 212, 213, 214, 215 }; > + static const int watchdog_minors[] = { WATCHDOG_MINOR, 212, 213, 214, 215 }; > int i, err; > enum chips kind = i2c_match_id(fschmd_id, client)->driver_data; >
diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c index 0a77d6161928..e1f426e86f36 100644 --- a/drivers/hwmon/fschmd.c +++ b/drivers/hwmon/fschmd.c @@ -1083,9 +1083,9 @@ static int fschmd_detect(struct i2c_client *client, static int fschmd_probe(struct i2c_client *client) { struct fschmd_data *data; - const char * const names[7] = { "Poseidon", "Hermes", "Scylla", + static const char * const names[7] = { "Poseidon", "Hermes", "Scylla", "Heracles", "Heimdall", "Hades", "Syleus" }; - const int watchdog_minors[] = { WATCHDOG_MINOR, 212, 213, 214, 215 }; + static const int watchdog_minors[] = { WATCHDOG_MINOR, 212, 213, 214, 215 }; int i, err; enum chips kind = i2c_match_id(fschmd_id, client)->driver_data;
Don't populate the read-only const arrays names and watchdog_minors on the stack but instead make them static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/hwmon/fschmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)