| Message ID | 20221005174343.24240-6-y.oudjana@protonmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MediaTek pinctrl DT binding cleanup and MT6735 pinctrl support | expand |
On Wed, 05 Oct 2022 20:43:38 +0300, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > The document currently states a maximum of 1 interrupt, but the DT > has 2 specified causing a dtbs_check error. Change the limit to 2 > to pass the check and add a minimum limit. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- > .../devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.example.dtb: pinctrl@10005000: interrupts: [[0, 153, 4]] is too short From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Il 05/10/22 19:43, Yassine Oudjana ha scritto: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > The document currently states a maximum of 1 interrupt, but the DT > has 2 specified causing a dtbs_check error. Change the limit to 2 > to pass the check and add a minimum limit. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- > .../devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml > index 73ae6e11410b..483fcdc60487 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml > @@ -47,7 +47,8 @@ properties: > > interrupts: > description: The interrupt outputs to sysirq. > - maxItems: 1 > + minItems: 2 > + maxItems: 2 > > # PIN CONFIGURATION NODES > patternProperties: Nice catch. The right thing to do is... interrupts: description: The interrupt outputs to sysirq. minItems: 1 - description: EINT interrupt - description: EINT event_b interrupt Cheers, Angelo
On Thu, Oct 6 2022 at 11:01:29 AM +0200, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > Il 05/10/22 19:43, Yassine Oudjana ha scritto: >> From: Yassine Oudjana <y.oudjana@protonmail.com> >> >> The document currently states a maximum of 1 interrupt, but the DT >> has 2 specified causing a dtbs_check error. Change the limit to 2 >> to pass the check and add a minimum limit. >> >> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> >> --- >> .../devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml | 3 >> ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml >> b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml >> index 73ae6e11410b..483fcdc60487 100644 >> --- >> a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml >> +++ >> b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml >> @@ -47,7 +47,8 @@ properties: >> interrupts: >> description: The interrupt outputs to sysirq. >> - maxItems: 1 >> + minItems: 2 >> + maxItems: 2 >> # PIN CONFIGURATION NODES >> patternProperties: > > Nice catch. > The right thing to do is... > > interrupts: > description: The interrupt outputs to sysirq. > minItems: 1 > - description: EINT interrupt > - description: EINT event_b interrupt I didn't know what the interrupts where exactly and if either one is optional so just to be safe I set the limit to 2. I'll do that nex time. Thanks, Yassine >
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml index 73ae6e11410b..483fcdc60487 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml @@ -47,7 +47,8 @@ properties: interrupts: description: The interrupt outputs to sysirq. - maxItems: 1 + minItems: 2 + maxItems: 2 # PIN CONFIGURATION NODES patternProperties: